From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] jsflash: fix compilation To: David Miller Cc: hch@lst.de, linux-block@vger.kernel.org, sparclinux@vger.kernel.org References: <0d9ca090-5277-6c1c-9bff-477054f97746@kernel.dk> <20180515.145810.2201898778026946067.davem@davemloft.net> <0ec7d5d1-cd5f-b415-b866-1b3daa9fa840@kernel.dk> <20180515.155118.1408865987817486838.davem@davemloft.net> From: Jens Axboe Message-ID: Date: Tue, 15 May 2018 13:57:41 -0600 MIME-Version: 1.0 In-Reply-To: <20180515.155118.1408865987817486838.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 List-ID: On 5/15/18 1:51 PM, David Miller wrote: > From: Jens Axboe > Date: Tue, 15 May 2018 13:00:36 -0600 > >> On 5/15/18 12:58 PM, David Miller wrote: >>> From: Jens Axboe >>> Date: Tue, 15 May 2018 12:51:20 -0600 >>> >>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote: >>>>> No bio in this whole function, use req->bio instead. >>>> >>>> Applied. >>>> >>>>> Looks like no one except for Guenters build bot cared. I wonder if we >>>>> should just get rid of the driver given that it doesn't look in a good >>>>> shape at all based on his build logs even with the fix.. >>>> >>>> Needs input from the folks that actually might use it. The driver looks >>>> abandoned, it's only getting updates through API changes etc. >>> >>> I don't think anyone is using it. >> >> Are you fine with removing it then? > > Yes, I am: > > Acked-by: David S. Miller Great, done! -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Tue, 15 May 2018 19:57:41 +0000 Subject: Re: [PATCH] jsflash: fix compilation Message-Id: List-Id: References: <0d9ca090-5277-6c1c-9bff-477054f97746@kernel.dk> <20180515.145810.2201898778026946067.davem@davemloft.net> <0ec7d5d1-cd5f-b415-b866-1b3daa9fa840@kernel.dk> <20180515.155118.1408865987817486838.davem@davemloft.net> In-Reply-To: <20180515.155118.1408865987817486838.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: hch@lst.de, linux-block@vger.kernel.org, sparclinux@vger.kernel.org On 5/15/18 1:51 PM, David Miller wrote: > From: Jens Axboe > Date: Tue, 15 May 2018 13:00:36 -0600 > >> On 5/15/18 12:58 PM, David Miller wrote: >>> From: Jens Axboe >>> Date: Tue, 15 May 2018 12:51:20 -0600 >>> >>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote: >>>>> No bio in this whole function, use req->bio instead. >>>> >>>> Applied. >>>> >>>>> Looks like no one except for Guenters build bot cared. I wonder if we >>>>> should just get rid of the driver given that it doesn't look in a good >>>>> shape at all based on his build logs even with the fix.. >>>> >>>> Needs input from the folks that actually might use it. The driver looks >>>> abandoned, it's only getting updates through API changes etc. >>> >>> I don't think anyone is using it. >> >> Are you fine with removing it then? > > Yes, I am: > > Acked-by: David S. Miller Great, done! -- Jens Axboe