From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77F92C433F5 for ; Mon, 2 May 2022 07:41:29 +0000 (UTC) Received: from localhost ([::1]:50110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlQgS-0002gD-2L for qemu-devel@archiver.kernel.org; Mon, 02 May 2022 03:41:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlQcU-0001EB-Rm for qemu-devel@nongnu.org; Mon, 02 May 2022 03:37:22 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:40387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlQcT-0006F6-3T for qemu-devel@nongnu.org; Mon, 02 May 2022 03:37:22 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 15ADF40124; Mon, 2 May 2022 10:37:16 +0300 (MSK) Received: from [192.168.177.130] (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id D49CA10C; Mon, 2 May 2022 10:31:55 +0300 (MSK) Message-ID: Date: Mon, 2 May 2022 10:37:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH 10/12] pc-bios/optionrom: compile with -Wno-array-bounds Content-Language: en-US To: Paolo Bonzini , qemu-devel@nongnu.org References: <20220429141813.328975-1-pbonzini@redhat.com> <20220429141813.328975-11-pbonzini@redhat.com> From: Michael Tokarev In-Reply-To: <20220429141813.328975-11-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard.henderson@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 29.04.2022 17:18, Paolo Bonzini wrote: > Avoids the following bogus warning: > > pvh_main.c: In function ‘pvh_load_kernel’: > pvh_main.c:101:42: warning: array subscript 0 is outside array bounds of ‘uint16_t[0]’ {aka ‘short unsigned int[]’} [-Warray-bounds] > 101 | uint32_t ebda_paddr = ((uint32_t)*((uint16_t *)EBDA_BASE_ADDR)) << 4; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ To me it looks like we should try to fix this particular expression to make it more "compiler-friendly" than to disable warning for the whole thing. Which compiler (version) does this? Thanks, /mjt