From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78EFC433ED for ; Thu, 15 Apr 2021 13:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1E65613C0 for ; Thu, 15 Apr 2021 13:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232993AbhDONxK (ORCPT ); Thu, 15 Apr 2021 09:53:10 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:44906 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231549AbhDONxH (ORCPT ); Thu, 15 Apr 2021 09:53:07 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=[192.168.100.150]) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lX2Q7-000Mfx-Pl; Thu, 15 Apr 2021 16:52:37 +0300 Message-ID: From: Luca Coelho To: kvalo@codeaurora.org Cc: jikos@kernel.org, hdegoede@redhat.com, johannes@sipsolutions.net, linux-wireless@vger.kernel.org Date: Thu, 15 Apr 2021 16:52:35 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH for -next] iwlwifi: pcie: don't enable BHs with IRQs disabled Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2021-04-15 at 16:48 +0300, Luca Coelho wrote: > From: Johannes Berg > > After the fix from Jiri that disabled local IRQs instead of > just BHs (necessary to fix an issue with submitting a command > with IRQs already disabled), there was still a situation in > which we could deep in there enable BHs, if the device config > sets the apmg_wake_up_wa configuration, which is true on all > 7000 series devices. > > To fix that, but not require reverting commit 1ed08f6fb5ae > ("iwlwifi: remove flags argument for nic_access"), split up > nic access into a version with BH manipulation to use most > of the time, and without it for this specific case where the > local IRQs are already disabled. > > Signed-off-by: Johannes Berg > Signed-off-by: Luca Coelho > --- Kalle, I'm going to assign this one to you too, but this time for -next and not for -fixes. This is related to the fix Jiri made, but to avoid some conflicts and a broken v5.13-rc, we want to get it into v5.13 if still possible. So can you please take this on top of my latest pull request? Additionally, can you tag it for stable? Thanks! -- Cheers, Luca.