From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C66BC4363D for ; Tue, 22 Sep 2020 16:46:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3192F20738 for ; Tue, 22 Sep 2020 16:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="klNTjtDn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3192F20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKlRB-00069a-ER; Tue, 22 Sep 2020 16:46:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKlRA-00069T-2L for xen-devel@lists.xenproject.org; Tue, 22 Sep 2020 16:46:40 +0000 X-Inumbo-ID: 01741aa5-edc7-4485-9aa7-d365d94ea884 Received: from mail-lj1-x241.google.com (unknown [2a00:1450:4864:20::241]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01741aa5-edc7-4485-9aa7-d365d94ea884; Tue, 22 Sep 2020 16:46:39 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id b19so14705322lji.11 for ; Tue, 22 Sep 2020 09:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=BLRGLhcUIhVvNtoaHSvdnc9LDJiV3a0ixwch5s+oXpc=; b=klNTjtDn2a9dXa+YLn4SKwx6xPx46WPI807Q3SIL2A4i03P1TYvZzdkFVEXJxWB9u4 DSRT/i0OMH3W2xGgb8mpnRQflzc+6OiA2VWZ/eOnsRdrO9529/Yq1sKc7YUBeXFQV/bs z/jk+ZRLPZX0po0FGFX7NTJSm/Javmbe9fqEF/X296KxskC/EsOX/yM0+6TrBB+t9y4W 2p+nGq06B1HojXhXtnOZFcXkXaTgIdVevxb1dqVH6/OUM7f3lEPkazZwlh8yKkMQr7xo QMh5Oy7ILozqUwjqxXHSdMJLy7Si3N89tyPljvsNWeiBfu5ZtbO3+cdvTpl9Rq15jJwY o8IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=BLRGLhcUIhVvNtoaHSvdnc9LDJiV3a0ixwch5s+oXpc=; b=nNIdSEpRkaOkG/08nRCRWXgr7iAsfh3+k40va6IZSXNTElzlkMhq+fr1ywtoQAXQVH gyJc04oJXICh/Elc4ByKkgwxWxd6ZEOmPYxgKQkBqlGxFxEDBlKzd0HgYqmI6wQH5WQW Rx1v9jv3mgZ1A9aDdJZGbkG5N+1BCEl+P0P+9A0lwl23g1wyUQmBjnWbqsrxolV6s91W IPr2ngtMTQyGoFbAjY7krRsfT5GxDJ41J+b1Sy6seR6Y1068K5UP1AE/bIkFS91fF2EC X24KqE7dcwkVfftWuF/1/abrNhJLGVg3ObZNwtSpk6mOqz5bP7hONIgaiURkRB8zDzSZ MBHA== X-Gm-Message-State: AOAM5316cYCubiO21qF1MP/nvC9SsgW83wynwl+kRIqpES2EtKG9fYK5 6FvBD1Odpi49AWWaQAb9nZU= X-Google-Smtp-Source: ABdhPJzsKLh16jTlRq/6ncgUYSEKE9K0oabepwJR0I8X2+khNe/QDhy75gCgN7lVm6DFO9NfZuXpfA== X-Received: by 2002:a2e:86d3:: with SMTP id n19mr1933875ljj.368.1600793197961; Tue, 22 Sep 2020 09:46:37 -0700 (PDT) Received: from [192.168.1.6] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id n4sm3653694lfe.246.2020.09.22.09.46.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 09:46:37 -0700 (PDT) Subject: Re: [PATCH V1 07/16] xen/dm: Make x86's DM feature common To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Daniel De Graaf , Julien Grall References: <1599769330-17656-1-git-send-email-olekstysh@gmail.com> <1599769330-17656-8-git-send-email-olekstysh@gmail.com> <70919183-5215-2efb-d399-2b2d5dd8b5ed@suse.com> From: Oleksandr Message-ID: Date: Tue, 22 Sep 2020 19:46:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <70919183-5215-2efb-d399-2b2d5dd8b5ed@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 14.09.20 18:56, Jan Beulich wrote: Hi Jan > On 10.09.2020 22:22, Oleksandr Tyshchenko wrote: >> --- a/xen/include/xen/hypercall.h >> +++ b/xen/include/xen/hypercall.h >> @@ -150,6 +150,18 @@ do_dm_op( >> unsigned int nr_bufs, >> XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs); >> >> +struct dmop_args { >> + domid_t domid; >> + unsigned int nr_bufs; >> + /* Reserve enough buf elements for all current hypercalls. */ >> + struct xen_dm_op_buf buf[2]; >> +}; >> + >> +int arch_dm_op(struct xen_dm_op *op, >> + struct domain *d, >> + const struct dmop_args *op_args, >> + bool *const_op); >> + >> #ifdef CONFIG_HYPFS >> extern long >> do_hypfs_op( > There are exactly two CUs which need to see these two declarations. > Personally I think they should go into a new header, or at least > into one that half-way fits (from the pov of its other contents) > and doesn't get included by half the code base. But maybe it's > just me ... I am afraid, I didn't get why this header is not suitable for keeping this stuff... But, I don't against moving this into a new header (probably dm.h?) -- Regards, Oleksandr Tyshchenko