All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, fio@vger.kernel.org
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>,
	Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH 0/2] Fix compilation error on BSD
Date: Thu, 28 May 2020 10:36:17 -0600	[thread overview]
Message-ID: <bab7fabe-e1ac-fae0-b240-046c60ff243c@kernel.dk> (raw)
In-Reply-To: <20200528125642.103863-1-shinichiro.kawasaki@wdc.com>

On 5/28/20 6:56 AM, Shin'ichiro Kawasaki wrote:
> It was reported that the commit b76949618d55 ("fio: Generalize zonemode=zbd")
> triggered a compilation failure of zbd.c on NetBSD which does not have
> pthread_mutexattr_setpshared(). This patch series addresses the failure. To
> avoid pthread_mutexattr_setpshared() calls, utilize helper functions pshared.c
> provides.
> 
> The first patch adds another helper function in pshared.c to initialize mutex
> with attribute types desired. The second patch replace mutex initialization in
> zbd.c with the helper functions. To initialize mutex with POSIX_MUTEX_RECURSIVE
> attribute type, utilize the newly introduced function.
> 
> I do not have NetBSD (or other BSD) system then this series is not confirmed
> build pass on NetBSD. Confirmation by BSD users will be appreciated.

I've applied this for now, assuming the BSD interested parties will vet
them soon.

-- 
Jens Axboe



      parent reply	other threads:[~2020-05-28 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 12:56 [PATCH 0/2] Fix compilation error on BSD Shin'ichiro Kawasaki
2020-05-28 12:56 ` [PATCH 1/2] pshared: Add mutex_init_pshared_with_type() Shin'ichiro Kawasaki
2020-05-28 12:56 ` [PATCH 2/2] zbd: Fix compilation error on BSD Shin'ichiro Kawasaki
2020-05-28 16:36 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bab7fabe-e1ac-fae0-b240-046c60ff243c@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Damien.LeMoal@wdc.com \
    --cc=fio@vger.kernel.org \
    --cc=kusumi.tomohiro@gmail.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.