From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F40C433FE for ; Fri, 4 Dec 2020 13:52:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 555BB22AAD for ; Fri, 4 Dec 2020 13:52:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 555BB22AAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klBVA-0004Xn-Uk for qemu-devel@archiver.kernel.org; Fri, 04 Dec 2020 08:52:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klBTp-0003pj-Lx for qemu-devel@nongnu.org; Fri, 04 Dec 2020 08:50:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1klBTn-0000gF-8R for qemu-devel@nongnu.org; Fri, 04 Dec 2020 08:50:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607089834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+sn5rcDZl+QIXuATUZwzF5FMHKstgrHFxwSTzFxKZ+4=; b=PA9km2opcDIwmuX8uvt8qFU1G7qEYBPZqVI1yRUPnrFSAWDtwvq0C2OTTjRQ5RTnX7RCh5 xNcnUF9EUIWse0zZZbuK28d97WhAeE3xj3Tkbiw3vPNNa/5wlelGzyhe6Uk/Z3o8Agcpub hwnKUeSjdGUJ9+0TWVFYAWJkIeEVdFM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-nDxkQF1aOrmOWQSH2zXnzQ-1; Fri, 04 Dec 2020 08:50:31 -0500 X-MC-Unique: nDxkQF1aOrmOWQSH2zXnzQ-1 Received: by mail-ej1-f72.google.com with SMTP id g18so2088239eje.1 for ; Fri, 04 Dec 2020 05:50:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+sn5rcDZl+QIXuATUZwzF5FMHKstgrHFxwSTzFxKZ+4=; b=HtzyZH/luvtWzoBx+ioZE/Q83e1njYGQhZThZgoAcPO4+68BW51PJbxU/d7NrAtolF TlcH3SIOyPvujoWk6n2ueV2z3A/AoGLaPu0VblT4kjOgfRkN1hOK18eJEIzCGFCHinQ3 PT7/1toqxAl9AoyRxRtrJ3JeyvGh/WfAFPzef0BAVu0KEXZ1mrelxf9haME7KUjw7n2K hQDXi8b0U4JHcfOK29WNDauxFCu2XZC4kq7Htj90v3JcZQ9nrsdd9J/1TChv9nqMZzc+ qfWw/c8SjsSeV1sh714rtLodRn0JCfJl6d6es27aLodfkb8V4fKPVGUlyprtIfBG93bE M6IQ== X-Gm-Message-State: AOAM533sP2x21xgeoGzjaneZ1zLVUli5PSLjHqZOYrquGnJOlhmkVxZk TXaUKKFapWWijuJUyDRbDEciQwXgTG6g1wZ1GCffpA/EtF+ebtnOgJP79/CT2FGg1Gf1lK5ZH/b OCqgZU2kKeclnzf4= X-Received: by 2002:a05:6402:1646:: with SMTP id s6mr7585191edx.319.1607089829744; Fri, 04 Dec 2020 05:50:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRY8+ymMqDTt5W71PFhqaSOhHRw5L2iB6E+SJ8m/N16FtcnbuLQTD5iiHj2VGhVEkSZApKQg== X-Received: by 2002:a05:6402:1646:: with SMTP id s6mr7585167edx.319.1607089829479; Fri, 04 Dec 2020 05:50:29 -0800 (PST) Received: from [192.168.1.36] (111.red-88-21-205.staticip.rima-tde.net. [88.21.205.111]) by smtp.gmail.com with ESMTPSA id t26sm3115044eji.22.2020.12.04.05.50.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Dec 2020 05:50:28 -0800 (PST) Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category To: ganqixin , "qemu-devel@nongnu.org" , "qemu-trivial@nongnu.org" References: <20201115184903.1292715-1-ganqixin@huawei.com> <20201115184903.1292715-10-ganqixin@huawei.com> <49d4e8e3-7138-18cf-3972-c18e8275d3be@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Fri, 4 Dec 2020 14:50:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Chenqun \(kuhn\)" , "thuth@redhat.com" , Zhanghailiang , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/17/20 2:37 PM, ganqixin wrote: >> -----Original Message----- >> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com] >> Sent: Monday, November 16, 2020 10:05 PM >> To: ganqixin ; qemu-devel@nongnu.org; >> qemu-trivial@nongnu.org; Marc-André Lureau >> ; thuth@redhat.com >> Cc: Chenqun (kuhn) ; Zhanghailiang >> ; Gerd Hoffmann ; >> Eduardo Habkost >> Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category >> >> On 11/15/20 7:48 PM, Gan Qixin wrote: >>> The category of the u2f-passthru device is not set, put it into the 'usb' >>> category. >> >> I guess we discussed this with Thomas 1 or 2 years ago but I don't remember. >> I think it was about using set_bits() so devices can appear in multiple >> categories. >> >> Gerd, do you know what is the point of the "usb" category for management >> apps? This is a bus accepting multiple better categorized devices (display, >> storage, input, network, sound). >> >> Unrelated but multiple devices are related to SECURITY. >> Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY? > > Hi, Philippe > Thanks for your reply, but I'm not sure if it is appropriate to add a security category to place this device. > (Maybe it's because I don't know much about these device, I haven't find many safety-related devices in 'misc' category or uncategorized devices) What is the difference between 'misc' and 'uncategorized'? > > Thanks, > Gan Qixin >