From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 9 Feb 2020 23:33:36 +0100
Subject: [PATCH 1/1] log: output for CONFIG_LOG=n
In-Reply-To: <18e46523-0dda-f14a-8451-5ec603bd6a7f@gmail.com>
References: <20200209215935.77472-1-xypron.glpk@gmx.de>
 <18e46523-0dda-f14a-8451-5ec603bd6a7f@gmail.com>
Message-ID: <bac1a21e-18c9-4b90-6875-4cbcddf3317f@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 2/9/20 11:21 PM, Sean Anderson wrote:
> On 2/9/20 4:59 PM, Heinrich Schuchardt wrote:
>> If CONFIG_LOG=n, we should still output errors, warnings, notices, infos,
>> and for DEBUG=1 also debug messages.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Why not just change the default for CONFIG_LOG to y? This is effectively
> the same, except it still allows users to completely disable logging
> altogether.
>
> --Sean
>

I have tested your suggestion for qemu_arm64_defconfig:

Without my patch and CONFIG_LOG=n:

u-boot.bin 664200 bytes

With my patch and CONFIG_LOG=n:

u-boot.bin 664432 bytes

Without my patch but with CONFIG_LOG=y and CONFIG_CONSOLE=y:

u-boot.bin 666648 bytes

So your suggestion consumes 2216 additional bytes to produce the
essentially the same console output.

IMHO CONFIG_LOG=y is currently only helpful in the following situation:

* You are debugging your board and want to interactively change
   logging levels.
* You want to log to a remote syslog server.

Best regards

Heinrich