From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next,v3 10/12] dsa: bcm_sf2: use flow_rule infrastructure Date: Wed, 21 Nov 2018 20:56:08 -0800 Message-ID: References: <20181121025132.14305-1-pablo@netfilter.org> <20181121025132.14305-11-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, thomas.lendacky@amd.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com To: Pablo Neira Ayuso , netdev@vger.kernel.org Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:44196 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732792AbeKVPeA (ORCPT ); Thu, 22 Nov 2018 10:34:00 -0500 Received: by mail-pl1-f194.google.com with SMTP id s5-v6so8612983plq.11 for ; Wed, 21 Nov 2018 20:56:22 -0800 (PST) In-Reply-To: <20181121025132.14305-11-pablo@netfilter.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/20/2018 6:51 PM, Pablo Neira Ayuso wrote: > Update this driver to use the flow_rule infrastructure, hence we can use > the same code to populate hardware IR from ethtool_rx_flow and the > cls_flower interfaces. > > Signed-off-by: Pablo Neira Ayuso > --- [snip] > @@ -398,9 +411,10 @@ static int bcm_sf2_cfp_ipv4_rule_set(struct bcm_sf2_priv *priv, int port, > * Reserved [1] > * UDF_Valid[8] [0] > */ > - core_writel(priv, v4_spec->tos << IPTOS_SHIFT | > - ip_proto << IPPROTO_SHIFT | ip_frag << IP_FRAG_SHIFT | > - udf_upper_bits(num_udf), > + core_writel(priv, ip.key->tos << IPTOS_SHIFT | > + basic.key->n_proto << IPPROTO_SHIFT | > + ip_frag << IP_FRAG_SHIFT | > + udf_upper_bits(num_udf), Can you maintain the alignment of the arguments here? Every else looked okay, but I need to check the ipv6 structure to make sure we can access it as 4x32 bits words like we did before. -- Florian