From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DC5C2D0E4 for ; Fri, 27 Nov 2020 13:58:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98FC42224C for ; Fri, 27 Nov 2020 13:58:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="KLZuZzN+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98FC42224C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.39401.72292 (Exim 4.92) (envelope-from ) id 1kieGW-0003cx-Ib; Fri, 27 Nov 2020 13:58:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 39401.72292; Fri, 27 Nov 2020 13:58:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kieGW-0003cq-Eq; Fri, 27 Nov 2020 13:58:24 +0000 Received: by outflank-mailman (input) for mailman id 39401; Fri, 27 Nov 2020 13:58:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kieGU-0003ck-Lb for xen-devel@lists.xenproject.org; Fri, 27 Nov 2020 13:58:22 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e9c0cf2-45b9-4a56-8731-3a773da178d6; Fri, 27 Nov 2020 13:58:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F168FABD7; Fri, 27 Nov 2020 13:58:20 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kieGU-0003ck-Lb for xen-devel@lists.xenproject.org; Fri, 27 Nov 2020 13:58:22 +0000 X-Inumbo-ID: 7e9c0cf2-45b9-4a56-8731-3a773da178d6 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e9c0cf2-45b9-4a56-8731-3a773da178d6; Fri, 27 Nov 2020 13:58:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606485501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QsEKiEZyrFFrYEgyt5mes67Edy/pP1CE2btlFOYBUIY=; b=KLZuZzN+jv0gceMzhgdGA//GfBZOCcagCLXZFt3teieFeqiy5Sm5duLGlsTRUStFPBWasD VVc4a24XxxKgY2WIBZo5Y3peSZ71Ujz1SnLrwmfqdP/grFlC9fk1/LAAkEBLUDDsuNoX68 H5+l++MGCEUxT0+ITuy98BgLvwuEVU0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F168FABD7; Fri, 27 Nov 2020 13:58:20 +0000 (UTC) Subject: Re: [PATCH v4 3/3] ns16550: Gate all PCI code with CONFIG_X86 To: Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <6d64bb35a6ce247faaa3df2ebae27b6bfa1d969e.1606326929.git.rahul.singh@arm.com> From: Jan Beulich Message-ID: Date: Fri, 27 Nov 2020 14:58:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <6d64bb35a6ce247faaa3df2ebae27b6bfa1d969e.1606326929.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.11.2020 19:16, Rahul Singh wrote: > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -16,7 +16,7 @@ > #include > #include > #include > -#ifdef CONFIG_HAS_PCI > +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) > #include > #include > #include > @@ -51,7 +51,7 @@ static struct ns16550 { > unsigned int timeout_ms; > bool_t intr_works; > bool_t dw_usr_bsy; > -#ifdef CONFIG_HAS_PCI > +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) I'm sorry to be picky, but this being a hack wants, imo, also calling it so, by way of a code comment. Clearly this should go at one of the first instances, yet neither of the two above are really suitable imo. Hence I'm coming back to my prior suggestion of introducing a consolidated #define without this becoming a Kconfig setting: /* * The PCI part of the code in this file currently is only known to * work on x86. Undo this hack once the logic has been suitably * abstracted. */ #if defined(CONFIG_HAS_PCI) && defined(CONFIG_X86) # define NS16550_PCI #endif And then use NS16550_PCI everywhere. I'd be fine making this adjustment while committing, if I knew that (a) you're okay with it and (b) the R-b and A-b you've already got can be kept. Jan