All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <pali@kernel.org>, <u.kleine-koenig@pengutronix.de>
Cc: <Daire.McNamara@microchip.com>, <lorenzo.pieralisi@arm.com>,
	<robh@kernel.org>, <kw@linux.com>, <linux-pci@vger.kernel.org>,
	<ian@linux.cowan.aero>, <kernel@pengutronix.de>,
	<gregkh@linuxfoundation.org>, <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: microchip: Allow driver to be built as a module
Date: Thu, 21 Apr 2022 11:31:16 +0000	[thread overview]
Message-ID: <bad31f90-f853-fdff-c91c-1a695ff162d1@microchip.com> (raw)
In-Reply-To: <20220420164139.k37fc3xixn4j7kug@pali>

On 20/04/2022 16:41, Pali Rohár wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wednesday 20 April 2022 11:34:49 Uwe Kleine-König wrote:
>> There are no known reasons to not use this driver as a module,
> 
> Hello! I think that there are reasons. pcie-microchip-host.c driver uses
> builtin_platform_driver() and not module_platform_driver(); it does not
> implement .remove driver callback and also has set suppress_bind_attrs
> to true. I think that all these parts should be properly implemented
> otherwise it does not have sane reasons to use driver as loadable and
> unloadable module.
> 
> Btw, I implemented proper module support for pci-mvebu.c driver
> recently, so you can take an inspiration. See:
> https://lore.kernel.org/linux-pci/20211126144307.7568-1-pali@kernel.org/t/#u

Hmm, so what is the way forward here, are you happy to do it yourself
or do you not have the hardware/would rather that we did it?

If you'd prefer that we did it, do we change the driver & submit that
as a series with this patch as patch 2/2? Or should it be a single
patch with your suggested-by?
Not quite sure what the expectation is with attestation for something
like this.

Thanks,
Conor

  reply	other threads:[~2022-04-21 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  9:34 [PATCH] PCI: microchip: Allow driver to be built as a module Uwe Kleine-König
2022-04-20 16:41 ` Pali Rohár
2022-04-21 11:31   ` Conor.Dooley [this message]
2022-04-21 13:41     ` Pali Rohár
2022-04-21 13:55       ` Conor.Dooley
2022-04-21 16:18         ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bad31f90-f853-fdff-c91c-1a695ff162d1@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=Daire.McNamara@microchip.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ian@linux.cowan.aero \
    --cc=kernel@pengutronix.de \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.