From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFB8C433E0 for ; Fri, 12 Feb 2021 08:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1261264E57 for ; Fri, 12 Feb 2021 08:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbhBLIQO convert rfc822-to-8bit (ORCPT ); Fri, 12 Feb 2021 03:16:14 -0500 Received: from mga05.intel.com ([192.55.52.43]:1231 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbhBLIP4 (ORCPT ); Fri, 12 Feb 2021 03:15:56 -0500 IronPort-SDR: RWT7fVn9bT4b7fDU8Tn0z9DW06Uyv4ArsEn32t28y22jL6JPgLbeWiwLUslQUoZK9dJVT2WOxh BjiiTFnE56+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="267223019" X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="267223019" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 00:15:14 -0800 IronPort-SDR: FZHRZjqH+kTqIdMXXK2PFg7ilnH+URbu5ff2N6QHIBSgFsSFDHbgCoaDH1rkO+ypE/MVZz9EcL /kaI4IuOpLwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="511233670" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 12 Feb 2021 00:15:13 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 12 Feb 2021 00:15:13 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 12 Feb 2021 00:15:12 -0800 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2106.002; Fri, 12 Feb 2021 00:15:12 -0800 From: "Kasireddy, Vivek" To: Gerd Hoffmann CC: Daniel Vetter , "virtualization@lists.linux-foundation.org" , "dri-devel@lists.freedesktop.org" , "Vetter, Daniel" , "daniel.vetter@ffwll.ch" , "Kim, Dongwon" , "sumit.semwal@linaro.org" , "christian.koenig@amd.com" , "linux-media@vger.kernel.org" Subject: RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver Thread-Topic: [RFC v3 2/3] virtio: Introduce Vdmabuf driver Thread-Index: AQHW+gCTpvRVWdGfdEuO7KEMCe95EKpKQvKAgAQvVwCAABxAAIAAXFfggAEm5oCAAH4bcIABHRyAgAJ/T4A= Date: Fri, 12 Feb 2021 08:15:12 +0000 Message-ID: References: <20210203073517.1908882-1-vivek.kasireddy@intel.com> <20210203073517.1908882-3-vivek.kasireddy@intel.com> <20210208075748.xejgcb4il2egow2u@sirius.home.kraxel.org> <8ba4ad64be3546bda9a2ed2129bf98e4@intel.com> <20210209084453.5oqepy7zdwtxgrpu@sirius.home.kraxel.org> <2ef01dc941684a15a4f30e6239ae42df@intel.com> <20210210091641.ahjtgcdalw7viuei@sirius.home.kraxel.org> In-Reply-To: <20210210091641.ahjtgcdalw7viuei@sirius.home.kraxel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Gerd, > > > You don't have to use the rendering pipeline. You can let the i915 > > > gpu render into a dma-buf shared with virtio-gpu, then use > > > virtio-gpu only for buffer sharing with the host. [Kasireddy, Vivek] Just to confirm my understanding of what you are suggesting, are you saying that we need to either have Weston allocate scanout buffers (GBM surface/BO) using virtio-gpu and render into them using i915; or have virtio-gpu allocate pages and export a dma-buf and have Weston create a GBM BO by calling gbm_bo_import(fd) and render into the BO using i915? > Hmm, why a big mode switch? You should be able to do that without modifying the > virtio-gpu guest driver. On the host side qemu needs some work to support the most > recent virtio-gpu features like the buffer uuids (assuming you use qemu userspace), right > now those are only supported by crosvm. [Kasireddy, Vivek] We are only interested in Qemu UI at the moment but if we were to use virtio-gpu, we are going to need to add one more vq and support for managing buffers, events, etc. Thanks, Vivek > > It might be useful to add support for display-less virtio-gpu, i.e. > "qemu -device virtio-gpu-pci,max_outputs=0". Right now the linux driver throws an error > in case no output (crtc) is present. Should be fixable without too much effort though, > effectively the sanity check would have to be moved from driver initialization to > commands like SET_SCANOUT which manage the outputs. > > take care, > Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B40C433E0 for ; Fri, 12 Feb 2021 08:15:22 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7CCB64DF0 for ; Fri, 12 Feb 2021 08:15:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7CCB64DF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8F71E87588; Fri, 12 Feb 2021 08:15:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dzgx9uDa-6A7; Fri, 12 Feb 2021 08:15:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id C6FEF8755E; Fri, 12 Feb 2021 08:15:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A9EF8C0174; Fri, 12 Feb 2021 08:15:20 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 74275C013A for ; Fri, 12 Feb 2021 08:15:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6FC2986F90 for ; Fri, 12 Feb 2021 08:15:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dQauFmu9kX1a for ; Fri, 12 Feb 2021 08:15:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by whitealder.osuosl.org (Postfix) with ESMTPS id C414186D31 for ; Fri, 12 Feb 2021 08:15:17 +0000 (UTC) IronPort-SDR: cQQwL6BamuSoZVQ+oZKJyAI9yxujxl5NdkiQDIaEVIwASo+9FZ6nVpWT7GAv89aaKCLweGYl1O e0U3XZdcQXTA== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="182512123" X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="182512123" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 00:15:14 -0800 IronPort-SDR: FZHRZjqH+kTqIdMXXK2PFg7ilnH+URbu5ff2N6QHIBSgFsSFDHbgCoaDH1rkO+ypE/MVZz9EcL /kaI4IuOpLwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="511233670" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 12 Feb 2021 00:15:13 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 12 Feb 2021 00:15:13 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 12 Feb 2021 00:15:12 -0800 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2106.002; Fri, 12 Feb 2021 00:15:12 -0800 From: "Kasireddy, Vivek" To: Gerd Hoffmann Subject: RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver Thread-Topic: [RFC v3 2/3] virtio: Introduce Vdmabuf driver Thread-Index: AQHW+gCTpvRVWdGfdEuO7KEMCe95EKpKQvKAgAQvVwCAABxAAIAAXFfggAEm5oCAAH4bcIABHRyAgAJ/T4A= Date: Fri, 12 Feb 2021 08:15:12 +0000 Message-ID: References: <20210203073517.1908882-1-vivek.kasireddy@intel.com> <20210203073517.1908882-3-vivek.kasireddy@intel.com> <20210208075748.xejgcb4il2egow2u@sirius.home.kraxel.org> <8ba4ad64be3546bda9a2ed2129bf98e4@intel.com> <20210209084453.5oqepy7zdwtxgrpu@sirius.home.kraxel.org> <2ef01dc941684a15a4f30e6239ae42df@intel.com> <20210210091641.ahjtgcdalw7viuei@sirius.home.kraxel.org> In-Reply-To: <20210210091641.ahjtgcdalw7viuei@sirius.home.kraxel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.22.254.132] MIME-Version: 1.0 Cc: "Kim, Dongwon" , "christian.koenig@amd.com" , "daniel.vetter@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "virtualization@lists.linux-foundation.org" , Daniel Vetter , "Vetter, Daniel" , "sumit.semwal@linaro.org" , "linux-media@vger.kernel.org" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Hi Gerd, > > > You don't have to use the rendering pipeline. You can let the i915 > > > gpu render into a dma-buf shared with virtio-gpu, then use > > > virtio-gpu only for buffer sharing with the host. [Kasireddy, Vivek] Just to confirm my understanding of what you are suggesting, are you saying that we need to either have Weston allocate scanout buffers (GBM surface/BO) using virtio-gpu and render into them using i915; or have virtio-gpu allocate pages and export a dma-buf and have Weston create a GBM BO by calling gbm_bo_import(fd) and render into the BO using i915? > Hmm, why a big mode switch? You should be able to do that without modifying the > virtio-gpu guest driver. On the host side qemu needs some work to support the most > recent virtio-gpu features like the buffer uuids (assuming you use qemu userspace), right > now those are only supported by crosvm. [Kasireddy, Vivek] We are only interested in Qemu UI at the moment but if we were to use virtio-gpu, we are going to need to add one more vq and support for managing buffers, events, etc. Thanks, Vivek > > It might be useful to add support for display-less virtio-gpu, i.e. > "qemu -device virtio-gpu-pci,max_outputs=0". Right now the linux driver throws an error > in case no output (crtc) is present. Should be fixable without too much effort though, > effectively the sanity check would have to be moved from driver initialization to > commands like SET_SCANOUT which manage the outputs. > > take care, > Gerd _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311EEC433E0 for ; Fri, 12 Feb 2021 08:15:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA62764DF0 for ; Fri, 12 Feb 2021 08:15:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA62764DF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56A356E52F; Fri, 12 Feb 2021 08:15:17 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD9826E52F for ; Fri, 12 Feb 2021 08:15:15 +0000 (UTC) IronPort-SDR: 9D15rMUteMwSeWzclZv9ac4Oy8lQMRKoHKTsnqd8Pvtc4LHhl4JkZZnP4EpIDD1DElbqFcvEhO cULA/qCmnlhw== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="162137210" X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="162137210" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 00:15:14 -0800 IronPort-SDR: FZHRZjqH+kTqIdMXXK2PFg7ilnH+URbu5ff2N6QHIBSgFsSFDHbgCoaDH1rkO+ypE/MVZz9EcL /kaI4IuOpLwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="511233670" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 12 Feb 2021 00:15:13 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 12 Feb 2021 00:15:13 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 12 Feb 2021 00:15:12 -0800 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2106.002; Fri, 12 Feb 2021 00:15:12 -0800 From: "Kasireddy, Vivek" To: Gerd Hoffmann Subject: RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver Thread-Topic: [RFC v3 2/3] virtio: Introduce Vdmabuf driver Thread-Index: AQHW+gCTpvRVWdGfdEuO7KEMCe95EKpKQvKAgAQvVwCAABxAAIAAXFfggAEm5oCAAH4bcIABHRyAgAJ/T4A= Date: Fri, 12 Feb 2021 08:15:12 +0000 Message-ID: References: <20210203073517.1908882-1-vivek.kasireddy@intel.com> <20210203073517.1908882-3-vivek.kasireddy@intel.com> <20210208075748.xejgcb4il2egow2u@sirius.home.kraxel.org> <8ba4ad64be3546bda9a2ed2129bf98e4@intel.com> <20210209084453.5oqepy7zdwtxgrpu@sirius.home.kraxel.org> <2ef01dc941684a15a4f30e6239ae42df@intel.com> <20210210091641.ahjtgcdalw7viuei@sirius.home.kraxel.org> In-Reply-To: <20210210091641.ahjtgcdalw7viuei@sirius.home.kraxel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.22.254.132] MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Kim, Dongwon" , "christian.koenig@amd.com" , "daniel.vetter@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "virtualization@lists.linux-foundation.org" , "Vetter, Daniel" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Gerd, > > > You don't have to use the rendering pipeline. You can let the i915 > > > gpu render into a dma-buf shared with virtio-gpu, then use > > > virtio-gpu only for buffer sharing with the host. [Kasireddy, Vivek] Just to confirm my understanding of what you are suggesting, are you saying that we need to either have Weston allocate scanout buffers (GBM surface/BO) using virtio-gpu and render into them using i915; or have virtio-gpu allocate pages and export a dma-buf and have Weston create a GBM BO by calling gbm_bo_import(fd) and render into the BO using i915? > Hmm, why a big mode switch? You should be able to do that without modifying the > virtio-gpu guest driver. On the host side qemu needs some work to support the most > recent virtio-gpu features like the buffer uuids (assuming you use qemu userspace), right > now those are only supported by crosvm. [Kasireddy, Vivek] We are only interested in Qemu UI at the moment but if we were to use virtio-gpu, we are going to need to add one more vq and support for managing buffers, events, etc. Thanks, Vivek > > It might be useful to add support for display-less virtio-gpu, i.e. > "qemu -device virtio-gpu-pci,max_outputs=0". Right now the linux driver throws an error > in case no output (crtc) is present. Should be fixable without too much effort though, > effectively the sanity check would have to be moved from driver initialization to > commands like SET_SCANOUT which manage the outputs. > > take care, > Gerd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel