From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6EDC433E0 for ; Wed, 17 Feb 2021 16:15:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5A3864DA1 for ; Wed, 17 Feb 2021 16:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234178AbhBQQPa (ORCPT ); Wed, 17 Feb 2021 11:15:30 -0500 Received: from s-terra.s-terra.com ([193.164.201.59]:53415 "EHLO s-terra.s-terra.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234078AbhBQQPI (ORCPT ); Wed, 17 Feb 2021 11:15:08 -0500 X-Greylist: delayed 471 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 Feb 2021 11:15:08 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=s-terra.ru; s=mail; t=1613577993; bh=z1ZJy5btvrX6ccMWHhdu/ImCYptIQksKbzrdqLQRx64=; h=To:From:Subject:Date:From; b=l9AsYuhbo57ZKWxSoglLqZNcuz2iUv+2HSKCymDcMCzde/5l9/mt1kDDX2EjBp10u if4hX4hTK5F7+yQoxpIjTmJNM8TH1zHWPFoaSgS4ZZZ+YbyrIhMP3D/7I4CyBgZJvw cCP3GhP8j5gE0m9JdNqzUZyhX3QI+DDirCLvfCPk= To: From: =?UTF-8?B?0JzRg9GA0LDQstGM0LXQsiDQkNC70LXQutGB0LDQvdC00YA=?= Subject: null terminating of IFLA_INFO_KIND/IFLA_IFNAME Message-ID: Date: Wed, 17 Feb 2021 19:06:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: EMX.sterracsp.s-terra.com (fdff:1ea7:9484:0:b0e5:b137:3bee:6c45) To EMX.sterracsp.s-terra.com (fdff:1ea7:9484:0:b0e5:b137:3bee:6c45) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi A noob question that I haven't found an answer. Just wanted to clarify a piece of iproute2 code. ip/iplink.c: > 1058         addattr_l(&req.n, sizeof(req), IFLA_INFO_KIND, type, > 1059              strlen(type)); also ip/iplink.c: > 1115         addattr_l(&req.n, sizeof(req), > 1116               !check_ifname(name) ? IFLA_IFNAME : IFLA_ALT_IFNAME, > 1117               name, strlen(name) + 1); My question is why we skip terminating null character for IFLA_INFO_KIND (the first case) and don't skip it for IFLA_IFNAME (the second case)? I mean "strlen(type)" and "strlen(name) + 1". -- Best regards, Alexander Muravev