All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: MPTCP Upstream <mptcp@lists.linux.dev>
Subject: Re: [RFC PATCH 1/3] mptcp: never allow the PM to close a listener subflow
Date: Tue, 09 Nov 2021 15:38:58 +0100	[thread overview]
Message-ID: <baf882f708dc67063449424e2319a0c74a1b86b5.camel@redhat.com> (raw)
In-Reply-To: <340eb5be-4fa9-5cd3-1224-3e37e4d538ae@tessares.net>

On Mon, 2021-11-08 at 17:56 +0100, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 05/11/2021 11:49, Paolo Abeni wrote:
> > Currently, when deleting an endpoint the netlink PM treverses
> > all the local MPTCP sockets, regardless of their status.
> > 
> > If an MPTCP listener socket is bound to the IP matching the
> > delete endpoint, the listener TCP socket will be closed.
> > That is unexpected, the PM should only affect data subflows.
> > 
> > Fix the issue explicitly skipping MPTCP socket in TCP_LISTEN
> > status.
> 
> Good catch!
> 
> Should we add a "Fixes" tag and have this backported in stable versions?

We need this patch to be in the same series of the following two - or
at least to enter the tree before the others. I did not had the Fixes
tag to allow this patch to target the -net-next tree as the following
ones.

BTW I'm working to add self-tests here (mptcp_connect based [!!!]). It
looks like tha a good disconnect() implementation should use FASTCLOSE
to shutdown the MPTCP-level connection, so I'm going to add the tx part
of it, too.

Cheers,

Paolo


  reply	other threads:[~2021-11-09 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 10:49 [RFC PATCH 0/3] mptcp: improve accept() and disconnect() Paolo Abeni
2021-11-05 10:49 ` [RFC PATCH 1/3] mptcp: never allow the PM to close a listener subflow Paolo Abeni
2021-11-08 16:56   ` Matthieu Baerts
2021-11-09 14:38     ` Paolo Abeni [this message]
2021-11-09 14:55       ` Matthieu Baerts
2021-11-05 10:49 ` [RFC PATCH 2/3] mptcp: full disconnect implementation Paolo Abeni
2021-11-05 10:49 ` [RFC PATCH 3/3] mptcp: cleanup accept and poll Paolo Abeni
2021-11-05 10:59   ` mptcp: cleanup accept and poll: Build Failure MPTCP CI
2021-11-06  0:27 ` [RFC PATCH 0/3] mptcp: improve accept() and disconnect() Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=baf882f708dc67063449424e2319a0c74a1b86b5.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.