From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Jon Nettleton <jon@solid-run.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] software node: balance refcount for managed sw nodes
Date: Mon, 19 Jul 2021 15:00:17 +0300 [thread overview]
Message-ID: <bb009f85-687e-d560-9cc5-1ac4f586a6bd@nxp.com> (raw)
In-Reply-To: <CABdtJHuKyybhJazpAc8KT54ELtZ319rdb6CbSH6zB5x3NhgtAw@mail.gmail.com>
On 7/16/2021 8:21 PM, Jon Nettleton wrote:
> On Fri, Jul 16, 2021 at 2:17 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>>
>> On Fri, Jul 16, 2021 at 01:16:02PM +0300, laurentiu.tudor@nxp.com wrote:
>>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>>>
>>> software_node_notify(), on KOBJ_REMOVE drops the refcount twice on managed
>>> software nodes, thus leading to underflow errors. Balance the refcount by
>>> bumping it in the device_create_managed_software_node() function.
>>>
>>> The error [1] was encountered after adding a .shutdown() op to our
>>> fsl-mc-bus driver.
>>
>> Looking into the history of adding ->shutdown() to dwc3 driver (it got reverted
>> later on), I can tell that probably something is wrong in the ->shutdown()
>> method itself.
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
>>
>
> Isn't the other alternative to just remove the second kobject_put from
> KOBJ_REMOVE ?
>
Or maybe on top of Heikki's suggestion, replace the calls to
sysfs_create_link() from KOBJ_ADD with sysfs_create_link_nowarn()?
---
Best Regards, Laurentiu
next prev parent reply other threads:[~2021-07-19 12:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 10:16 [PATCH] software node: balance refcount for managed sw nodes laurentiu.tudor
2021-07-16 10:34 ` Laurentiu Tudor
2021-07-16 12:17 ` Andy Shevchenko
2021-07-16 17:21 ` Jon Nettleton
2021-07-19 12:00 ` Laurentiu Tudor [this message]
2021-07-19 12:22 ` Andy Shevchenko
2021-07-20 9:20 ` Laurentiu Tudor
2021-07-20 10:27 ` Andy Shevchenko
2021-07-26 7:59 ` Laurentiu Tudor
2021-09-07 15:59 ` Laurentiu Tudor
2021-09-09 12:13 ` Heikki Krogerus
2021-09-09 12:16 ` Heikki Krogerus
2021-09-09 14:01 ` Laurentiu Tudor
2021-09-10 12:05 ` Laurentiu Tudor
2021-09-10 12:38 ` Heikki Krogerus
2021-09-10 13:00 ` Laurentiu Tudor
2021-09-14 14:13 ` Heikki Krogerus
2021-09-14 14:00 ` Heikki Krogerus
2021-09-27 10:22 Laurentiu Tudor
2021-09-27 12:17 ` Greg KH
2021-09-27 12:42 ` Laurentiu Tudor
2021-09-27 13:34 ` Greg KH
2021-09-27 13:36 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb009f85-687e-d560-9cc5-1ac4f586a6bd@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.