From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929F5612F for ; Sat, 26 Nov 2022 22:56:46 +0000 (UTC) Received: from [192.168.1.139] ([37.4.248.27]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MCbZL-1p7cnv0cV9-009el7; Sat, 26 Nov 2022 23:56:36 +0100 Message-ID: Date: Sat, 26 Nov 2022 23:56:31 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support To: Umang Jain , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list Cc: Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham , Laurent Pinchart References: <20221121214722.22563-1-umang.jain@ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:mOh+jfsovNViNNFGnkXKYR6uFOi0sqfG0SFzTs1OIoe0785Y1c8 MscO7c9Q1LnicN1ocUBaPyw3swJ9vwTHF13uUdWGVDIRuZXt7ENejNpiqbi4wqzirD154eJ 2UNEb3o/CgOtr9nin5UnAXPx0JO5g3zeSP2SzG/odYL7ubwXPbRP7z9KgHS0SyYrHcRH+Yl sX33AMEeVluzOtY5kC0Tg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wa2tfLXpUeg=:KH3HVowP0x6IOJs0dfQ3Fd EAMKGhQXwBvLVWOXoRMnGLKpKiffQ/sydVQ55W6wiEo8i3PJ8qIwPXG9ikqp7xKVyZ3bZ3LQl Z7S3Lg7ljRyYABImyPTar+q/pgNtPdMdAoGbMIvh+kLvUcev96LFRe+XlSEXRpOL/w8vSW3c5 SF7wklR2L8RckQq1GBXZGDh6y5rxpFm4QPMoyFVDtWB1yy7WD1UXx/UsGD/t/jXUKVNdhSnaN Wr6H/pzFVgxVF9GE/mpBw7pqinWojF98pLXLOfZPmoKV8slzN2/L+jhujP/bOnBUNgZ2AzJQN ZMcsDwt/wKMmjumPAqHi3et6eN2kDLUeIx2lpfscXalYu16ADMjwiQlgogZE90Xs7WvbfKpDx yO5HywHqtXpAyFyMhxX68hKponPBkYDNhCLiFftaowlEzqLCA5eVqIIDe/qmXjolmwlwRsBAM M37cOGQOBQ+gQzixhhoAz8fqtj/FPknmukvkom162pgxoJ6lDtGnR6tM4ouqKODwa/U0zZpEP +yAFn/xTfRDINTJcbtOsHJAehhSIOasldotnfuCNGFjdutcG23AOkehuognrPRFKq3CU1+gTk r45YomqYkZIkYj1vyHENJlsJ7SnnF7M6xVOmo0sKy/7we5tpnFHNk7CmN0wYGTZeIl5vykxyQ SWM3z5OifaWCsaLDA+rdAhidJIgxEsQvz858ydVM2ydiQsfJUsrl+Q665i/P5SomlDPY1DiDF mSUQVdeT5pwdI3s2f2bL6LtHl+G56lpnfZWIW9d0jg7dkBfOmQX/3qTNpGYiwJLbarqL8+U8k i7UiyRUZWHdLzLycL6dzi8bUEOY4w== Hi Umang, Am 26.11.22 um 17:26 schrieb Umang Jain: > Hi Stefan > > On 11/26/22 8:12 PM, Stefan Wahren wrote: >> Hi Umang, >> >> Am 21.11.22 um 22:47 schrieb Umang Jain: >>> This series aims to upport bcm2835-isp from the RPi kernel [1] and is a >>> independent subset of earlier series [2] posted to upport CSI-2/CCP2 >>> receiver IP core("Unicam) + the ISP driver found in BCM283x and >>> compatible >>> SoCs (namely BCM2711). Unicam is still under active development to work >>> with multistream support to get into mainline. Hence only the ISP >>> driver >>> will remain the primary area of this series. >> >> thanks for working on this. But honestly i would prefer that vchiq >> comes out of staging before adding more features. As Greg said some >> time ago staging is not a place to "dump code and run away". These >> new files are in the same bad shape as the rest of vc04 before the >> clean-up here in staging started. > > Certainly, I am not here to do that - but I am still learning the ropes. no problem. > > If the staging issue is becoming a blocker for bcm2835-isp going > upstream, I would be happy to help here! Though I must mention that I > still have limited visibility so my aim would be to chart out a plan > of things needed to be done to get vc04_services out of staging! The vchiq driver is in staging since 2016, so every step forwards is good. Unfortunately all of the low hanging fruits has been gathered. For me the most important, but not to tricky steps to get vchiq out of staging would be: * Cleanup logging mechanism * Get rid of custom function return values There was already an attempt for this [1] * Get rid of all non essential global structures and create a proper per device structure > >> >> I agree that VCSM is on the TODO list for vchiq, but this driver is >> not necessary for making bcm2835-audio & bcm2835-camera leave >> staging. It just binds more resources on a new feature. > > I see two TODO files in vc04_services: >     ./bcm2835-camera/TODO >     ./interface/TODO > > One of the bcm2835-camera TODO points to the vc-sm-cma driver itself. > So that's address in the series. The other remaining one - I will need > to take a deeper look before commenting on it. > > The main chunk of TODO are in vc04_services/interfaces/TODO. Doing a > cursory reading of them suggests that these apply to *all* > vc04_services components? Am I right? Actually these applies just for the interfaces directory. Some of them could apply to the services, but this is no priority. > > Are these are the specific bits of cleanup you are referring to in > your comment? You mean about bcm2835-isp? There were too many changes to vchiq that i don't remember them all. The first that come to my mind was those fancy comment sections which is not kernel coding style. It has been removed. [1] - https://lore.kernel.org/linux-staging/20220712181928.17547-1-jslebodn@redhat.com/ > > >> >> Unfortuntately i hadn't much time to work on vchiq by myself. >> >> Just my two cents >> Stefan >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86E7EC43217 for ; Sat, 26 Nov 2022 22:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fAAjzgVFsqRNqepzuFja3Mfi62av1YUhL4Ye1cFOQXo=; b=PlQPd/O2f/YLai 37f2CRklcIcxPA/osD+bHGHH7vVhy7dMWQClTI1IIy0RQlgjuA6DPDQV66iYEgGuuhOwTCfA8V01U bAMPylAjfaDTT5r3kO86fSQ9C8Qf7GpVrqKcCPyEa+aSl3B4zITP+6zkba+0ShyRguSa4QDfPw8GK do3HXBEWxEEoyyyYpf2NuwaNRbq/XF4rfaFlq8woyJRAciUi1Fs+BY2zVLoyiknDGZwHy2sKPklgj Uj8k5ei9ZpPzidKRUlD3rKQyBNOmb/q8lNX0HAgDH6kvgArxxNPjH4Bs2J+XHR1Qs25JCf9uXp5LQ 2yqgVozQrpV1R20K0jag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oz46H-008XOH-Ic; Sat, 26 Nov 2022 22:56:45 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oz46E-008XLb-4N; Sat, 26 Nov 2022 22:56:44 +0000 Received: from [192.168.1.139] ([37.4.248.27]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MCbZL-1p7cnv0cV9-009el7; Sat, 26 Nov 2022 23:56:36 +0100 Message-ID: Date: Sat, 26 Nov 2022 23:56:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support To: Umang Jain , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list Cc: Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham , Laurent Pinchart References: <20221121214722.22563-1-umang.jain@ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:mOh+jfsovNViNNFGnkXKYR6uFOi0sqfG0SFzTs1OIoe0785Y1c8 MscO7c9Q1LnicN1ocUBaPyw3swJ9vwTHF13uUdWGVDIRuZXt7ENejNpiqbi4wqzirD154eJ 2UNEb3o/CgOtr9nin5UnAXPx0JO5g3zeSP2SzG/odYL7ubwXPbRP7z9KgHS0SyYrHcRH+Yl sX33AMEeVluzOtY5kC0Tg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wa2tfLXpUeg=:KH3HVowP0x6IOJs0dfQ3Fd EAMKGhQXwBvLVWOXoRMnGLKpKiffQ/sydVQ55W6wiEo8i3PJ8qIwPXG9ikqp7xKVyZ3bZ3LQl Z7S3Lg7ljRyYABImyPTar+q/pgNtPdMdAoGbMIvh+kLvUcev96LFRe+XlSEXRpOL/w8vSW3c5 SF7wklR2L8RckQq1GBXZGDh6y5rxpFm4QPMoyFVDtWB1yy7WD1UXx/UsGD/t/jXUKVNdhSnaN Wr6H/pzFVgxVF9GE/mpBw7pqinWojF98pLXLOfZPmoKV8slzN2/L+jhujP/bOnBUNgZ2AzJQN ZMcsDwt/wKMmjumPAqHi3et6eN2kDLUeIx2lpfscXalYu16ADMjwiQlgogZE90Xs7WvbfKpDx yO5HywHqtXpAyFyMhxX68hKponPBkYDNhCLiFftaowlEzqLCA5eVqIIDe/qmXjolmwlwRsBAM M37cOGQOBQ+gQzixhhoAz8fqtj/FPknmukvkom162pgxoJ6lDtGnR6tM4ouqKODwa/U0zZpEP +yAFn/xTfRDINTJcbtOsHJAehhSIOasldotnfuCNGFjdutcG23AOkehuognrPRFKq3CU1+gTk r45YomqYkZIkYj1vyHENJlsJ7SnnF7M6xVOmo0sKy/7we5tpnFHNk7CmN0wYGTZeIl5vykxyQ SWM3z5OifaWCsaLDA+rdAhidJIgxEsQvz858ydVM2ydiQsfJUsrl+Q665i/P5SomlDPY1DiDF mSUQVdeT5pwdI3s2f2bL6LtHl+G56lpnfZWIW9d0jg7dkBfOmQX/3qTNpGYiwJLbarqL8+U8k i7UiyRUZWHdLzLycL6dzi8bUEOY4w== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221126_145642_494811_E432D719 X-CRM114-Status: GOOD ( 29.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVW1hbmcsCgpBbSAyNi4xMS4yMiB1bSAxNzoyNiBzY2hyaWViIFVtYW5nIEphaW46Cj4gSGkg U3RlZmFuCj4KPiBPbiAxMS8yNi8yMiA4OjEyIFBNLCBTdGVmYW4gV2FocmVuIHdyb3RlOgo+PiBI aSBVbWFuZywKPj4KPj4gQW0gMjEuMTEuMjIgdW0gMjI6NDcgc2NocmllYiBVbWFuZyBKYWluOgo+ Pj4gVGhpcyBzZXJpZXMgYWltcyB0byB1cHBvcnQgYmNtMjgzNS1pc3AgZnJvbSB0aGUgUlBpIGtl cm5lbCBbMV0gYW5kIGlzIGEKPj4+IGluZGVwZW5kZW50IHN1YnNldCBvZiBlYXJsaWVyIHNlcmll cyBbMl0gcG9zdGVkIHRvIHVwcG9ydCBDU0ktMi9DQ1AyCj4+PiByZWNlaXZlciBJUCBjb3JlKCJV bmljYW0pICsgdGhlIElTUCBkcml2ZXIgZm91bmQgaW4gQkNNMjgzeCBhbmQgCj4+PiBjb21wYXRp YmxlCj4+PiBTb0NzIChuYW1lbHkgQkNNMjcxMSkuIFVuaWNhbSBpcyBzdGlsbCB1bmRlciBhY3Rp dmUgZGV2ZWxvcG1lbnQgdG8gd29yawo+Pj4gd2l0aCBtdWx0aXN0cmVhbSBzdXBwb3J0IHRvIGdl dCBpbnRvIG1haW5saW5lLiBIZW5jZSBvbmx5IHRoZSBJU1AgCj4+PiBkcml2ZXIKPj4+IHdpbGwg cmVtYWluIHRoZSBwcmltYXJ5IGFyZWEgb2YgdGhpcyBzZXJpZXMuCj4+Cj4+IHRoYW5rcyBmb3Ig d29ya2luZyBvbiB0aGlzLiBCdXQgaG9uZXN0bHkgaSB3b3VsZCBwcmVmZXIgdGhhdCB2Y2hpcSAK Pj4gY29tZXMgb3V0IG9mIHN0YWdpbmcgYmVmb3JlIGFkZGluZyBtb3JlIGZlYXR1cmVzLiBBcyBH cmVnIHNhaWQgc29tZSAKPj4gdGltZSBhZ28gc3RhZ2luZyBpcyBub3QgYSBwbGFjZSB0byAiZHVt cCBjb2RlIGFuZCBydW4gYXdheSIuIFRoZXNlIAo+PiBuZXcgZmlsZXMgYXJlIGluIHRoZSBzYW1l IGJhZCBzaGFwZSBhcyB0aGUgcmVzdCBvZiB2YzA0IGJlZm9yZSB0aGUgCj4+IGNsZWFuLXVwIGhl cmUgaW4gc3RhZ2luZyBzdGFydGVkLgo+Cj4gQ2VydGFpbmx5LCBJIGFtIG5vdCBoZXJlIHRvIGRv IHRoYXQgLSBidXQgSSBhbSBzdGlsbCBsZWFybmluZyB0aGUgcm9wZXMuCm5vIHByb2JsZW0uCj4K PiBJZiB0aGUgc3RhZ2luZyBpc3N1ZSBpcyBiZWNvbWluZyBhIGJsb2NrZXIgZm9yIGJjbTI4MzUt aXNwIGdvaW5nIAo+IHVwc3RyZWFtLCBJIHdvdWxkIGJlIGhhcHB5IHRvIGhlbHAgaGVyZSEgVGhv dWdoIEkgbXVzdCBtZW50aW9uIHRoYXQgSSAKPiBzdGlsbCBoYXZlIGxpbWl0ZWQgdmlzaWJpbGl0 eSBzbyBteSBhaW0gd291bGQgYmUgdG8gY2hhcnQgb3V0IGEgcGxhbiAKPiBvZiB0aGluZ3MgbmVl ZGVkIHRvIGJlIGRvbmUgdG8gZ2V0IHZjMDRfc2VydmljZXMgb3V0IG9mIHN0YWdpbmchCgpUaGUg dmNoaXEgZHJpdmVyIGlzIGluIHN0YWdpbmcgc2luY2UgMjAxNiwgc28gZXZlcnkgc3RlcCBmb3J3 YXJkcyBpcyAKZ29vZC4gVW5mb3J0dW5hdGVseSBhbGwgb2YgdGhlIGxvdyBoYW5naW5nIGZydWl0 cyBoYXMgYmVlbiBnYXRoZXJlZC4KCkZvciBtZSB0aGUgbW9zdCBpbXBvcnRhbnQsIGJ1dCBub3Qg dG8gdHJpY2t5IHN0ZXBzIHRvIGdldCB2Y2hpcSBvdXQgb2YgCnN0YWdpbmcgd291bGQgYmU6Cgoq IENsZWFudXAgbG9nZ2luZyBtZWNoYW5pc20KCiogR2V0IHJpZCBvZiBjdXN0b20gZnVuY3Rpb24g cmV0dXJuIHZhbHVlcwoKVGhlcmUgd2FzIGFscmVhZHkgYW4gYXR0ZW1wdCBmb3IgdGhpcyBbMV0K CiogR2V0IHJpZCBvZiBhbGwgbm9uIGVzc2VudGlhbCBnbG9iYWwgc3RydWN0dXJlcyBhbmQgY3Jl YXRlIGEgcHJvcGVyIHBlcgpkZXZpY2Ugc3RydWN0dXJlCgo+Cj4+Cj4+IEkgYWdyZWUgdGhhdCBW Q1NNIGlzIG9uIHRoZSBUT0RPIGxpc3QgZm9yIHZjaGlxLCBidXQgdGhpcyBkcml2ZXIgaXMgCj4+ IG5vdCBuZWNlc3NhcnkgZm9yIG1ha2luZyBiY20yODM1LWF1ZGlvICYgYmNtMjgzNS1jYW1lcmEg bGVhdmUgCj4+IHN0YWdpbmcuIEl0IGp1c3QgYmluZHMgbW9yZSByZXNvdXJjZXMgb24gYSBuZXcg ZmVhdHVyZS4KPgo+IEkgc2VlIHR3byBUT0RPIGZpbGVzIGluIHZjMDRfc2VydmljZXM6Cj4gwqDC oMKgIC4vYmNtMjgzNS1jYW1lcmEvVE9ETwo+IMKgwqDCoCAuL2ludGVyZmFjZS9UT0RPCj4KPiBP bmUgb2YgdGhlIGJjbTI4MzUtY2FtZXJhIFRPRE8gcG9pbnRzIHRvIHRoZSB2Yy1zbS1jbWEgZHJp dmVyIGl0c2VsZi4gCj4gU28gdGhhdCdzIGFkZHJlc3MgaW4gdGhlIHNlcmllcy4gVGhlIG90aGVy IHJlbWFpbmluZyBvbmUgLSBJIHdpbGwgbmVlZCAKPiB0byB0YWtlIGEgZGVlcGVyIGxvb2sgYmVm b3JlIGNvbW1lbnRpbmcgb24gaXQuCj4KPiBUaGUgbWFpbiBjaHVuayBvZiBUT0RPIGFyZSBpbiB2 YzA0X3NlcnZpY2VzL2ludGVyZmFjZXMvVE9ETy4gRG9pbmcgYSAKPiBjdXJzb3J5IHJlYWRpbmcg b2YgdGhlbSBzdWdnZXN0cyB0aGF0IHRoZXNlIGFwcGx5IHRvICphbGwqIAo+IHZjMDRfc2Vydmlj ZXMgY29tcG9uZW50cz8gQW0gSSByaWdodD8KQWN0dWFsbHkgdGhlc2UgYXBwbGllcyBqdXN0IGZv ciB0aGUgaW50ZXJmYWNlcyBkaXJlY3RvcnkuIFNvbWUgb2YgdGhlbSAKY291bGQgYXBwbHkgdG8g dGhlIHNlcnZpY2VzLCBidXQgdGhpcyBpcyBubyBwcmlvcml0eS4KPgo+IEFyZSB0aGVzZSBhcmUg dGhlIHNwZWNpZmljIGJpdHMgb2YgY2xlYW51cCB5b3UgYXJlIHJlZmVycmluZyB0byBpbiAKPiB5 b3VyIGNvbW1lbnQ/CgpZb3UgbWVhbiBhYm91dCBiY20yODM1LWlzcD8gVGhlcmUgd2VyZSB0b28g bWFueSBjaGFuZ2VzIHRvIHZjaGlxIHRoYXQgaSAKZG9uJ3QgcmVtZW1iZXIgdGhlbSBhbGwuIFRo ZSBmaXJzdCB0aGF0IGNvbWUgdG8gbXkgbWluZCB3YXMgdGhvc2UgZmFuY3kgCmNvbW1lbnQgc2Vj dGlvbnMgd2hpY2ggaXMgbm90IGtlcm5lbCBjb2Rpbmcgc3R5bGUuIEl0IGhhcyBiZWVuIHJlbW92 ZWQuCgpbMV0gLSAKaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtc3RhZ2luZy8yMDIyMDcx MjE4MTkyOC4xNzU0Ny0xLWpzbGVib2RuQHJlZGhhdC5jb20vCgo+Cj4KPj4KPj4gVW5mb3J0dW50 YXRlbHkgaSBoYWRuJ3QgbXVjaCB0aW1lIHRvIHdvcmsgb24gdmNoaXEgYnkgbXlzZWxmLgo+Pgo+ PiBKdXN0IG15IHR3byBjZW50cwo+PiBTdGVmYW4KPj4KPgo+Cj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdAo+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=