All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@nokia.com>
To: "mingo@kernel.org" <mingo@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"acme@kernel.org" <acme@kernel.org>
Cc: "williams@redhat.com" <williams@redhat.com>,
	"acme@redhat.com" <acme@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"dave@stgolabs.net" <dave@stgolabs.net>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 4/5] perf bench: Share some global variables to fix build with gcc 10
Date: Thu, 5 Mar 2020 08:43:32 +0000	[thread overview]
Message-ID: <bb1a3048a0f75d1fdf497c67d16a022cdd15c437.camel@nokia.com> (raw)
In-Reply-To: <20200303194827.6461-5-acme@kernel.org>

On Tue, 2020-03-03 at 16:48 -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>

BTW there's also some div-by-zero bugs here if runtime is zero:

$ perf bench epoll wait --runtime=0
# Running 'epoll/wait' benchmark:
Run summary [PID 30859]: 7 threads monitoring on 64 file-descriptors for 0
secs.

Floating point exception (core dumped)

> diff --git a/tools/perf/bench/epoll-wait.c b/tools/perf/bench/epoll-
> wait.c
> index 7af694437f4e..d1c5cb526b9f 100644
> --- a/tools/perf/bench/epoll-wait.c
> +++ b/tools/perf/bench/epoll-wait.c
> 
> @@ -519,7 +518,7 @@ int bench_epoll_wait(int argc, const char **argv)
>  		qsort(worker, nthreads, sizeof(struct worker), cmpworker);
>  
>  	for (i = 0; i < nthreads; i++) {
> -		unsigned long t = worker[i].ops/runtime.tv_sec;
> +		unsigned long t = worker[i].ops / bench__runtime.tv_sec;
>  
>  		update_stats(&throughput_stats, t);
>  
> diff --git a/tools/perf/bench/futex-hash.c b/tools/perf/bench/futex-
> hash.c
> index 8ba0c3330a9a..21776862e940 100644
> --- a/tools/perf/bench/futex-hash.c
> +++ b/tools/perf/bench/futex-hash.c
> 
> @@ -204,7 +204,7 @@ int bench_futex_hash(int argc, const char **argv)
>  	pthread_mutex_destroy(&thread_lock);
>  
>  	for (i = 0; i < nthreads; i++) {
> -		unsigned long t = worker[i].ops/runtime.tv_sec;
> +		unsigned long t = worker[i].ops / bench__runtime.tv_sec;
>  		update_stats(&throughput_stats, t);
>  		if (!silent) {
>  			if (nfutexes == 1)
> diff --git a/tools/perf/bench/futex-lock-pi.c b/tools/perf/bench/futex-
> lock-pi.c
> index d0cae8125423..30d97121dc4f 100644
> --- a/tools/perf/bench/futex-lock-pi.c
> +++ b/tools/perf/bench/futex-lock-pi.c
> 
> @@ -211,7 +210,7 @@ int bench_futex_lock_pi(int argc, const char **argv)
>  	pthread_mutex_destroy(&thread_lock);
>  
>  	for (i = 0; i < nthreads; i++) {
> -		unsigned long t = worker[i].ops/runtime.tv_sec;
> +		unsigned long t = worker[i].ops / bench__runtime.tv_sec;
>  
>  		update_stats(&throughput_stats, t);
>  		if (!silent)


  reply	other threads:[~2020-03-05  8:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 19:48 [GIT PULL] perf/urgent fixes Arnaldo Carvalho de Melo
2020-03-03 19:48 ` [PATCH 1/5] perf tests bp_account: Make global variable static Arnaldo Carvalho de Melo
2020-03-03 19:48 ` [PATCH 2/5] perf env: Do not return pointers to local variables Arnaldo Carvalho de Melo
2020-03-03 19:48 ` [PATCH 3/5] perf parse-events: Use asprintf() instead of strncpy() to read tracepoint files Arnaldo Carvalho de Melo
2020-03-03 19:48 ` [PATCH 4/5] perf bench: Share some global variables to fix build with gcc 10 Arnaldo Carvalho de Melo
2020-03-05  8:43   ` Rantala, Tommi T. (Nokia - FI/Espoo) [this message]
2020-03-05 15:16     ` Arnaldo Carvalho de MElo
2020-03-03 19:48 ` [PATCH 5/5] perf symbols: Don't try to find a vmlinux file when looking for kernel modules Arnaldo Carvalho de Melo
2020-03-04 10:54 ` [GIT PULL] perf/urgent fixes Ingo Molnar
2020-03-06 19:11 Arnaldo Carvalho de Melo
2020-03-06 19:11 ` [PATCH 4/5] perf bench: Share some global variables to fix build with gcc 10 Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb1a3048a0f75d1fdf497c67d16a022cdd15c437.camel@nokia.com \
    --to=tommi.t.rantala@nokia.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dave@stgolabs.net \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.