From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22E4C433F5 for ; Mon, 23 May 2022 02:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234358AbiEWC6v (ORCPT ); Sun, 22 May 2022 22:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234201AbiEWC6r (ORCPT ); Sun, 22 May 2022 22:58:47 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4972913FA0; Sun, 22 May 2022 19:58:46 -0700 (PDT) X-UUID: c07f7d17411b4733afe8c214dde10fd9-20220523 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:afcd5b5c-626a-4d66-8561-3fc91e978add,OB:0,LO B:20,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:51,FILE:0,RULE:Release_Ham,AC TION:release,TS:56 X-CID-INFO: VERSION:1.1.5,REQID:afcd5b5c-626a-4d66-8561-3fc91e978add,OB:0,LOB: 20,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:51,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:56 X-CID-META: VersionHash:2a19b09,CLOUDID:9411377a-5ef6-470b-96c9-bdb8ced32786,C OID:6b3065758ceb,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,QS:0,BEC:nil X-UUID: c07f7d17411b4733afe8c214dde10fd9-20220523 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 708898458; Mon, 23 May 2022 10:58:39 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 23 May 2022 10:58:38 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 23 May 2022 10:58:25 +0800 Message-ID: Subject: Re: [PATCH v9 1/2] dt-bindings: phy: mediatek: Add YAML schema for PCIe PHY From: Jianjun Wang To: Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Matthias Brugger , "Chen-Yu Tsai" , AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: Wei-Shun Chang , , , , , , , , , , , Date: Mon, 23 May 2022 10:58:23 +0800 In-Reply-To: <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> References: <20220520064920.27313-1-jianjun.wang@mediatek.com> <20220520064920.27313-2-jianjun.wang@mediatek.com> <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chunfeng, On Mon, 2022-05-23 at 10:23 +0800, Chunfeng Yun wrote: > On Fri, 2022-05-20 at 14:49 +0800, Jianjun Wang wrote: > > Add YAML schema documentation for PCIe PHY on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/phy/mediatek,pcie-phy.yaml | 75 > > +++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml > > ...snip... > > + > > + "#phy-cells": > > + const: 0 > > + > > + nvmem-cells: > > + maxItems: 7 > > Seems no need 'maxItems', we can get it from items of 'nvmem-cell- > names' Please see the comment by Krzysztof[1], I guess we need to add this 'maxTems'. [1]: https://lore.kernel.org/lkml/d48c0023-231c-4011-5548-4b260b3fe172@kernel.org/ Thanks. > > > + description: > > + Phandles to nvmem cell that contains the efuse data, if > > unspecified, > > + default value is used. > > + > > + nvmem-cell-names: > > + items: > > + - const: glb_intr > > + - const: tx_ln0_pmos > > + - const: tx_ln0_nmos > > + - const: rx_ln0 > > + - const: tx_ln1_pmos > > + - const: tx_ln1_nmos > > + - const: rx_ln1 > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - "#phy-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + phy@11e80000 { > > + compatible = "mediatek,mt8195-pcie-phy"; > > + #phy-cells = <0>; > > + reg = <0x11e80000 0x10000>; > > + reg-names = "sif"; > > + nvmem-cells = <&pciephy_glb_intr>, > > + <&pciephy_tx_ln0_pmos>, > > + <&pciephy_tx_ln0_nmos>, > > + <&pciephy_rx_ln0>, > > + <&pciephy_tx_ln1_pmos>, > > + <&pciephy_tx_ln1_nmos>, > > + <&pciephy_rx_ln1>; > > + nvmem-cell-names = "glb_intr", "tx_ln0_pmos", > > + "tx_ln0_nmos", "rx_ln0", > > + "tx_ln1_pmos", "tx_ln1_nmos", > > + "rx_ln1"; > > + power-domains = <&spm 2>; > > + }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B711C433F5 for ; Mon, 23 May 2022 08:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ykkG0mlror/7Lzicq1fuo2Kf2jm6yC1syO9cbZpLjo=; b=ztkmhQ3mg8ltkX nmjfmp+6uzO9Y0PLFml57rCQc6Yisf1vhZQfh/+5gOyvgz9lZQYSo5U/+8WSk7QXzY1bdpVRAqjl7 tc/W04ffZR6LYTPh5gzaoBurfB8uskGt9MwtPmRuFxnzmymAPJu1jvkl+KoNSSROVv07wkOksx5VX InnaPleyED/eL1C9zvE0heJRb3KtPWNMfw99Ba3XPR+Wlw/+tO2gLrUxvS1fQmcqfdBH6WxZ40hRw F2D+azPfKaYC/H/HeekNKPn/bTTv9jngt9UkKYvo4TKLKnkQyV9Bn7JgbDLkhEf5XzMcGZAf9vZ1G XEFTRGJJY0119SaL4kYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt3Cg-002LVY-Rf; Mon, 23 May 2022 08:14:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt2s9-002CKb-CE; Mon, 23 May 2022 07:53:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=AdnHLVM+oerhxjlqmH3teKIttInw376KeUGWWv3wZOA=; b=TAFTq4It7jrRwjyjVMdHTTigkt meY3Bm9m5k+mRAxPyrfnsmUuPP6y/vZQB9N9rlvfgkFkXPr2pWXsoZ9ogtyL0Y/rEdSqc/qT+zohA JkBQMrYLpxLTShudiLuyECyfZPN5JjAlG8cpxyXLN7xg/VD0QPgQBkilwEKCkVABHRJbvEdUHwosc tfhoaQQzFQn206HiSuD2Lj62KZ9Ylt3MIoy5QepGCSBNVgYys+qt15PlXVEgvN/f5UIPfxkDFoPvo Jbzo1zjPKGqbu5jS7qKL2YyLixnbasabTB2e8U9h0ONZmn9PcwVYITX/L6GqxTpwdws6fESz+oI9i zbenIwAQ==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsyHn-000mb7-7H; Mon, 23 May 2022 02:59:15 +0000 X-UUID: 98e95165112e41d281a987073929444a-20220522 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=AdnHLVM+oerhxjlqmH3teKIttInw376KeUGWWv3wZOA=; b=bL/3EHL0M37VixW0KUD8OZJ0I/rtmvr4ghrOyNyH1RClhZnAOqEPiv0sgiFw4zfJ6ANCeEizf4cEVrKblfsr5EJDNeETTG867BoSBcBrst01S2abmqw+I8XoUPlysdGJiGxGqMLO5t8ftWnhHI1xPmK8RCmFawNqH16f0WoZ4Hg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:f29c0bff-31d8-4404-bb8f-fda7dadee5c2, OB:0, LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:2a19b09, CLOUDID:c411377a-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:0,BEC:nil X-UUID: 98e95165112e41d281a987073929444a-20220522 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 953365610; Sun, 22 May 2022 19:58:41 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 22 May 2022 19:58:40 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 23 May 2022 10:58:38 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 23 May 2022 10:58:25 +0800 Message-ID: Subject: Re: [PATCH v9 1/2] dt-bindings: phy: mediatek: Add YAML schema for PCIe PHY From: Jianjun Wang To: Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Matthias Brugger , "Chen-Yu Tsai" , AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: Wei-Shun Chang , , , , , , , , , , , Date: Mon, 23 May 2022 10:58:23 +0800 In-Reply-To: <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> References: <20220520064920.27313-1-jianjun.wang@mediatek.com> <20220520064920.27313-2-jianjun.wang@mediatek.com> <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_035912_472607_4B955DDE X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Chunfeng, On Mon, 2022-05-23 at 10:23 +0800, Chunfeng Yun wrote: > On Fri, 2022-05-20 at 14:49 +0800, Jianjun Wang wrote: > > Add YAML schema documentation for PCIe PHY on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/phy/mediatek,pcie-phy.yaml | 75 > > +++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml > > ...snip... > > + > > + "#phy-cells": > > + const: 0 > > + > > + nvmem-cells: > > + maxItems: 7 > > Seems no need 'maxItems', we can get it from items of 'nvmem-cell- > names' Please see the comment by Krzysztof[1], I guess we need to add this 'maxTems'. [1]: https://lore.kernel.org/lkml/d48c0023-231c-4011-5548-4b260b3fe172@kernel.org/ Thanks. > > > + description: > > + Phandles to nvmem cell that contains the efuse data, if > > unspecified, > > + default value is used. > > + > > + nvmem-cell-names: > > + items: > > + - const: glb_intr > > + - const: tx_ln0_pmos > > + - const: tx_ln0_nmos > > + - const: rx_ln0 > > + - const: tx_ln1_pmos > > + - const: tx_ln1_nmos > > + - const: rx_ln1 > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - "#phy-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + phy@11e80000 { > > + compatible = "mediatek,mt8195-pcie-phy"; > > + #phy-cells = <0>; > > + reg = <0x11e80000 0x10000>; > > + reg-names = "sif"; > > + nvmem-cells = <&pciephy_glb_intr>, > > + <&pciephy_tx_ln0_pmos>, > > + <&pciephy_tx_ln0_nmos>, > > + <&pciephy_rx_ln0>, > > + <&pciephy_tx_ln1_pmos>, > > + <&pciephy_tx_ln1_nmos>, > > + <&pciephy_rx_ln1>; > > + nvmem-cell-names = "glb_intr", "tx_ln0_pmos", > > + "tx_ln0_nmos", "rx_ln0", > > + "tx_ln1_pmos", "tx_ln1_nmos", > > + "rx_ln1"; > > + power-domains = <&spm 2>; > > + }; > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20A3EC433FE for ; Mon, 23 May 2022 08:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bbn2q2k0w5aFtC5flLWHnvswbxk+KMnEen02fNGowBA=; b=aF+vlDi3REhdcU kdFBC1LorlZZ1+ZvNYWh4zUJgJ93jNz+olOEcX1EKubpj62KkPA1uO3CiVu5Qglcg26mUADJkclZe eQKTKNK8YoxK6T2YbfaFCIteUArgWdqE9g3U1D/mEGka40xtX7vDjuYvvFGnCTr6xGJTXt7J64Xs3 ax0lwpJzXxT/OC5gCeknt28L8xqbid4dd5oUgfkbMPEwB8DLtLuPls/FV2OIOvquDh0H0QeKelfCb RWb9/5YLDZfBlHwCol1HV3HpwJrkFxa0l9o4bG6YT4wC0H5miAl+ULnyT69Oc53fS8Gvqlg5EmnRc wz5PfnWY6H+3DNDUaVPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt3Cl-002LXF-91; Mon, 23 May 2022 08:14:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt2s9-002CKb-CE; Mon, 23 May 2022 07:53:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=AdnHLVM+oerhxjlqmH3teKIttInw376KeUGWWv3wZOA=; b=TAFTq4It7jrRwjyjVMdHTTigkt meY3Bm9m5k+mRAxPyrfnsmUuPP6y/vZQB9N9rlvfgkFkXPr2pWXsoZ9ogtyL0Y/rEdSqc/qT+zohA JkBQMrYLpxLTShudiLuyECyfZPN5JjAlG8cpxyXLN7xg/VD0QPgQBkilwEKCkVABHRJbvEdUHwosc tfhoaQQzFQn206HiSuD2Lj62KZ9Ylt3MIoy5QepGCSBNVgYys+qt15PlXVEgvN/f5UIPfxkDFoPvo Jbzo1zjPKGqbu5jS7qKL2YyLixnbasabTB2e8U9h0ONZmn9PcwVYITX/L6GqxTpwdws6fESz+oI9i zbenIwAQ==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsyHn-000mb7-7H; Mon, 23 May 2022 02:59:15 +0000 X-UUID: 98e95165112e41d281a987073929444a-20220522 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=AdnHLVM+oerhxjlqmH3teKIttInw376KeUGWWv3wZOA=; b=bL/3EHL0M37VixW0KUD8OZJ0I/rtmvr4ghrOyNyH1RClhZnAOqEPiv0sgiFw4zfJ6ANCeEizf4cEVrKblfsr5EJDNeETTG867BoSBcBrst01S2abmqw+I8XoUPlysdGJiGxGqMLO5t8ftWnhHI1xPmK8RCmFawNqH16f0WoZ4Hg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:f29c0bff-31d8-4404-bb8f-fda7dadee5c2, OB:0, LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:2a19b09, CLOUDID:c411377a-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:0,BEC:nil X-UUID: 98e95165112e41d281a987073929444a-20220522 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 953365610; Sun, 22 May 2022 19:58:41 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 22 May 2022 19:58:40 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 23 May 2022 10:58:38 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 23 May 2022 10:58:25 +0800 Message-ID: Subject: Re: [PATCH v9 1/2] dt-bindings: phy: mediatek: Add YAML schema for PCIe PHY From: Jianjun Wang To: Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Matthias Brugger , "Chen-Yu Tsai" , AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: Wei-Shun Chang , , , , , , , , , , , Date: Mon, 23 May 2022 10:58:23 +0800 In-Reply-To: <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> References: <20220520064920.27313-1-jianjun.wang@mediatek.com> <20220520064920.27313-2-jianjun.wang@mediatek.com> <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_035912_472607_4B955DDE X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Chunfeng, On Mon, 2022-05-23 at 10:23 +0800, Chunfeng Yun wrote: > On Fri, 2022-05-20 at 14:49 +0800, Jianjun Wang wrote: > > Add YAML schema documentation for PCIe PHY on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/phy/mediatek,pcie-phy.yaml | 75 > > +++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml > > ...snip... > > + > > + "#phy-cells": > > + const: 0 > > + > > + nvmem-cells: > > + maxItems: 7 > > Seems no need 'maxItems', we can get it from items of 'nvmem-cell- > names' Please see the comment by Krzysztof[1], I guess we need to add this 'maxTems'. [1]: https://lore.kernel.org/lkml/d48c0023-231c-4011-5548-4b260b3fe172@kernel.org/ Thanks. > > > + description: > > + Phandles to nvmem cell that contains the efuse data, if > > unspecified, > > + default value is used. > > + > > + nvmem-cell-names: > > + items: > > + - const: glb_intr > > + - const: tx_ln0_pmos > > + - const: tx_ln0_nmos > > + - const: rx_ln0 > > + - const: tx_ln1_pmos > > + - const: tx_ln1_nmos > > + - const: rx_ln1 > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - "#phy-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + phy@11e80000 { > > + compatible = "mediatek,mt8195-pcie-phy"; > > + #phy-cells = <0>; > > + reg = <0x11e80000 0x10000>; > > + reg-names = "sif"; > > + nvmem-cells = <&pciephy_glb_intr>, > > + <&pciephy_tx_ln0_pmos>, > > + <&pciephy_tx_ln0_nmos>, > > + <&pciephy_rx_ln0>, > > + <&pciephy_tx_ln1_pmos>, > > + <&pciephy_tx_ln1_nmos>, > > + <&pciephy_rx_ln1>; > > + nvmem-cell-names = "glb_intr", "tx_ln0_pmos", > > + "tx_ln0_nmos", "rx_ln0", > > + "tx_ln1_pmos", "tx_ln1_nmos", > > + "rx_ln1"; > > + power-domains = <&spm 2>; > > + }; > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2EE8C433EF for ; Mon, 23 May 2022 08:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TSPnFYyM1Pp7dMY0tVeE17/6BMevkjdS5k5YATVCWa0=; b=XhhoHvtWNXv3kQ o0RLlYdq0Mdhx9IDbJIa+OYbq9PRZaABxAO0LAXbzrReeOwi5fThtJMyocpPWhHr8Q0lRr5y0R0zB w2A19L5Ty1lmWrOmTYr3c2BMPGxU+7TL/fUdXGuSH6MeT7rFW0STRnKlnWSSX2EQK3fu+SJ/fDhZ2 bRAJ041gFR4LmXo8si3CQPXMdf4T4mzorVuKCbKQ/khyVryZrJr9Ac8BEJFMneBMk74HjZXTlhaoj 7j0pwUKcN77GlVMtDjrbcvFH4Sgq8xIqi7JLOOPrnWF/XfzzjFsfaeZjPlk01Z4bqHVc6zBvP2EsR 7sJP+3K3BIJxx0h7dsug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt3Co-002LXO-9Y; Mon, 23 May 2022 08:14:22 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt2s9-002CKb-CE; Mon, 23 May 2022 07:53:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=AdnHLVM+oerhxjlqmH3teKIttInw376KeUGWWv3wZOA=; b=TAFTq4It7jrRwjyjVMdHTTigkt meY3Bm9m5k+mRAxPyrfnsmUuPP6y/vZQB9N9rlvfgkFkXPr2pWXsoZ9ogtyL0Y/rEdSqc/qT+zohA JkBQMrYLpxLTShudiLuyECyfZPN5JjAlG8cpxyXLN7xg/VD0QPgQBkilwEKCkVABHRJbvEdUHwosc tfhoaQQzFQn206HiSuD2Lj62KZ9Ylt3MIoy5QepGCSBNVgYys+qt15PlXVEgvN/f5UIPfxkDFoPvo Jbzo1zjPKGqbu5jS7qKL2YyLixnbasabTB2e8U9h0ONZmn9PcwVYITX/L6GqxTpwdws6fESz+oI9i zbenIwAQ==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsyHn-000mb7-7H; Mon, 23 May 2022 02:59:15 +0000 X-UUID: 98e95165112e41d281a987073929444a-20220522 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=AdnHLVM+oerhxjlqmH3teKIttInw376KeUGWWv3wZOA=; b=bL/3EHL0M37VixW0KUD8OZJ0I/rtmvr4ghrOyNyH1RClhZnAOqEPiv0sgiFw4zfJ6ANCeEizf4cEVrKblfsr5EJDNeETTG867BoSBcBrst01S2abmqw+I8XoUPlysdGJiGxGqMLO5t8ftWnhHI1xPmK8RCmFawNqH16f0WoZ4Hg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:f29c0bff-31d8-4404-bb8f-fda7dadee5c2, OB:0, LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:2a19b09, CLOUDID:c411377a-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:0,BEC:nil X-UUID: 98e95165112e41d281a987073929444a-20220522 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 953365610; Sun, 22 May 2022 19:58:41 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 22 May 2022 19:58:40 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 23 May 2022 10:58:38 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 23 May 2022 10:58:25 +0800 Message-ID: Subject: Re: [PATCH v9 1/2] dt-bindings: phy: mediatek: Add YAML schema for PCIe PHY From: Jianjun Wang To: Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Matthias Brugger , "Chen-Yu Tsai" , AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: Wei-Shun Chang , , , , , , , , , , , Date: Mon, 23 May 2022 10:58:23 +0800 In-Reply-To: <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> References: <20220520064920.27313-1-jianjun.wang@mediatek.com> <20220520064920.27313-2-jianjun.wang@mediatek.com> <79706876349c3670f8831e75f70722f0bca200cb.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_035912_472607_4B955DDE X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chunfeng, On Mon, 2022-05-23 at 10:23 +0800, Chunfeng Yun wrote: > On Fri, 2022-05-20 at 14:49 +0800, Jianjun Wang wrote: > > Add YAML schema documentation for PCIe PHY on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/phy/mediatek,pcie-phy.yaml | 75 > > +++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/mediatek,pcie-phy.yaml > > ...snip... > > + > > + "#phy-cells": > > + const: 0 > > + > > + nvmem-cells: > > + maxItems: 7 > > Seems no need 'maxItems', we can get it from items of 'nvmem-cell- > names' Please see the comment by Krzysztof[1], I guess we need to add this 'maxTems'. [1]: https://lore.kernel.org/lkml/d48c0023-231c-4011-5548-4b260b3fe172@kernel.org/ Thanks. > > > + description: > > + Phandles to nvmem cell that contains the efuse data, if > > unspecified, > > + default value is used. > > + > > + nvmem-cell-names: > > + items: > > + - const: glb_intr > > + - const: tx_ln0_pmos > > + - const: tx_ln0_nmos > > + - const: rx_ln0 > > + - const: tx_ln1_pmos > > + - const: tx_ln1_nmos > > + - const: rx_ln1 > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - "#phy-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + phy@11e80000 { > > + compatible = "mediatek,mt8195-pcie-phy"; > > + #phy-cells = <0>; > > + reg = <0x11e80000 0x10000>; > > + reg-names = "sif"; > > + nvmem-cells = <&pciephy_glb_intr>, > > + <&pciephy_tx_ln0_pmos>, > > + <&pciephy_tx_ln0_nmos>, > > + <&pciephy_rx_ln0>, > > + <&pciephy_tx_ln1_pmos>, > > + <&pciephy_tx_ln1_nmos>, > > + <&pciephy_rx_ln1>; > > + nvmem-cell-names = "glb_intr", "tx_ln0_pmos", > > + "tx_ln0_nmos", "rx_ln0", > > + "tx_ln1_pmos", "tx_ln1_nmos", > > + "rx_ln1"; > > + power-domains = <&spm 2>; > > + }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel