All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Peter Hüwe" <PeterHuewe@gmx.de>, linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: Conversion of w83627ehf to hwmon_device_register_with_info ?
Date: Thu, 2 Mar 2017 18:56:01 -0800	[thread overview]
Message-ID: <bb297d0e-e87a-83a9-7a2a-9cc0e6f51164@roeck-us.net> (raw)
In-Reply-To: <201703030133.01363.PeterHuewe@gmx.de>

Hi Peter,

On 03/02/2017 04:33 PM, Peter Hüwe wrote:
> Hi,
>
> is anybody else working on the conversion of the w83627ehf to the new
> hwmon_device_register_with_info interface?
>
I don't think so.

> Otherwise I will probably update the driver to this interface within the next
> days - but since it's a lot of work I wanted to check for duplication first.
>
Go ahead. I would suggest to drop nct6775/nct6776 support to simplify the code
when you do that. Maybe as separate commit, though.

> Do you think it makes sense to introduce a hwmon_sensor_types for "intrusion"
> as well? - there are currently 8 drivers who offer that interface.
>
I don't really like the idea of introducing another type for just one attribute,
but it might be the easiest and most consistent approach. Feel free to submit
a patch to add it.

Guenter


  reply	other threads:[~2017-03-03  2:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  0:33 Conversion of w83627ehf to hwmon_device_register_with_info ? Peter Hüwe
2017-03-03  2:56 ` Guenter Roeck [this message]
2017-03-21 10:46   ` Peter Hüwe
2017-03-21 13:35     ` Guenter Roeck
2017-03-23  1:11       ` Peter Hüwe
2017-03-03 10:52 ` Jean Delvare
2017-03-06 20:48 ` Question about hwmon_attr_show_string Peter Hüwe
2017-03-06 23:47   ` Guenter Roeck
2017-03-07  9:08     ` Jean Delvare
2017-03-07  9:14       ` Peter Huewe
2017-03-07  9:14         ` Peter Huewe
2017-03-07 14:16       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb297d0e-e87a-83a9-7a2a-9cc0e6f51164@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=PeterHuewe@gmx.de \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.