From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05669C54E4B for ; Tue, 12 May 2020 06:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE9BB208DB for ; Tue, 12 May 2020 06:38:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hHWXn+bg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728893AbgELGiZ (ORCPT ); Tue, 12 May 2020 02:38:25 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:52976 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbgELGiY (ORCPT ); Tue, 12 May 2020 02:38:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589265502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2Yx2KVQWJiBe9bIHEVfkQtMdQnDiDw3qcsD5Sz8ek6U=; b=hHWXn+bgBNnR1ukAWcinfKdQ+m3qyewB80wD48PQ+MRXtdl49yKCBtyzde732wJCx1+Cq8 SNv74XSyFY+TwEsEBkoGnxex1S7P5JyuexNP7mxvekqzMM4CEFhqtPSR1VpIHuSe3d2TuQ 9IWf77Y18xVE0C48G/dJTyltIzagE5g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-md-jqOBsO3uJSsKCMHIXDQ-1; Tue, 12 May 2020 02:38:17 -0400 X-MC-Unique: md-jqOBsO3uJSsKCMHIXDQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 524F3460; Tue, 12 May 2020 06:38:16 +0000 (UTC) Received: from [10.36.113.77] (ovpn-113-77.ams2.redhat.com [10.36.113.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EDB27D8CE; Tue, 12 May 2020 06:38:12 +0000 (UTC) Subject: Re: MAINTAINERS: Wrong ordering in VIRTIO BALLOON To: Lukas Bulwahn Cc: "Michael S. Tsirkin" , Joe Perches , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: Date: Tue, 12 May 2020 08:38:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.05.20 07:21, Lukas Bulwahn wrote: > Hi David, > > with your commit 6d6b93b9afd8 ("MAINTAINERS: Add myself as virtio-balloon > co-maintainer"), visible on next-20200508, ./scripts/checkpatch.pl -f > MAINTAINERS complains: > > WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order > #17982: FILE: MAINTAINERS:17982: > +F: include/uapi/linux/virtio_balloon.h > +F: include/linux/balloon_compaction.h > > This is due to wrong ordering of the entries in your submission. If you > would like me to send you a patch fixing that, please just let me know. > > It is a recent addition to checkpatch.pl to report ordering problems in > MAINTAINERS, so you might have not seen that at submission time. Thanks for the notification Lukas, b962ee8622d0 ("checkpatch: additional MAINTAINER section entry ordering checks") is not in Linus' tree yet AFAIKS. I can see that 3b50142d8528 ("MAINTAINERS: sort field names for all entries") is upstream. I do wonder if we should just do another batch update after the checkpatch patch is upstream instead, I guess more will pile up? @mst, joe, what do you prefer? 1. I can resend the original patch. 2. Lukas can send a fixup that we might want to squash. 3. We wait until the checkpatch change goes upstream and to a final batch update. -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Tue, 12 May 2020 06:38:11 +0000 Subject: Re: MAINTAINERS: Wrong ordering in VIRTIO BALLOON Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lukas Bulwahn Cc: "Michael S. Tsirkin" , Joe Perches , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds On 12.05.20 07:21, Lukas Bulwahn wrote: > Hi David, > > with your commit 6d6b93b9afd8 ("MAINTAINERS: Add myself as virtio-balloon > co-maintainer"), visible on next-20200508, ./scripts/checkpatch.pl -f > MAINTAINERS complains: > > WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order > #17982: FILE: MAINTAINERS:17982: > +F: include/uapi/linux/virtio_balloon.h > +F: include/linux/balloon_compaction.h > > This is due to wrong ordering of the entries in your submission. If you > would like me to send you a patch fixing that, please just let me know. > > It is a recent addition to checkpatch.pl to report ordering problems in > MAINTAINERS, so you might have not seen that at submission time. Thanks for the notification Lukas, b962ee8622d0 ("checkpatch: additional MAINTAINER section entry ordering checks") is not in Linus' tree yet AFAIKS. I can see that 3b50142d8528 ("MAINTAINERS: sort field names for all entries") is upstream. I do wonder if we should just do another batch update after the checkpatch patch is upstream instead, I guess more will pile up? @mst, joe, what do you prefer? 1. I can resend the original patch. 2. Lukas can send a fixup that we might want to squash. 3. We wait until the checkpatch change goes upstream and to a final batch update. -- Thanks, David / dhildenb