From: Kim Bradley <kim.jamie.bradley@gmail.com>
To: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: rts5208: Capitalise preprocessor variable names
Date: Thu, 25 Oct 2018 09:08:28 -0700 (PDT) [thread overview]
Message-ID: <bb4722ef-436f-419c-af36-ea76145ec52a@googlegroups.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1810251515030.2363@hadrien>
[-- Attachment #1.1: Type: text/plain, Size: 9107 bytes --]
On Thursday, October 25, 2018 at 2:17:15 PM UTC, Julia Lawall wrote:
>
>
>
> On Thu, 25 Oct 2018, Kim Bradley wrote:
>
> > Capitalise header preprocesser variable names (and all
> > occurences) to remove checkpatch camelcase warnings.
>
> If the xD means something for the device, it could be better to leave it
> as is.
>
> Changing Sect_Per_Page seems like a good idea.
>
> julia
>
You're right. RTS5208 is a card reader and looking into it, there exists
an xD picture card (with camel-case). My bad!
Kim
>
> >
> > Signed-off-by: Kim Bradley <kim.jami...@gmail.com <javascript:>>
> > ---
> > drivers/staging/rts5208/xd.c | 8 ++++----
> > drivers/staging/rts5208/xd.h | 8 ++++----
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
> > index c5ee04ecd1c9..1187c75d764a 100644
> > --- a/drivers/staging/rts5208/xd.c
> > +++ b/drivers/staging/rts5208/xd.c
> > @@ -630,13 +630,13 @@ static int reset_xd(struct rtsx_chip *chip)
> > xd_card->zone_cnt = 32;
> > xd_card->capacity = 1024000;
> > break;
> > - case xD_1G_X8_512:
> > + case XD_1G_X8_512:
> > XD_PAGE_512(xd_card);
> > xd_card->addr_cycle = 4;
> > xd_card->zone_cnt = 64;
> > xd_card->capacity = 2048000;
> > break;
> > - case xD_2G_X8_512:
> > + case XD_2G_X8_512:
> > XD_PAGE_512(xd_card);
> > xd_card->addr_cycle = 4;
> > xd_card->zone_cnt = 128;
> > @@ -669,10 +669,10 @@ static int reset_xd(struct rtsx_chip *chip)
> > return STATUS_FAIL;
> > }
> >
> > - retval = xd_read_id(chip, READ_xD_ID, id_buf, 4);
> > + retval = xd_read_id(chip, READ_XD_ID, id_buf, 4);
> > if (retval != STATUS_SUCCESS)
> > return STATUS_FAIL;
> > - dev_dbg(rtsx_dev(chip), "READ_xD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> > + dev_dbg(rtsx_dev(chip), "READ_XD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> > id_buf[0], id_buf[1], id_buf[2], id_buf[3]);
> > if (id_buf[2] != XD_ID_CODE)
> > return STATUS_FAIL;
> > diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
> > index bf21bf0d1616..98c00f268e56 100644
> > --- a/drivers/staging/rts5208/xd.h
> > +++ b/drivers/staging/rts5208/xd.h
> > @@ -36,7 +36,7 @@
> > #define BLK_ERASE_1 0x60
> > #define BLK_ERASE_2 0xD0
> > #define READ_STS 0x70
> > -#define READ_xD_ID 0x9A
> > +#define READ_XD_ID 0x9A
> > #define COPY_BACK_512 0x8A
> > #define COPY_BACK_2K 0x85
> > #define READ1_1_2 0x30
> > @@ -72,8 +72,8 @@
> > #define XD_128M_X16_2048 0xC1
> > #define XD_4M_X8_512_1 0xE3
> > #define XD_4M_X8_512_2 0xE5
> > -#define xD_1G_X8_512 0xD3
> > -#define xD_2G_X8_512 0xD5
> > +#define XD_1G_X8_512 0xD3
> > +#define XD_2G_X8_512 0xD5
> >
> > #define XD_ID_CODE 0xB5
> >
> > @@ -90,7 +90,7 @@
> > #define NO_OFFSET 0x0
> > #define WITH_OFFSET 0x1
> >
> > -#define Sect_Per_Page 4
> > +#define SECT_PER_PAGE 4
> > #define XD_ADDR_MODE_2C XD_ADDR_MODE_2A
> >
> > #define ZONE0_BAD_BLOCK 23
> > --
> > 2.19.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20181025071536.GA3274%40xubuntu-vm.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
On Thursday, October 25, 2018 at 2:17:15 PM UTC, Julia Lawall wrote:
>
>
>
> On Thu, 25 Oct 2018, Kim Bradley wrote:
>
> > Capitalise header preprocesser variable names (and all
> > occurences) to remove checkpatch camelcase warnings.
>
> If the xD means something for the device, it could be better to leave it
> as is.
>
> Changing Sect_Per_Page seems like a good idea.
>
> julia
>
> >
> > Signed-off-by: Kim Bradley <kim.jami...@gmail.com <javascript:>>
> > ---
> > drivers/staging/rts5208/xd.c | 8 ++++----
> > drivers/staging/rts5208/xd.h | 8 ++++----
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
> > index c5ee04ecd1c9..1187c75d764a 100644
> > --- a/drivers/staging/rts5208/xd.c
> > +++ b/drivers/staging/rts5208/xd.c
> > @@ -630,13 +630,13 @@ static int reset_xd(struct rtsx_chip *chip)
> > xd_card->zone_cnt = 32;
> > xd_card->capacity = 1024000;
> > break;
> > - case xD_1G_X8_512:
> > + case XD_1G_X8_512:
> > XD_PAGE_512(xd_card);
> > xd_card->addr_cycle = 4;
> > xd_card->zone_cnt = 64;
> > xd_card->capacity = 2048000;
> > break;
> > - case xD_2G_X8_512:
> > + case XD_2G_X8_512:
> > XD_PAGE_512(xd_card);
> > xd_card->addr_cycle = 4;
> > xd_card->zone_cnt = 128;
> > @@ -669,10 +669,10 @@ static int reset_xd(struct rtsx_chip *chip)
> > return STATUS_FAIL;
> > }
> >
> > - retval = xd_read_id(chip, READ_xD_ID, id_buf, 4);
> > + retval = xd_read_id(chip, READ_XD_ID, id_buf, 4);
> > if (retval != STATUS_SUCCESS)
> > return STATUS_FAIL;
> > - dev_dbg(rtsx_dev(chip), "READ_xD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> > + dev_dbg(rtsx_dev(chip), "READ_XD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> > id_buf[0], id_buf[1], id_buf[2], id_buf[3]);
> > if (id_buf[2] != XD_ID_CODE)
> > return STATUS_FAIL;
> > diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
> > index bf21bf0d1616..98c00f268e56 100644
> > --- a/drivers/staging/rts5208/xd.h
> > +++ b/drivers/staging/rts5208/xd.h
> > @@ -36,7 +36,7 @@
> > #define BLK_ERASE_1 0x60
> > #define BLK_ERASE_2 0xD0
> > #define READ_STS 0x70
> > -#define READ_xD_ID 0x9A
> > +#define READ_XD_ID 0x9A
> > #define COPY_BACK_512 0x8A
> > #define COPY_BACK_2K 0x85
> > #define READ1_1_2 0x30
> > @@ -72,8 +72,8 @@
> > #define XD_128M_X16_2048 0xC1
> > #define XD_4M_X8_512_1 0xE3
> > #define XD_4M_X8_512_2 0xE5
> > -#define xD_1G_X8_512 0xD3
> > -#define xD_2G_X8_512 0xD5
> > +#define XD_1G_X8_512 0xD3
> > +#define XD_2G_X8_512 0xD5
> >
> > #define XD_ID_CODE 0xB5
> >
> > @@ -90,7 +90,7 @@
> > #define NO_OFFSET 0x0
> > #define WITH_OFFSET 0x1
> >
> > -#define Sect_Per_Page 4
> > +#define SECT_PER_PAGE 4
> > #define XD_ADDR_MODE_2C XD_ADDR_MODE_2A
> >
> > #define ZONE0_BAD_BLOCK 23
> > --
> > 2.19.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20181025071536.GA3274%40xubuntu-vm.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 15738 bytes --]
next prev parent reply other threads:[~2018-10-25 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 7:15 [PATCH] Staging: rts5208: Capitalise preprocessor variable names Kim Bradley
2018-10-25 14:17 ` [Outreachy kernel] " Julia Lawall
2018-10-25 16:08 ` Kim Bradley [this message]
2018-10-25 16:31 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb4722ef-436f-419c-af36-ea76145ec52a@googlegroups.com \
--to=kim.jamie.bradley@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.