From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH V2 net-next 1/6] netlink: Convert extack msg to a formattable buffer
Date: Sat, 23 Nov 2019 18:10:50 -0700 [thread overview]
Message-ID: <bb598347-bfe3-4e39-2e69-5db3b3188c7b@gmail.com> (raw)
In-Reply-To: <20191123165655.5a9b8877@cakuba.netronome.com>
On 11/23/19 5:56 PM, Jakub Kicinski wrote:
>> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
>> index 205fa7b1f07a..de9004da0288 100644
>> --- a/include/linux/netlink.h
>> +++ b/include/linux/netlink.h
>> @@ -62,6 +62,7 @@ netlink_kernel_create(struct net *net, int unit, struct netlink_kernel_cfg *cfg)
>>
>> /* this can be increased when necessary - don't expose to userland */
>> #define NETLINK_MAX_COOKIE_LEN 20
>> +#define NL_EXTACK_MAX_MSG_SZ 128
This makes extack use a lot of stack. There are a number of places that
are already emitting warnings about high stack usage.
next prev parent reply other threads:[~2019-11-24 1:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 22:41 [PATCH V2 net-next 0/6] mlxfw: Improve error reporting Saeed Mahameed
2019-11-22 22:41 ` [PATCH V2 net-next 1/6] netlink: Convert extack msg to a formattable buffer Saeed Mahameed
2019-11-24 0:56 ` Jakub Kicinski
2019-11-24 1:10 ` David Ahern [this message]
2019-11-24 1:20 ` David Ahern
2019-11-25 9:48 ` Johannes Berg
2019-11-25 23:12 ` Saeed Mahameed
2019-11-22 22:41 ` [PATCH V2 net-next 2/6] net/mlxfw: Generic mlx FW flash status notify Saeed Mahameed
2019-11-22 22:41 ` [PATCH V2 net-next 3/6] net/mlxfw: Improve FSM err message reporting and return codes Saeed Mahameed
2019-11-24 1:00 ` Jakub Kicinski
2019-11-22 22:41 ` [PATCH V2 net-next 4/6] net/mlxfw: Convert pr_* to dev_* in mlxfw_fsm.c Saeed Mahameed
2019-11-22 22:41 ` [PATCH V2 net-next 5/6] net/mlxfw: More error messages coverage Saeed Mahameed
2019-11-22 22:41 ` [PATCH V2 net-next 6/6] net/mlxfw: Macro for error reporting Saeed Mahameed
2019-11-24 0:48 ` [PATCH V2 net-next 0/6] mlxfw: Improve " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb598347-bfe3-4e39-2e69-5db3b3188c7b@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.