Re: [Qemu-devel] [PATCH for-2.10 5/5] tests: acpi: fix FADT not being compared to reference table

[Marcel Apfelbaum <marcel@redhat.com>]

On 02/08/2017 17:10, Igor Mammedov wrote:
> On Wed, 2 Aug 2017 16:15:10 +0300
> Marcel Apfelbaum <marcel@redhat.com> wrote:
> 
>> On 31/07/2017 18:40, Igor Mammedov wrote:
>>> It turns out that FADT isn't actually tested for changes
>>> against reference table, since it happens to be the 1st
>>> table in RSDT which is currently ignored.
>>> Fix it by making sure that all tables from RSDT are added
>>> to test list.
>>>    
>>
>> Hi Igor,
>>
>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>> ---
>>>    tests/bios-tables-test.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
>>> index a2a90d7..129ef46 100644
>>> --- a/tests/bios-tables-test.c
>>> +++ b/tests/bios-tables-test.c
>>> @@ -243,13 +243,13 @@ static void test_acpi_dsdt_table(test_data *data)
>>>    /* Load all tables and add to test list directly RSDT referenced tables */
>>>    static void fetch_rsdt_referenced_tables(test_data *data)
>>>    {
>>> -    int tables_nr = data->rsdt_tables_nr - 1; /* fadt is first */
>>> +    int tables_nr = data->rsdt_tables_nr;
>>>        int i;
>>>    
>>>        for (i = 0; i < tables_nr; i++) {
>>>            AcpiSdtTable ssdt_table;
>>>    
>>> -        uint32_t addr = data->rsdt_tables_addr[i + 1]; /* fadt is first */
>>> +        uint32_t addr = data->rsdt_tables_addr[i];
>>>            fetch_table(&ssdt_table, addr);
>>>    
>>>            /* Add table to ASL test tables list */
>>>    
>>
>> For some reason I decided not to test it... strange.
>> Anyway, we should also add the expected file, right?
>> (the rebuild script works only for existent tables, I think)
> they are there see: tests/acpi-test-data/*/FACP
> files obviously stale as they haven't been actually used.
> Michael should update them when he applies this series.
> 

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel

>>
>> Thanks,
>> Marcel
>>
>>
>>
>