From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23AF0C47094 for ; Mon, 7 Jun 2021 16:08:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE33861164 for ; Mon, 7 Jun 2021 16:08:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE33861164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqHnH-0002gj-1p for qemu-devel@archiver.kernel.org; Mon, 07 Jun 2021 12:08:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqHl0-0000Hi-70 for qemu-devel@nongnu.org; Mon, 07 Jun 2021 12:05:42 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:46654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqHky-0002Ct-GG for qemu-devel@nongnu.org; Mon, 07 Jun 2021 12:05:41 -0400 Received: by mail-pl1-x62f.google.com with SMTP id e1so8936585pld.13 for ; Mon, 07 Jun 2021 09:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2+BFUj0K1lmuhedrLyvXZC4X1M6e648XSonZM2jKLcw=; b=I0E1AGFkwm5N6MAdIJDhklpty3jUSosRL5u2x4FYDhL3ZUt2XVkYn7mHmXwWFViAVn L4BoCFwbXCysbSq983cCcYGQnUAWfUbUD/+ypaQUEIhQffc41ZINIWnGwQv+0ujUoq9F JG6NvhR7pyXhEnzfqrIBgRFQ/+MMG7gvU6rjpNZZ96awmswQTALaL7vK+fir4mxclm/K Rt5R7tnfYoiHVUdTHdxuT+RH0Y8SSLpu4M+kLsyC8SuGlr173Igw8mOifmK6Rj85Tu31 PAQ5nGWtiTTgh52ZLgBTM7cyrqLZqEAbr48sVabwM0fyKsEuYQ5+FDtp5mHpcJ5EKOcp CuyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2+BFUj0K1lmuhedrLyvXZC4X1M6e648XSonZM2jKLcw=; b=Wu+ss3UNQXh6V6fNcVth7NseGJIIl0i3IX3IXwzYU9DZoyrORuoj9xS0M8O5PDVe7M x3mqiBi21mJwSbGzTUKq9iBVsLmvOq3JAKC/cnoebJJudMXk53LsO1Xvu0HEDNLXn3JB yEtYEHr6jn/9EVgWhpoVoNOvrLZXacwafBTDcra/Xh6svXgk6q/D8HwKajsbnvo4wyxw 7h+7dPVoHAsH4k2sOq0s1NVtKrKdnRr7+wgvDywyZnh63I1GY16DwwejsX4HVd1P7RnJ XrwLojX4uLG20a624yJt28b+yEFxixm9sDXeCH1JNScXCYO4r0nciskogs79giTRWxuQ z0lQ== X-Gm-Message-State: AOAM530+CSCwiwAl4xLQO4ZrVWTK+wj2KGNRahAvoA50XUlXvbh/abQb hZFlVDY0DF/5G1OwckoOdkKvBA== X-Google-Smtp-Source: ABdhPJwvi0GmsRohEYBtv+a7bJc4A0vmKOXQVIveAils3NpT+58QBW4t2HRN5rlw6dBi6HgzHs1WdA== X-Received: by 2002:a17:902:e843:b029:109:4dbc:d4ed with SMTP id t3-20020a170902e843b02901094dbcd4edmr18802873plg.74.1623081938777; Mon, 07 Jun 2021 09:05:38 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id f13sm8599773pfa.207.2021.06.07.09.05.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 09:05:38 -0700 (PDT) Subject: Re: [PATCH v3 01/26] s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling To: David Hildenbrand , qemu-devel@nongnu.org References: <20210607110338.31058-1-david@redhat.com> <20210607110338.31058-2-david@redhat.com> From: Richard Henderson Message-ID: Date: Mon, 7 Jun 2021 09:05:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210607110338.31058-2-david@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck , Laurent Vivier , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/7/21 4:03 AM, David Hildenbrand wrote: > In case we encounter a NaN, we have to return the smallest possible > number, corresponding to either 0 or the maximum negative number. This > seems to differ from IEEE handling as implemented in softfloat, whereby > we return the biggest possible number. > > While at it, use float32_to_uint64() in the CLGEB handler. > > Signed-off-by: David Hildenbrand > --- > target/s390x/fpu_helper.c | 41 +++++++++++++++++++++++++++++++---- > target/s390x/vec_fpu_helper.c | 8 +++++-- > 2 files changed, 43 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~