From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= via amd-gfx Subject: Re: [PATCH v2 1/4] drm/sched: Fix entities with 0 rqs. Date: Thu, 14 Feb 2019 10:08:49 +0100 Message-ID: References: <20190130015322.105870-1-bas@basnieuwenhuizen.nl> <23f6617a-2049-11b3-b1df-07eb029db714@gmail.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , Christian Koenig Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx list , Maling list - DRI developers , Bas Nieuwenhuizen List-Id: dri-devel@lists.freedesktop.org QW0gMTMuMDIuMTkgdW0gMjI6MDMgc2NocmllYiBBbGV4IERldWNoZXIgdmlhIGFtZC1nZng6Cj4g T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgNTo0MyBBTSBDaHJpc3RpYW4gS8O2bmlnCj4gPGNrb2Vu aWcubGVpY2h0enVtZXJrZW5AZ21haWwuY29tPiB3cm90ZToKPj4gQW0gMzAuMDEuMTkgdW0gMDI6 NTMgc2NocmllYiBCYXMgTmlldXdlbmh1aXplbjoKPj4+IFNvbWUgYmxvY2tzIGluIGFtZGdwdSBj YW4gaGF2ZSAwIHJxcy4KPj4+Cj4+PiBKb2IgY3JlYXRpb24gYWxyZWFkeSBmYWlscyB3aXRoIC1F Tk9FTlQgd2hlbiBlbnRpdHktPnJxIGlzIE5VTEwsCj4+PiBzbyBqb2JzIGNhbm5vdCBiZSBwdXNo ZWQuIFdpdGhvdXQgYSBycSB0aGVyZSBpcyBubyBzY2hlZHVsZXIgdG8KPj4+IHBvcCBqb2JzLCBh bmQgcnEgc2VsZWN0aW9uIGFscmVhZHkgZG9lcyB0aGUgcmlnaHQgdGhpbmcgd2l0aCBhCj4+PiBs aXN0IG9mIGxlbmd0aCAwLgo+Pj4KPj4+IFNvIHRoZSBvcGVyYXRpb25zIHdlIG5lZWQgdG8gZml4 IGFyZToKPj4+ICAgICAtIENyZWF0aW9uLCBkbyBub3Qgc2V0IHJxIHRvIHJxX2xpc3RbMF0gaWYg dGhlIGxpc3QgY2FuIGhhdmUgbGVuZ3RoIDAuCj4+PiAgICAgLSBEbyBub3QgZmx1c2ggYW55IGpv YnMgd2hlbiB0aGVyZSBpcyBubyBycS4KPj4+ICAgICAtIE9uIGVudGl0eSBkZXN0cnVjdGlvbiBo YW5kbGUgdGhlIHJxID0gTlVMTCBjYXNlLgo+Pj4gICAgIC0gb24gc2V0X3ByaW9yaXR5LCBkbyBu b3QgdHJ5IHRvIGNoYW5nZSB0aGUgcnEgaWYgaXQgaXMgTlVMTC4KPj4+Cj4+PiBTaWduZWQtb2Zm LWJ5OiBCYXMgTmlldXdlbmh1aXplbiA8YmFzQGJhc25pZXV3ZW5odWl6ZW4ubmw+Cj4+IE9uZSBt aW5vciBjb21tZW50IG9uIHBhdGNoICMyLCBhcGFydCBmcm9tIHRoYXQgdGhlIHNlcmllcyBpcwo+ PiBSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29t Pi4KPj4KPj4gSSdtIGdvaW5nIHRvIG1ha2UgdGhlIGNoYW5nZSBvbiAjMiBhbmQgcGljayB0aGVt IHVwIGZvciBpbmNsdXNpb24gaW4KPj4gYW1kLXN0YWdpbmctZHJtLW5leHQuCj4gSGkgQ2hyaXN0 aWFuLAo+Cj4gSSBoYXZlbid0IHNlZW4gdGhlc2UgbGFuZCB5ZXQuICBKdXN0IHdhbnQgdG8gbWFr ZSBzdXJlIHRoZXkgZG9uJ3QgZmFsbAo+IHRocm91Z2ggdGhlIGNyYWNrcy4KClRoYW5rcyBmb3Ig dGhlIHJlbWluZGVyLCBJJ20gcmVhbGx5IGhhdmluZyB0cm91YmxlIGNhdGNoaW5nIHVwIG9uIAph cHBseWluZyBwYXRjaGVzIGxhdGVseS4KCkNocmlzdGlhbi4KCj4KPiBBbGV4Cj4KPj4gVGhhbmtz IGZvciB0aGUgaGVscCwKPj4gQ2hyaXN0aWFuLgo+Pgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2dw dS9kcm0vc2NoZWR1bGVyL3NjaGVkX2VudGl0eS5jIHwgMzkgKysrKysrKysrKysrKysrKy0tLS0t LS0tCj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25z KC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvc2NoZWRf ZW50aXR5LmMgYi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX2VudGl0eS5jCj4+PiBp bmRleCA0NDYzZDM4MjZlY2IuLjhlMzFiNjYyOGQwOSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9zY2hlZHVsZXIvc2NoZWRfZW50aXR5LmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9zY2hlZHVsZXIvc2NoZWRfZW50aXR5LmMKPj4+IEBAIC01MiwxMiArNTIsMTIgQEAgaW50IGRy bV9zY2hlZF9lbnRpdHlfaW5pdChzdHJ1Y3QgZHJtX3NjaGVkX2VudGl0eSAqZW50aXR5LAo+Pj4g ICAgewo+Pj4gICAgICAgIGludCBpOwo+Pj4KPj4+IC0gICAgIGlmICghKGVudGl0eSAmJiBycV9s aXN0ICYmIG51bV9ycV9saXN0ID4gMCAmJiBycV9saXN0WzBdKSkKPj4+ICsgICAgIGlmICghKGVu dGl0eSAmJiBycV9saXN0ICYmIChudW1fcnFfbGlzdCA9PSAwIHx8IHJxX2xpc3RbMF0pKSkKPj4+ ICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4KPj4+ICAgICAgICBtZW1zZXQoZW50 aXR5LCAwLCBzaXplb2Yoc3RydWN0IGRybV9zY2hlZF9lbnRpdHkpKTsKPj4+ICAgICAgICBJTklU X0xJU1RfSEVBRCgmZW50aXR5LT5saXN0KTsKPj4+IC0gICAgIGVudGl0eS0+cnEgPSBycV9saXN0 WzBdOwo+Pj4gKyAgICAgZW50aXR5LT5ycSA9IE5VTEw7Cj4+PiAgICAgICAgZW50aXR5LT5ndWls dHkgPSBndWlsdHk7Cj4+PiAgICAgICAgZW50aXR5LT5udW1fcnFfbGlzdCA9IG51bV9ycV9saXN0 Owo+Pj4gICAgICAgIGVudGl0eS0+cnFfbGlzdCA9IGtjYWxsb2MobnVtX3JxX2xpc3QsIHNpemVv ZihzdHJ1Y3QgZHJtX3NjaGVkX3JxICopLAo+Pj4gQEAgLTY3LDYgKzY3LDEwIEBAIGludCBkcm1f c2NoZWRfZW50aXR5X2luaXQoc3RydWN0IGRybV9zY2hlZF9lbnRpdHkgKmVudGl0eSwKPj4+Cj4+ PiAgICAgICAgZm9yIChpID0gMDsgaSA8IG51bV9ycV9saXN0OyArK2kpCj4+PiAgICAgICAgICAg ICAgICBlbnRpdHktPnJxX2xpc3RbaV0gPSBycV9saXN0W2ldOwo+Pj4gKwo+Pj4gKyAgICAgaWYg KG51bV9ycV9saXN0KQo+Pj4gKyAgICAgICAgICAgICBlbnRpdHktPnJxID0gcnFfbGlzdFswXTsK Pj4+ICsKPj4+ICAgICAgICBlbnRpdHktPmxhc3Rfc2NoZWR1bGVkID0gTlVMTDsKPj4+Cj4+PiAg ICAgICAgc3Bpbl9sb2NrX2luaXQoJmVudGl0eS0+cnFfbG9jayk7Cj4+PiBAQCAtMTY1LDYgKzE2 OSw5IEBAIGxvbmcgZHJtX3NjaGVkX2VudGl0eV9mbHVzaChzdHJ1Y3QgZHJtX3NjaGVkX2VudGl0 eSAqZW50aXR5LCBsb25nIHRpbWVvdXQpCj4+PiAgICAgICAgc3RydWN0IHRhc2tfc3RydWN0ICps YXN0X3VzZXI7Cj4+PiAgICAgICAgbG9uZyByZXQgPSB0aW1lb3V0Owo+Pj4KPj4+ICsgICAgIGlm ICghZW50aXR5LT5ycSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+PiArCj4+PiAgICAg ICAgc2NoZWQgPSBlbnRpdHktPnJxLT5zY2hlZDsKPj4+ICAgICAgICAvKioKPj4+ICAgICAgICAg KiBUaGUgY2xpZW50IHdpbGwgbm90IHF1ZXVlIG1vcmUgSUJzIGR1cmluZyB0aGlzIGZpbmksIGNv bnN1bWUgZXhpc3RpbmcKPj4+IEBAIC0yNjQsMjAgKzI3MSwyNCBAQCBzdGF0aWMgdm9pZCBkcm1f c2NoZWRfZW50aXR5X2tpbGxfam9icyhzdHJ1Y3QgZHJtX3NjaGVkX2VudGl0eSAqZW50aXR5KQo+ Pj4gICAgICovCj4+PiAgICB2b2lkIGRybV9zY2hlZF9lbnRpdHlfZmluaShzdHJ1Y3QgZHJtX3Nj aGVkX2VudGl0eSAqZW50aXR5KQo+Pj4gICAgewo+Pj4gLSAgICAgc3RydWN0IGRybV9ncHVfc2No ZWR1bGVyICpzY2hlZDsKPj4+ICsgICAgIHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxlciAqc2NoZWQg PSBOVUxMOwo+Pj4KPj4+IC0gICAgIHNjaGVkID0gZW50aXR5LT5ycS0+c2NoZWQ7Cj4+PiAtICAg ICBkcm1fc2NoZWRfcnFfcmVtb3ZlX2VudGl0eShlbnRpdHktPnJxLCBlbnRpdHkpOwo+Pj4gKyAg ICAgaWYgKGVudGl0eS0+cnEpIHsKPj4+ICsgICAgICAgICAgICAgc2NoZWQgPSBlbnRpdHktPnJx LT5zY2hlZDsKPj4+ICsgICAgICAgICAgICAgZHJtX3NjaGVkX3JxX3JlbW92ZV9lbnRpdHkoZW50 aXR5LT5ycSwgZW50aXR5KTsKPj4+ICsgICAgIH0KPj4+Cj4+PiAgICAgICAgLyogQ29uc3VtcHRp b24gb2YgZXhpc3RpbmcgSUJzIHdhc24ndCBjb21wbGV0ZWQuIEZvcmNlZnVsbHkKPj4+ICAgICAg ICAgKiByZW1vdmUgdGhlbSBoZXJlLgo+Pj4gICAgICAgICAqLwo+Pj4gICAgICAgIGlmIChzcHNj X3F1ZXVlX3BlZWsoJmVudGl0eS0+am9iX3F1ZXVlKSkgewo+Pj4gLSAgICAgICAgICAgICAvKiBQ YXJrIHRoZSBrZXJuZWwgZm9yIGEgbW9tZW50IHRvIG1ha2Ugc3VyZSBpdCBpc24ndCBwcm9jZXNz aW5nCj4+PiAtICAgICAgICAgICAgICAqIG91ciBlbml0eS4KPj4+IC0gICAgICAgICAgICAgICov Cj4+PiAtICAgICAgICAgICAgIGt0aHJlYWRfcGFyayhzY2hlZC0+dGhyZWFkKTsKPj4+IC0gICAg ICAgICAgICAga3RocmVhZF91bnBhcmsoc2NoZWQtPnRocmVhZCk7Cj4+PiArICAgICAgICAgICAg IGlmIChzY2hlZCkgewo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIC8qIFBhcmsgdGhlIGtlcm5l bCBmb3IgYSBtb21lbnQgdG8gbWFrZSBzdXJlIGl0IGlzbid0IHByb2Nlc3NpbmcKPj4+ICsgICAg ICAgICAgICAgICAgICAgICAgKiBvdXIgZW5pdHkuCj4+PiArICAgICAgICAgICAgICAgICAgICAg ICovCj4+PiArICAgICAgICAgICAgICAgICAgICAga3RocmVhZF9wYXJrKHNjaGVkLT50aHJlYWQp Owo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGt0aHJlYWRfdW5wYXJrKHNjaGVkLT50aHJlYWQp Owo+Pj4gKyAgICAgICAgICAgICB9Cj4+PiAgICAgICAgICAgICAgICBpZiAoZW50aXR5LT5kZXBl bmRlbmN5KSB7Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgIGRtYV9mZW5jZV9yZW1vdmVfY2Fs bGJhY2soZW50aXR5LT5kZXBlbmRlbmN5LAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICZlbnRpdHktPmNiKTsKPj4+IEBAIC0zNjIsOSArMzczLDEx IEBAIHZvaWQgZHJtX3NjaGVkX2VudGl0eV9zZXRfcHJpb3JpdHkoc3RydWN0IGRybV9zY2hlZF9l bnRpdHkgKmVudGl0eSwKPj4+ICAgICAgICBmb3IgKGkgPSAwOyBpIDwgZW50aXR5LT5udW1fcnFf bGlzdDsgKytpKQo+Pj4gICAgICAgICAgICAgICAgZHJtX3NjaGVkX2VudGl0eV9zZXRfcnFfcHJp b3JpdHkoJmVudGl0eS0+cnFfbGlzdFtpXSwgcHJpb3JpdHkpOwo+Pj4KPj4+IC0gICAgIGRybV9z Y2hlZF9ycV9yZW1vdmVfZW50aXR5KGVudGl0eS0+cnEsIGVudGl0eSk7Cj4+PiAtICAgICBkcm1f c2NoZWRfZW50aXR5X3NldF9ycV9wcmlvcml0eSgmZW50aXR5LT5ycSwgcHJpb3JpdHkpOwo+Pj4g LSAgICAgZHJtX3NjaGVkX3JxX2FkZF9lbnRpdHkoZW50aXR5LT5ycSwgZW50aXR5KTsKPj4+ICsg ICAgIGlmIChlbnRpdHktPnJxKSB7Cj4+PiArICAgICAgICAgICAgIGRybV9zY2hlZF9ycV9yZW1v dmVfZW50aXR5KGVudGl0eS0+cnEsIGVudGl0eSk7Cj4+PiArICAgICAgICAgICAgIGRybV9zY2hl ZF9lbnRpdHlfc2V0X3JxX3ByaW9yaXR5KCZlbnRpdHktPnJxLCBwcmlvcml0eSk7Cj4+PiArICAg ICAgICAgICAgIGRybV9zY2hlZF9ycV9hZGRfZW50aXR5KGVudGl0eS0+cnEsIGVudGl0eSk7Cj4+ PiArICAgICB9Cj4+Pgo+Pj4gICAgICAgIHNwaW5fdW5sb2NrKCZlbnRpdHktPnJxX2xvY2spOwo+ Pj4gICAgfQo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFt ZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==