From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBBEC433E0 for ; Tue, 16 Mar 2021 15:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1663765093 for ; Tue, 16 Mar 2021 15:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236384AbhCPPEJ (ORCPT ); Tue, 16 Mar 2021 11:04:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237675AbhCPPDr (ORCPT ); Tue, 16 Mar 2021 11:03:47 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0A82C06174A for ; Tue, 16 Mar 2021 08:03:46 -0700 (PDT) Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 02CC98C8; Tue, 16 Mar 2021 16:03:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615907024; bh=Y5XDZwZVjldQ7Ot6EtDI/mwOfC2+GTnR+yFGOoNsI4Y=; h=Subject:To:References:From:Date:In-Reply-To:From; b=n/uwmz5NBdcibV4uxTL7g4e2IlmYoO9WW5rrK7aULLHqpyJNbXcJXz3yGWNEqxUK0 yYP0Gq8f9bg4JIoA1bVxsKlKSqVk7ePT7HU3F9ovjyl/RnXUfs526f5+T455tJrYvr /SMQ1wxBgA523FvY1597PimzXTXI58SbKZ5dWSnY= Subject: Re: [PATCH 03/13] ti-vpe/cal.h: fix kernel-doc formatting To: Hans Verkuil , linux-media@vger.kernel.org References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> <20210311102022.96954-4-hverkuil-cisco@xs4all.nl> From: Tomi Valkeinen Message-ID: Date: Tue, 16 Mar 2021 17:03:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210311102022.96954-4-hverkuil-cisco@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 11/03/2021 12:20, Hans Verkuil wrote: > Fix inline struct member documentation, was missing the > '@memb:' prefix. > > Signed-off-by: Hans Verkuil > Cc: Tomi Valkeinen > --- > drivers/media/platform/ti-vpe/cal.h | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/ti-vpe/cal.h b/drivers/media/platform/ti-vpe/cal.h > index d471b7f82519..7aaea82c6b42 100644 > --- a/drivers/media/platform/ti-vpe/cal.h > +++ b/drivers/media/platform/ti-vpe/cal.h > @@ -84,35 +84,34 @@ struct cal_buffer { > > /** > * struct cal_dmaqueue - Queue of DMA buffers > - * @active: Buffer being DMA'ed to for the current frame > */ > struct cal_dmaqueue { > /** > - * Protects all fields in the cal_dmaqueue. > + * @lock: Protects all fields in the cal_dmaqueue. > */ > spinlock_t lock; > > /** > - * Buffers queued to the driver and waiting for DMA processing. > + * @queue: Buffers queued to the driver and waiting for DMA processing. > * Buffers are added to the list by the vb2 .buffer_queue() operation, > * and move to @pending when they are scheduled for the next frame. > */ > struct list_head queue; > /** > - * Buffer provided to the hardware to DMA the next frame. Will move to > - * @active at the end of the current frame. > + * @pending: Buffer provided to the hardware to DMA the next frame. > + * Will move to @active at the end of the current frame. > */ > struct cal_buffer *pending; > /** > - * Buffer being DMA'ed to for the current frame. Will be retired and > - * given back to vb2 at the end of the current frame if a @pending > - * buffer has been scheduled to replace it. > + * @active: Buffer being DMA'ed to for the current frame. Will be > + * retired and given back to vb2 at the end of the current frame if > + * a @pending buffer has been scheduled to replace it. > */ > struct cal_buffer *active; > > - /** State of the DMA engine. */ > + /** @state: State of the DMA engine. */ > enum cal_dma_state state; > - /** Wait queue to signal a @state transition to CAL_DMA_STOPPED. */ > + /** @wait: Wait queue to signal a @state transition to CAL_DMA_STOPPED. */ > struct wait_queue_head wait; > }; > > Reviewed-by: Tomi Valkeinen Tomi