From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/6] drm/i915/icl: Correctly initialize the Gen11 engines Date: Wed, 7 Mar 2018 08:02:56 +0000 Message-ID: References: <20180302161501.28594-1-mika.kuoppala@linux.intel.com> <20180302161501.28594-2-mika.kuoppala@linux.intel.com> <2641ca98-3866-af7e-c34b-94d514e2f98d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 142016E180 for ; Wed, 7 Mar 2018 08:02:58 +0000 (UTC) In-Reply-To: <2641ca98-3866-af7e-c34b-94d514e2f98d@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniele Ceraolo Spurio , Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzAzLzIwMTggMjI6MDcsIERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gd3JvdGU6Cj4gT24g MDIvMDMvMTggMDg6MTQsIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4+IEZyb206IE9zY2FyIE1hdGVv IDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4+Cj4+IEdlbjExIGhhcyB1cCB0byA0IFZDUyBhbmQg dXAgdG8gMiBWRUNTIGVuZ2luZXMsIHRoaXMgcGF0Y2ggYWRkcyBtbWlvCj4+IGJhc2UgZGVmaW5p dGlvbnMgZm9yIGFsbCBvZiB0aGVtLgo+Pgo+PiBCc3BlYzogMjA5NDQKPj4gQnNwZWM6IDcwMjEK Pj4KPj4gdjI6IFNldCB0aGUgY29ycmVjdCBtbWlvX2Jhc2UgaW4gaW50ZWxfZW5naW5lc19pbml0 X21taW87IHVwZGF0aW5nIHRoZQo+PiBiYXNlIG1taW8gdmFsdWVzIGFueSBsYXRlciB3b3VsZCBj YXVzZSBpbmNvcnJlY3QgcmVhZHMgaW4KPj4gaTkxNV9nZW1fc2FuaXRpemUgKE1pY2hlbCkuCj4+ Cj4+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBDYzog Q2VyYW9sbyBTcHVyaW8sIERhbmllbGUgPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+ Cj4+IFNpZ25lZC1vZmYtYnk6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4+ IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+ Cj4+IC0tLQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5owqDCoMKgwqDCoMKg wqAgfMKgIDYgKysrKysKPj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2Nz LmMgfCA0NCAKPj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+PiDCoCAyIGZp bGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggCj4+IGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZWcuaAo+PiBpbmRleCAyNThlODZlYjM3ZDUuLjQ1YWUwNWQwZmU3OCAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4+IEBAIC0yMzQ1LDcgKzIzNDUsMTMgQEAg ZW51bSBpOTE1X3Bvd2VyX3dlbGxfaWQgewo+PiDCoCAjZGVmaW5lIEJTRF9SSU5HX0JBU0XCoMKg wqDCoMKgwqDCoCAweDA0MDAwCj4+IMKgICNkZWZpbmUgR0VONl9CU0RfUklOR19CQVNFwqDCoMKg IDB4MTIwMDAKPj4gwqAgI2RlZmluZSBHRU44X0JTRDJfUklOR19CQVNFwqDCoMKgIDB4MWMwMDAK Pj4gKyNkZWZpbmUgR0VOMTFfQlNEX1JJTkdfQkFTRcKgwqDCoCAweDFjMDAwMAo+PiArI2RlZmlu ZSBHRU4xMV9CU0QyX1JJTkdfQkFTRcKgwqDCoCAweDFjNDAwMAo+PiArI2RlZmluZSBHRU4xMV9C U0QzX1JJTkdfQkFTRcKgwqDCoCAweDFkMDAwMAo+PiArI2RlZmluZSBHRU4xMV9CU0Q0X1JJTkdf QkFTRcKgwqDCoCAweDFkNDAwMAo+PiDCoCAjZGVmaW5lIFZFQk9YX1JJTkdfQkFTRcKgwqDCoMKg wqDCoMKgIDB4MWEwMDAKPj4gKyNkZWZpbmUgR0VOMTFfVkVCT1hfUklOR19CQVNFwqDCoMKgwqDC oMKgwqAgMHgxYzgwMDAKPj4gKyNkZWZpbmUgR0VOMTFfVkVCT1gyX1JJTkdfQkFTRcKgwqDCoMKg wqDCoMKgIDB4MWQ4MDAwCj4+IMKgICNkZWZpbmUgQkxUX1JJTkdfQkFTRcKgwqDCoMKgwqDCoMKg IDB4MjIwMDAKPj4gwqAgI2RlZmluZSBSSU5HX1RBSUwoYmFzZSnCoMKgwqDCoMKgwqDCoCBfTU1J TygoYmFzZSkrMHgzMCkKPj4gwqAgI2RlZmluZSBSSU5HX0hFQUQoYmFzZSnCoMKgwqDCoMKgwqDC oCBfTU1JTygoYmFzZSkrMHgzNCkKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2VuZ2luZV9jcy5jIAo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jCj4+IGluZGV4IDNlMTEwN2VjYjZlZS4uOTExZmMwODY1OGM1IDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+PiBAQCAtMTIzLDYgKzEyMywyMiBAQCBz dGF0aWMgY29uc3Qgc3RydWN0IGVuZ2luZV9pbmZvIGludGVsX2VuZ2luZXNbXSA9IHsKPj4gwqDC oMKgwqDCoMKgwqDCoMKgIC5tbWlvX2Jhc2UgPSBHRU44X0JTRDJfUklOR19CQVNFLAo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgLmlycV9zaGlmdCA9IEdFTjhfVkNTMl9JUlFfU0hJRlQsCj4+IMKgwqDC oMKgwqAgfSwKPj4gK8KgwqDCoCBbVkNTM10gPSB7Cj4+ICvCoMKgwqDCoMKgwqDCoCAuaHdfaWQg PSBWQ1MzX0hXLAo+PiArwqDCoMKgwqDCoMKgwqAgLnVhYmlfaWQgPSBJOTE1X0VYRUNfQlNELAo+ PiArwqDCoMKgwqDCoMKgwqAgLmNsYXNzID0gVklERU9fREVDT0RFX0NMQVNTLAo+PiArwqDCoMKg wqDCoMKgwqAgLmluc3RhbmNlID0gMiwKPj4gK8KgwqDCoMKgwqDCoMKgIC5tbWlvX2Jhc2UgPSBH RU4xMV9CU0QzX1JJTkdfQkFTRSwKPj4gK8KgwqDCoMKgwqDCoMKgIC5pcnFfc2hpZnQgPSAwLCAv KiBub3QgdXNlZCAqLwo+PiArwqDCoMKgIH0sCj4+ICvCoMKgwqAgW1ZDUzRdID0gewo+PiArwqDC oMKgwqDCoMKgwqAgLmh3X2lkID0gVkNTNF9IVywKPj4gK8KgwqDCoMKgwqDCoMKgIC51YWJpX2lk ID0gSTkxNV9FWEVDX0JTRCwKPj4gK8KgwqDCoMKgwqDCoMKgIC5jbGFzcyA9IFZJREVPX0RFQ09E RV9DTEFTUywKPj4gK8KgwqDCoMKgwqDCoMKgIC5pbnN0YW5jZSA9IDMsCj4+ICvCoMKgwqDCoMKg wqDCoCAubW1pb19iYXNlID0gR0VOMTFfQlNENF9SSU5HX0JBU0UsCj4+ICvCoMKgwqDCoMKgwqDC oCAuaXJxX3NoaWZ0ID0gMCwgLyogbm90IHVzZWQgKi8KPj4gK8KgwqDCoCB9LAo+PiDCoMKgwqDC oMKgIFtWRUNTXSA9IHsKPj4gwqDCoMKgwqDCoMKgwqDCoMKgIC5od19pZCA9IFZFQ1NfSFcsCj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCAudWFiaV9pZCA9IEk5MTVfRVhFQ19WRUJPWCwKPj4gQEAgLTEz MSw2ICsxNDcsMTQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBlbmdpbmVfaW5mbyBpbnRlbF9lbmdp bmVzW10gPSB7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCAubW1pb19iYXNlID0gVkVCT1hfUklOR19C QVNFLAo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgLmlycV9zaGlmdCA9IEdFTjhfVkVDU19JUlFfU0hJ RlQsCj4+IMKgwqDCoMKgwqAgfSwKPj4gK8KgwqDCoCBbVkVDUzJdID0gewo+PiArwqDCoMKgwqDC oMKgwqAgLmh3X2lkID0gVkVDUzJfSFcsCj4+ICvCoMKgwqDCoMKgwqDCoCAudWFiaV9pZCA9IEk5 MTVfRVhFQ19WRUJPWCwKPj4gK8KgwqDCoMKgwqDCoMKgIC5jbGFzcyA9IFZJREVPX0VOSEFOQ0VN RU5UX0NMQVNTLAo+PiArwqDCoMKgwqDCoMKgwqAgLmluc3RhbmNlID0gMSwKPj4gK8KgwqDCoMKg wqDCoMKgIC5tbWlvX2Jhc2UgPSBHRU4xMV9WRUJPWDJfUklOR19CQVNFLAo+PiArwqDCoMKgwqDC oMKgwqAgLmlycV9zaGlmdCA9IDAsIC8qIG5vdCB1c2VkICovCj4+ICvCoMKgwqAgfSwKPj4gwqAg fTsKPj4gwqAgLyoqCj4+IEBAIC0yMzAsNyArMjU0LDI1IEBAIGludGVsX2VuZ2luZV9zZXR1cChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAKPj4gKmRldl9wcml2LAo+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGNsYXNzX2luZm8tPm5hbWUsIGluZm8tPmluc3RhbmNlKSA+PQo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgc2l6ZW9mKGVuZ2luZS0+bmFtZSkpOwo+PiDCoMKgwqDCoMKgIGVuZ2lu ZS0+aHdfaWQgPSBlbmdpbmUtPmd1Y19pZCA9IGluZm8tPmh3X2lkOwo+PiAtwqDCoMKgIGVuZ2lu ZS0+bW1pb19iYXNlID0gaW5mby0+bW1pb19iYXNlOwo+PiArwqDCoMKgIGlmIChJTlRFTF9HRU4o ZGV2X3ByaXYpID49IDExKSB7Cj4+ICvCoMKgwqDCoMKgwqDCoCBzd2l0Y2ggKGVuZ2luZS0+aWQp IHsKPj4gK8KgwqDCoMKgwqDCoMKgIGNhc2UgVkNTOgo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBlbmdpbmUtPm1taW9fYmFzZSA9IEdFTjExX0JTRF9SSU5HX0JBU0U7Cj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGJyZWFrOwo+PiArwqDCoMKgwqDCoMKgwqAgY2FzZSBWQ1MyOgo+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBlbmdpbmUtPm1taW9fYmFzZSA9IEdFTjExX0JTRDJfUklOR19C QVNFOwo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBicmVhazsKPj4gK8KgwqDCoMKgwqDCoMKg IGNhc2UgVkVDUzoKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW5naW5lLT5tbWlvX2Jhc2Ug PSBHRU4xMV9WRUJPWF9SSU5HX0JBU0U7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFr Owo+PiArwqDCoMKgwqDCoMKgwqAgZGVmYXVsdDoKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg LyogdGFrZSB0aGUgb3JpZ2luYWwgdmFsdWUgZm9yIGFsbCBvdGhlciBlbmdpbmVzwqAgKi8KPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW5naW5lLT5tbWlvX2Jhc2UgPSBpbmZvLT5tbWlvX2Jh c2U7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOwo+PiArwqDCoMKgwqDCoMKgwqAg fQo+IAo+IEknbSBzbGlnaHRseSB1bmNvbnZpbmNlZCBieSB0aGUgZmFjdCB0aGF0IHdlIGhhdmUg YSBzdGF0aWMgdGFibGUgd2l0aCAKPiBzb21lIHZhbHVlcyBhbmQgdGhlbiB3ZSB1c2Ugb3RoZXIg dmFsdWVzIGhlcmUuIE1heWJlIHdlIGNvdWxkIGluc3RlYWQgCj4gdXNlIGFuZCBhcnJheSBvZiBb c3RhcnRpbmdfZ2VuLCBtbWlvX2Jhc2VdIHBhaXJzIGluIHRoZSB0YWJsZSBhbmQgZGVyaXZlIAo+ IHRoZSBjb3JyZWN0IHZhbHVlIGhlcmU/IEFueXdheSwgc2luY2UgdGhpcyBpcyBub3QgdGhlIG9u bHkgcGxhY2Ugd2hlcmUgCj4gd2UgZG9uJ3QgdXNlIHRoZSBtbWlvX2Jhc2UgdmFsdWUgZnJvbSB0 aGUgdGFibGUgKHNhbWUgaGFwcGVucyBmb3IgCj4gcHJlLWdlbjYgQlNEIGluIGludGVsX2luaXRf YnNkX3JpbmdfYnVmZmVyKSBJIGRvbid0IGNvbnNpZGVyIHRoaXMgYSAKPiBibG9ja2luZyBpc3N1 ZS4gQWxsIHRoZSB2YWx1ZXMgbWF0Y2ggdGhlIHNwZWNzLCBzbzoKPiAKPiBSZXZpZXdlZC1ieTog RGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4K PiAKPiBJJ2xsIHByb2JhYmx5IGNoZWNrIGhvdyB1c2luZyB0aGUgdGFibGUgSSBtZW50aW9uZWQg YWJvdmUgbG9va3MgbGlrZSAKPiBhZnRlciB0aGlzIGlzIG1lcmdlZCBhbmQgSSdsbCBzZW5kIGFu IFJGQyBpZiBpdCBzZWVtcyBuaWNlLgoKQWdyZWVkIGl0IGlzIGluZWxlZ2FudCB0byBkaXZlcmdl LiBZb3VyIGlkZWEgc291bmRzIHBvdGVudGlhbGx5IE9LLiBPciAKZXZlbiBqdXN0IGR1cGxpY2F0 ZSB0aGUgd2hvbGUgdGFibGUgZm9yIDwgZ2VuNiBhbmQgPj0gZ2VuMTEgLSB0aGV5IGFyZSAKbm90 IHRvbyBiaWcuCgpSZWdhcmRzLAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK