From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200AAC433EF for ; Fri, 3 Jun 2022 05:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240596AbiFCFeE (ORCPT ); Fri, 3 Jun 2022 01:34:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240705AbiFCFeE (ORCPT ); Fri, 3 Jun 2022 01:34:04 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B8B38DB6; Thu, 2 Jun 2022 22:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654234442; x=1685770442; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dsMVJcKJEcaeF8QAGuahkwXPqxSC4I8wQTrHBh2W82k=; b=aQk/nJQlSVQA9F0hHPsyA3DL/4VHyww1PUyrEavj/zfAfUgfu24SeCg2 OmHv/NXu+QS1bq/TaJS65LVG5XW2Aqz9b9O0caK+UX/Uw+1WiVBOA8JI5 3WGl8/drixLYjUU+2tuQ7bRTr3uJzghZTHjIT+7dI6UoBeUpb3KEYv2ga T+nWANYUv9mIwfjKmJQjxOXK6PhYsIckUDiggwybYrAkybORk1lUjIZ1k RlPCCNrMWO0lPMVPEuvCgmXEN3T35LwL4KrgUXKmeYs5tE5AjbD+E+6ZK I/OK4M8ESNuFbnGJpoNQlfBqjRwxw03xZWSJyO2isYL2a/d7f/cxbixHe w==; X-IronPort-AV: E=McAfee;i="6400,9594,10366"; a="263815475" X-IronPort-AV: E=Sophos;i="5.91,273,1647327600"; d="scan'208";a="263815475" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 22:33:55 -0700 X-IronPort-AV: E=Sophos;i="5.91,273,1647327600"; d="scan'208";a="607227864" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.54.219]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 22:33:50 -0700 Message-ID: Date: Fri, 3 Jun 2022 08:33:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH V1 1/2] mmc: core: Introduce new flag to force hardware reset Content-Language: en-US To: Sarthak Garg , ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_kamasali@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, Jens Axboe , Avri Altman , Chaitanya Kulkarni , =?UTF-8?Q?Christian_L=c3=b6hle?= , Bean Huo , Vincent Whitchurch , Dmitry Osipenko , Stephen Boyd References: <20220603051534.22672-1-quic_sartgarg@quicinc.com> <20220603051534.22672-2-quic_sartgarg@quicinc.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20220603051534.22672-2-quic_sartgarg@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/06/22 08:15, Sarthak Garg wrote: > Introduce new flag cqe_recovery_reset_always to allow vendors to force > hardware reset during cqe recovery. > > Signed-off-by: Sarthak Garg You should re-base on top of "mmc: block: Fix CQE recovery reset success" Also you may want to consider fixes / stable tags. Otherwise, for both patches: Acked-by: Adrian Hunter > --- > drivers/mmc/core/block.c | 2 +- > include/linux/mmc/host.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c > index 1259ca22d625..496cdd8a2999 100644 > --- a/drivers/mmc/core/block.c > +++ b/drivers/mmc/core/block.c > @@ -1497,7 +1497,7 @@ void mmc_blk_cqe_recovery(struct mmc_queue *mq) > pr_debug("%s: CQE recovery start\n", mmc_hostname(host)); > > err = mmc_cqe_recovery(host); > - if (err) > + if (err || host->cqe_recovery_reset_always) > mmc_blk_reset(mq->blkdata, host, MMC_BLK_CQE_RECOVERY); > else > mmc_blk_reset_success(mq->blkdata, MMC_BLK_CQE_RECOVERY); > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h > index c193c50ccd78..3e2fe950b4ec 100644 > --- a/include/linux/mmc/host.h > +++ b/include/linux/mmc/host.h > @@ -492,6 +492,7 @@ struct mmc_host { > int cqe_qdepth; > bool cqe_enabled; > bool cqe_on; > + bool cqe_recovery_reset_always; > > /* Inline encryption support */ > #ifdef CONFIG_MMC_CRYPTO