From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 285FEC19F2D for ; Tue, 9 Aug 2022 06:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232434AbiHIGIN (ORCPT ); Tue, 9 Aug 2022 02:08:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236105AbiHIGIL (ORCPT ); Tue, 9 Aug 2022 02:08:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03EBF175B8 for ; Mon, 8 Aug 2022 23:08:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9254D611CC for ; Tue, 9 Aug 2022 06:08:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4000C433C1; Tue, 9 Aug 2022 06:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660025289; bh=LqLpwe8o9hPrLZHTBSjxV3vkB+wAIFFMG+7BQFOMnhc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nUh3Wz47ADJSoHUpZwjPU7LC3QCNrtXX4cmMCxCCgUtpd/ffijF7St9fEvmXn/TR4 Xgf4bXrIvYSZYxam+PP6WdP2VOol14291/Id7IGfZyE4naGHH2/FWeFAapM5mLHAR0 eeKwR/qQ4Lmxfb/rm4fV9K8k10TUPDvWqdL7UWSU6oQjs4lzuz78N3yDid9z48h/Ec rPCRsgKGAitXZUbycae8A/PJd7x4PfvXOAx1bc5T3cQDQqrH1pQFigl0SP3cKMfxCP kwm0+qau8l8srjqJm7OHgh8p2MWP5e40G2f46rbCkUzv6xhdeTlaxsmfroNWgtCyL5 HLibvlzK1lJ0w== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oLIPP-001q80-Lj; Tue, 09 Aug 2022 07:08:07 +0100 MIME-Version: 1.0 Date: Tue, 09 Aug 2022 07:08:07 +0100 From: Marc Zyngier To: Zenghui Yu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, wanghaibin.wang@huawei.com, Shreyas K K Subject: Re: [PATCH] arm64: Fix match_list for erratum 1286807 on Arm Cortex-A76 In-Reply-To: <20220809043848.969-1-yuzenghui@huawei.com> References: <20220809043848.969-1-yuzenghui@huawei.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, wanghaibin.wang@huawei.com, quic_shrekk@quicinc.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-08-09 05:38, Zenghui Yu wrote: > Since commit 51f559d66527 ("arm64: Enable repeat tlbi workaround on > KRYO4XX > gold CPUs"), we failed to detect erratum 1286807 on Cortex-A76 because > its > entry in arm64_repeat_tlbi_list[] was accidently corrupted by this > commit. > > Fix this issue by creating a separate entry for Kryo4xx Gold. > > Fixes: 51f559d66527 ("arm64: Enable repeat tlbi workaround on KRYO4XX > gold CPUs") > Cc: Shreyas K K > Signed-off-by: Zenghui Yu > --- > arch/arm64/kernel/cpu_errata.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/cpu_errata.c > b/arch/arm64/kernel/cpu_errata.c > index 7e6289e709fc..0f7e9087d900 100644 > --- a/arch/arm64/kernel/cpu_errata.c > +++ b/arch/arm64/kernel/cpu_errata.c > @@ -208,6 +208,8 @@ static const struct arm64_cpu_capabilities > arm64_repeat_tlbi_list[] = { > #ifdef CONFIG_ARM64_ERRATUM_1286807 > { > ERRATA_MIDR_RANGE(MIDR_CORTEX_A76, 0, 0, 3, 0), > + }, > + { > /* Kryo4xx Gold (rcpe to rfpe) => (r0p0 to r3p0) */ > ERRATA_MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xe), > }, Ouch. It isn't the first time we end-up with this sort of thing, and I wonder whether we should restructure the ERRATA_MIDR_* macros to prevent this sort of accidental override... Anyway, thanks for spotting it! Cc: stable@vger.kernel.org Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1DD2C19F2D for ; Tue, 9 Aug 2022 06:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1mQgDHI4yEZtG/yiOzb90jFQaaYU4wnOdAY6GTCMU1E=; b=RtQCEVqxd9sLDQ47FJXVjwvH1O PvENjMe++6NhVMDPo4LNHhpEhV/wJOLpqGwkbTURyKTKZGFRLuNLZ0Cm/N48DKTyapLngxdFuAucm U3AfGAPOVClKQPcwTUacbPkT+0En1Ig7o7SjFSgZycVuWsbj2W0lvUC4jaRetDXu5JKDxSDuMFrwE Or6k5GeDPobplizUJeMznTmc1G+V3qXnYLk00LaxVAUqqM2rkPA0gk7hmSjMMBAxtJzE/o0rCYfrS f2AwSslcIzOMk6yqSytH3fPIv8Ju45OWfkS+cL66vdJ2MwrNudjec7ZjVikW+fncZRXHV/pJfEFHY gDBRzIoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLIPk-001nw3-Ok; Tue, 09 Aug 2022 06:08:28 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLIPb-001nrC-AJ for linux-arm-kernel@lists.infradead.org; Tue, 09 Aug 2022 06:08:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 88304CE12EB; Tue, 9 Aug 2022 06:08:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4000C433C1; Tue, 9 Aug 2022 06:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660025289; bh=LqLpwe8o9hPrLZHTBSjxV3vkB+wAIFFMG+7BQFOMnhc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nUh3Wz47ADJSoHUpZwjPU7LC3QCNrtXX4cmMCxCCgUtpd/ffijF7St9fEvmXn/TR4 Xgf4bXrIvYSZYxam+PP6WdP2VOol14291/Id7IGfZyE4naGHH2/FWeFAapM5mLHAR0 eeKwR/qQ4Lmxfb/rm4fV9K8k10TUPDvWqdL7UWSU6oQjs4lzuz78N3yDid9z48h/Ec rPCRsgKGAitXZUbycae8A/PJd7x4PfvXOAx1bc5T3cQDQqrH1pQFigl0SP3cKMfxCP kwm0+qau8l8srjqJm7OHgh8p2MWP5e40G2f46rbCkUzv6xhdeTlaxsmfroNWgtCyL5 HLibvlzK1lJ0w== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oLIPP-001q80-Lj; Tue, 09 Aug 2022 07:08:07 +0100 MIME-Version: 1.0 Date: Tue, 09 Aug 2022 07:08:07 +0100 From: Marc Zyngier To: Zenghui Yu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, wanghaibin.wang@huawei.com, Shreyas K K Subject: Re: [PATCH] arm64: Fix match_list for erratum 1286807 on Arm Cortex-A76 In-Reply-To: <20220809043848.969-1-yuzenghui@huawei.com> References: <20220809043848.969-1-yuzenghui@huawei.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, wanghaibin.wang@huawei.com, quic_shrekk@quicinc.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220808_230819_591387_2998477A X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-09 05:38, Zenghui Yu wrote: > Since commit 51f559d66527 ("arm64: Enable repeat tlbi workaround on > KRYO4XX > gold CPUs"), we failed to detect erratum 1286807 on Cortex-A76 because > its > entry in arm64_repeat_tlbi_list[] was accidently corrupted by this > commit. > > Fix this issue by creating a separate entry for Kryo4xx Gold. > > Fixes: 51f559d66527 ("arm64: Enable repeat tlbi workaround on KRYO4XX > gold CPUs") > Cc: Shreyas K K > Signed-off-by: Zenghui Yu > --- > arch/arm64/kernel/cpu_errata.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/cpu_errata.c > b/arch/arm64/kernel/cpu_errata.c > index 7e6289e709fc..0f7e9087d900 100644 > --- a/arch/arm64/kernel/cpu_errata.c > +++ b/arch/arm64/kernel/cpu_errata.c > @@ -208,6 +208,8 @@ static const struct arm64_cpu_capabilities > arm64_repeat_tlbi_list[] = { > #ifdef CONFIG_ARM64_ERRATUM_1286807 > { > ERRATA_MIDR_RANGE(MIDR_CORTEX_A76, 0, 0, 3, 0), > + }, > + { > /* Kryo4xx Gold (rcpe to rfpe) => (r0p0 to r3p0) */ > ERRATA_MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xe), > }, Ouch. It isn't the first time we end-up with this sort of thing, and I wonder whether we should restructure the ERRATA_MIDR_* macros to prevent this sort of accidental override... Anyway, thanks for spotting it! Cc: stable@vger.kernel.org Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel