All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<namhyung@kernel.org>, <irogers@google.com>,
	<kan.liang@linux.intel.com>, <linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf pmu: Fix event list for uncore PMUs
Date: Tue, 21 Dec 2021 09:10:37 +0000	[thread overview]
Message-ID: <bbf9c0b4-c048-3adf-5282-2355aa648acf@huawei.com> (raw)
In-Reply-To: <YcGJJ2g+i5qWea7d@krava>

On 21/12/2021 07:58, Jiri Olsa wrote:
>> +	/* Different names -> never duplicates */
>> +	if (strcmp(alias_a->name, alias_b->name))
>> +		return false;
>> +	if (!alias_a->pmu)
>> +		return true;
>> +	if (!alias_b->pmu)
>> +		return true;
> nit could be:
> 
> 	if (!alias_a->pmu || !alias_b->pmu)
> 		return true;
> 
> would be great to have more comments explaining the check
> 

This is just a sanity check that both strings are non-NULL as we do a 
strcmp() next. So would this be better:

if (!alias_a->pmu || !alias_b->pmu || !strcmp(alias_a->pmu, alias_b->pmu))
	return true

?

It will spill a line.

Thanks,
John

> thanks,
> jirka
> 
>> +	if (!strcmp(alias_a->pmu, alias_b->pmu))
>> +		return true;
>> +	/* uncore PMUs */



  reply	other threads:[~2021-12-21  9:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 15:53 [PATCH] perf pmu: Fix event list for uncore PMUs John Garry
2021-12-18  1:47 ` Arnaldo Carvalho de Melo
2021-12-20  8:38   ` John Garry
2021-12-20 16:34     ` Liang, Kan
2021-12-21  6:59       ` Xing Zhengjun
2021-12-21  7:58 ` Jiri Olsa
2021-12-21  9:10   ` John Garry [this message]
2021-12-21  9:35     ` Jiri Olsa
2021-12-21 10:14       ` John Garry
2021-12-21 20:48         ` Arnaldo Carvalho de Melo
2021-12-22 13:08           ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbf9c0b4-c048-3adf-5282-2355aa648acf@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.