From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05186C433E0 for ; Fri, 3 Jul 2020 10:11:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C35F420720 for ; Fri, 3 Jul 2020 10:11:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J5aiN8vL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C35F420720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrIfB-00035A-3L for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 06:11:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrIdC-0007jt-QK for qemu-devel@nongnu.org; Fri, 03 Jul 2020 06:09:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41217 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jrIdA-0006XX-T5 for qemu-devel@nongnu.org; Fri, 03 Jul 2020 06:09:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593770956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=OaWtRgR1S1eHUI5BGnFcbjpNfQPFMZHIivCkR3kAqEI=; b=J5aiN8vLcLV+0Ihx/h6K6pvfHGZd5CYazD3/x4qFbYrw+g2dqDTt1+BRWcxD50yhGcLyLa UNZlpFSnbdl/bCNykW0WGayawqFdFVMkl8oz2VKSMyi0+YMSIE1r6K89dZwaS/JRLvHl9z 4QWhplPCb+o63zstZ0DyCmF+cXv65Ng= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-HS91ShYdNEyHMmmdg4lu0w-1; Fri, 03 Jul 2020 06:09:14 -0400 X-MC-Unique: HS91ShYdNEyHMmmdg4lu0w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74A20100A68D; Fri, 3 Jul 2020 10:09:12 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-87.ams2.redhat.com [10.36.112.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6260370100; Fri, 3 Jul 2020 10:09:10 +0000 (UTC) Subject: Re: [PATCH 1/1] disas: mips: Add Loongson 2F disassembler To: Stefan Brankovic , Stefan Brankovic , qemu-devel@nongnu.org References: <20200702194230.10769-1-stefan.brankovic@syrmia.com> <20200702194230.10769-2-stefan.brankovic@syrmia.com> <59e559c7-d763-cee0-8eb7-7201d6586833@redhat.com> <9f3e8408-3e8c-86ca-989a-a373f9656493@syrmia.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: Date: Fri, 3 Jul 2020 12:09:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <9f3e8408-3e8c-86ca-989a-a373f9656493@syrmia.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 03:38:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chenhc@lemote.com, aleksandar.qemu.devel@gmail.com, aleksandar.rikalo@syrmia.com, Markus Armbruster , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/07/2020 11.49, Stefan Brankovic wrote: > > On 3.7.20. 09:59, Thomas Huth wrote: >> On 02/07/2020 21.42, Stefan Brankovic wrote: >>> Add disassembler for Loongson 2F instruction set. >>> >>> Testing is done by comparing qemu disassembly output, obtained by >>> using -d in_asm command line option, with appropriate objdump output. >>> >>> Signed-off-by: Stefan Brankovic >>> --- >>>   MAINTAINERS             |    1 + >>>   configure               |    1 + >>>   disas/Makefile.objs     |    1 + >>>   disas/loongson2f.cpp    | 8134 +++++++++++++++++++++++++++++++++++++++ >>>   disas/loongson2f.h      | 2542 ++++++++++++ >>>   include/disas/dis-asm.h |    1 + >>>   include/exec/poison.h   |    1 + >>>   target/mips/cpu.c       |    4 + >>>   8 files changed, 10685 insertions(+) >>>   create mode 100644 disas/loongson2f.cpp >>>   create mode 100644 disas/loongson2f.h >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 3abe3faa4e..913ed2a6d3 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -219,6 +219,7 @@ S: Maintained >>>   F: target/mips/ >>>   F: default-configs/*mips* >>>   F: disas/*mips* >>> +F: disas/loongson* >>>   F: docs/system/cpu-models-mips.rst.inc >>>   F: hw/intc/mips_gic.c >>>   F: hw/mips/ >>> diff --git a/configure b/configure >>> index 597e909b53..e163dac53e 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -8102,6 +8102,7 @@ for i in $ARCH $TARGET_BASE_ARCH ; do >>>       disas_config "MIPS" >>>       if test -n "${cxx}"; then >>>         disas_config "NANOMIPS" >>> +      disas_config "LOONGSON2F" >>>       fi >>>     ;; >>>     moxie*) >>> diff --git a/disas/Makefile.objs b/disas/Makefile.objs >>> index 3c1cdce026..0d5ee1e038 100644 >>> --- a/disas/Makefile.objs >>> +++ b/disas/Makefile.objs >>> @@ -14,6 +14,7 @@ common-obj-$(CONFIG_I386_DIS) += i386.o >>>   common-obj-$(CONFIG_M68K_DIS) += m68k.o >>>   common-obj-$(CONFIG_MICROBLAZE_DIS) += microblaze.o >>>   common-obj-$(CONFIG_MIPS_DIS) += mips.o >>> +common-obj-$(CONFIG_LOONGSON2F_DIS) += loongson2f.o >>>   common-obj-$(CONFIG_NANOMIPS_DIS) += nanomips.o >>>   common-obj-$(CONFIG_NIOS2_DIS) += nios2.o >>>   common-obj-$(CONFIG_MOXIE_DIS) += moxie.o >>> diff --git a/disas/loongson2f.cpp b/disas/loongson2f.cpp >>> new file mode 100644 >>> index 0000000000..a2f32dcf93 >>> --- /dev/null >>> +++ b/disas/loongson2f.cpp >>> @@ -0,0 +1,8134 @@ >> >> This file (and the header) lack a proper header comment. Which license >> do you want to use for this code? Who wrote the initial implementation? > I will add proper license comments in v2. I will use GPL2+ license. > Thanks for reminding. This is the initial implementation, and I am the > author. >> >> Also, unless you've copied the code from another project that uses >> C++, why did you use C++ here? > This is disassembler is written as a generic disassembler that can be > integrated into other projects. In this case, it is integrated into > QEMU. One of initial key requirements was that it uses C++ as its > language. Ok, fair, but please mention that rationale in the commit description when you send v2. Thanks, Thomas