All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Nyekjaer <sean@geanix.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	dmurphy@ti.com, linux-can@vger.kernel.org
Cc: martin@geanix.com, stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] can: m_can: tcan4x5x: put the device out of standby before register access
Date: Wed, 11 Dec 2019 10:13:07 +0100	[thread overview]
Message-ID: <bc0014ec-7302-97f4-5d71-8d029b0fb1fb@geanix.com> (raw)
In-Reply-To: <8b1682ad-c291-252e-c768-63a7a4801aff@pengutronix.de>



On 11/12/2019 09.42, Marc Kleine-Budde wrote:
> On 12/11/19 7:42 AM, Sean Nyekjaer wrote:
>> The m_can tries to detect if Non ISO Operation is available while in standby,
>> this function results in the following error:
>>
>> tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module
>> tcan4x5x spi2.0: m_can device registered (irq=84, version=32)
>> tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized.
>>
>> When the tcan device comes out of reset it comes out in standby mode.
>> The m_can driver tries to access the control register but fails due to
>> the device is in standby mode.
>> So this patch will put the tcan device in normal mode before the m_can
>> driver does the initialization.
>>
>> Fixes: a229abeed7f7 ("can: tcan4x5x: Turn on the power before parsing the config")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> 
> Applied both to linux-can.
> 

Oh, the commit id for "can: tcan4x5x: Turn on the power before parsing 
the config" have changed, since this morning :)

The new commit is 0d38aa7d1090

Thanks
/Sean

  reply	other threads:[~2019-12-11  9:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  6:42 [PATCH v3 1/2] can: m_can: tcan4x5x: put the device out of standby before register access Sean Nyekjaer
2019-12-11  8:42 ` Marc Kleine-Budde
2019-12-11  9:13   ` Sean Nyekjaer [this message]
2019-12-11  9:44     ` Marc Kleine-Budde
2019-12-11 11:28       ` Sean Nyekjaer
2019-12-11 12:10         ` Marc Kleine-Budde
2019-12-11 12:15           ` Sean Nyekjaer
2019-12-11 12:35             ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc0014ec-7302-97f4-5d71-8d029b0fb1fb@geanix.com \
    --to=sean@geanix.com \
    --cc=dmurphy@ti.com \
    --cc=linux-can@vger.kernel.org \
    --cc=martin@geanix.com \
    --cc=mkl@pengutronix.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.