All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Huang, ZhiminX" <zhiminx.huang@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Xu, Ting" <ting.xu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration
Date: Thu, 24 Dec 2020 09:33:04 +0000	[thread overview]
Message-ID: <bc05a2f5e9de4c6abdb5ac794e09b52b@intel.com> (raw)
In-Reply-To: <20201223052936.7200-1-alvinx.zhang@intel.com>

Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>

Regards,
HuangZhiMin


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> Sent: Wednesday, December 23, 2020 1:30 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Check if there are enough queue pairs currently allocated, and if not, request
> PF to allocate them.
> 
> Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index
> 7e3c26a..f015121 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off {
>  	} else {
>  		/* Check if large VF is already enabled. If so, disable and
>  		 * release redundant queue resource.
> +		 * Or check if enough queue pairs. If not, request them from PF.
>  		 */
> -		if (vf->lv_enabled) {
> +		if (vf->lv_enabled ||
> +		    num_queue_pairs > vf->vsi_res->num_queue_pairs) {
>  			ret = iavf_queues_req_reset(dev, num_queue_pairs);
>  			if (ret)
>  				return ret;
> --
> 1.8.3.1


  parent reply	other threads:[~2020-12-24  9:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  5:29 [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration Zhang,Alvin
2020-12-23  6:06 ` Xu, Ting
2020-12-23  6:28   ` Zhang, AlvinX
2020-12-24  9:33 ` Huang, ZhiminX [this message]
2020-12-28 10:56 ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc05a2f5e9de4c6abdb5ac794e09b52b@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=ting.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.