Re: [PATCH -next] staging: media: tegra-vde: add missing error return code in tegra_vde_probe()

From: Dmitry Osipenko <digetx@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-tegra@vger.kernel.org, linux-media@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH -next] staging: media: tegra-vde: add missing error return code in tegra_vde_probe()
Date: Sat, 22 May 2021 17:16:52 +0300	[thread overview]
Message-ID: <bc08636a-8f0f-772c-7df0-ec6459cc205d@gmail.com> (raw)
In-Reply-To: <20210522031911.129361-1-yangyingliang@huawei.com>

22.05.2021 06:19, Yang Yingliang пишет:
> Add missing return error code when pm_runtime_resume_and_get() failed.
> 
> Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/staging/media/tegra-vde/vde.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c
> index e025b69776f2..ed4c1250b303 100644
> --- a/drivers/staging/media/tegra-vde/vde.c
> +++ b/drivers/staging/media/tegra-vde/vde.c
> @@ -1071,7 +1071,8 @@ static int tegra_vde_probe(struct platform_device *pdev)
>  	 * power-cycle it in order to put hardware into a predictable lower
>  	 * power state.
>  	 */
> -	if (pm_runtime_resume_and_get(dev) < 0)
> +	err = pm_runtime_resume_and_get(dev);
> +	if (err)
>  		goto err_pm_runtime;
>  
>  	pm_runtime_put(dev);
> 

Hello Yang,

Thank you for the patch. The problem was already reported by Dan
Carpenter to the original patch, apparently Mauro missed it.

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>