From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Date: Fri, 05 Dec 2014 17:08:21 +0000 Subject: Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic Message-Id: List-Id: References: <1417137993-8337-1-git-send-email-soren.brinkmann@xilinx.com> <1417137993-8337-8-git-send-email-soren.brinkmann@xilinx.com> <1417766393.22963.9.camel@mm-sol.com> In-Reply-To: <1417766393.22963.9.camel@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On Fri, 2014-12-05 at 09:59AM +0200, Ivan T. Ivanov wrote: >=20 > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > >=20 > > static const struct pinconf_ops pmic_gpio_pinconf_ops =3D { > > + .is_generic=3D true, > > .pin_config_group_get=3D pmic_gpio_config_get, > > .pin_config_group_set=3D pmic_gpio_config_set, > > .pin_config_group_dbg_show=3D pmic_gpio_config_dbg_show, > > @@ -848,6 +742,9 @@ static int pmic_gpio_probe(struct platform_device *= pdev) > > pctrldesc->name =3D dev_name(dev); > > pctrldesc->pins =3D pindesc; > > pctrldesc->npins =3D npins; > > + pctrldesc->num_dt_params =3D ARRAY_SIZE(pmic_gpio_bindings); > > + pctrldesc->params =3D pmic_gpio_bindings; > > + pctrldesc->conf_items =3D pmic_conf_items; > >=20 >=20 > What will happen if number of conf_items is less than number of params? I suppose bad things :) You're right, that should probably be checked somewhere. Let me see whether I find a good place to put such a check. Thanks, S=C3=B6ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbaLERJF (ORCPT ); Fri, 5 Dec 2014 12:09:05 -0500 Received: from mail-bn1bon0056.outbound.protection.outlook.com ([157.56.111.56]:3712 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751172AbaLERJD (ORCPT ); Fri, 5 Dec 2014 12:09:03 -0500 Date: Fri, 5 Dec 2014 09:08:21 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: "Ivan T. Ivanov" CC: Linus Walleij , Michal Simek , , , Alessandro Rubini , Heiko Stuebner , Laurent Pinchart , , , Bjorn Andersson , Beniamino Galvani Subject: Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic References: <1417137993-8337-1-git-send-email-soren.brinkmann@xilinx.com> <1417137993-8337-8-git-send-email-soren.brinkmann@xilinx.com> <1417766393.22963.9.camel@mm-sol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1417766393.22963.9.camel@mm-sol.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21152.001 X-TM-AS-User-Approved-Sender: Yes;Yes Message-ID: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(189002)(164054003)(377424004)(51704005)(24454002)(199003)(64706001)(47776003)(20776003)(85202003)(110136001)(99396003)(106466001)(6806004)(85182001)(87936001)(120916001)(104016003)(83506001)(92566001)(53416004)(86362001)(76176999)(50986999)(54356999)(4396001)(107046002)(23676002)(46102003)(230783001)(108616004)(21056001)(92726002)(31966008)(50466002)(77156002)(62966003)(74316001)(41533002)(107986001)(24736002)(23106004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB017;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB017; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB017; X-Forefront-PRVS: 04163EF38A Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=soren.brinkmann@xilinx.com; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB017; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB016; X-OriginatorOrg: xilinx.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-12-05 at 09:59AM +0200, Ivan T. Ivanov wrote: > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > > static const struct pinconf_ops pmic_gpio_pinconf_ops = { > > + .is_generic= true, > > .pin_config_group_get= pmic_gpio_config_get, > > .pin_config_group_set= pmic_gpio_config_set, > > .pin_config_group_dbg_show= pmic_gpio_config_dbg_show, > > @@ -848,6 +742,9 @@ static int pmic_gpio_probe(struct platform_device *pdev) > > pctrldesc->name = dev_name(dev); > > pctrldesc->pins = pindesc; > > pctrldesc->npins = npins; > > + pctrldesc->num_dt_params = ARRAY_SIZE(pmic_gpio_bindings); > > + pctrldesc->params = pmic_gpio_bindings; > > + pctrldesc->conf_items = pmic_conf_items; > > > > What will happen if number of conf_items is less than number of params? I suppose bad things :) You're right, that should probably be checked somewhere. Let me see whether I find a good place to put such a check. Thanks, Sören From mboxrd@z Thu Jan 1 00:00:00 1970 From: soren.brinkmann@xilinx.com (=?utf-8?B?U8O2cmVu?= Brinkmann) Date: Fri, 5 Dec 2014 09:08:21 -0800 Subject: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic In-Reply-To: <1417766393.22963.9.camel@mm-sol.com> References: <1417137993-8337-1-git-send-email-soren.brinkmann@xilinx.com> <1417137993-8337-8-git-send-email-soren.brinkmann@xilinx.com> <1417766393.22963.9.camel@mm-sol.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2014-12-05 at 09:59AM +0200, Ivan T. Ivanov wrote: > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > > static const struct pinconf_ops pmic_gpio_pinconf_ops = { > > + .is_generic= true, > > .pin_config_group_get= pmic_gpio_config_get, > > .pin_config_group_set= pmic_gpio_config_set, > > .pin_config_group_dbg_show= pmic_gpio_config_dbg_show, > > @@ -848,6 +742,9 @@ static int pmic_gpio_probe(struct platform_device *pdev) > > pctrldesc->name = dev_name(dev); > > pctrldesc->pins = pindesc; > > pctrldesc->npins = npins; > > + pctrldesc->num_dt_params = ARRAY_SIZE(pmic_gpio_bindings); > > + pctrldesc->params = pmic_gpio_bindings; > > + pctrldesc->conf_items = pmic_conf_items; > > > > What will happen if number of conf_items is less than number of params? I suppose bad things :) You're right, that should probably be checked somewhere. Let me see whether I find a good place to put such a check. Thanks, S?ren