Hi Am 14.06.19 um 22:35 schrieb Daniel Vetter: > We're kinda going in the wrong direction. Spotted while typing better > gem/prime docs. > > Cc: Thomas Zimmermann > Cc: Gerd Hoffmann > Cc: Rob Herring > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index b4a76c2703e5..23583f0e3755 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -228,6 +228,10 @@ struct drm_gem_object_funcs > GEM objects can now have a function table instead of having the callbacks on the > DRM driver struct. This is now the preferred way and drivers can be moved over. > > +Unfortunately some of the recently added GEM helpers are going in the wrong > +direction by adding OPS macros that use the old, deprecated hooks. See > +DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS, and DRM_GEM_VRAM_DRIVER_PRIME. There's currently only bochs using DRM_GEM_VRAM_DRIVER_PRIME. Best regards Thomas > + > Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate > --------------------------------------------------------- > > -- Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)