From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8F95C433F5 for ; Tue, 22 Mar 2022 12:03:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 74FB283A34; Tue, 22 Mar 2022 13:03:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="qGxC3Izj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3AABB80F68; Tue, 22 Mar 2022 13:03:19 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B899B83AFF for ; Tue, 22 Mar 2022 13:03:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 7E1E022205; Tue, 22 Mar 2022 13:03:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1647950594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vn9hu7F8wmNX+TFY6iZqpNjeWu/EPHm/AzWz+oYT++Y=; b=qGxC3IzjCMUCy/RCz3fDo/K8HSjUjY3RZ1hUfZ/DkVdH7FGdihxYtIEs9Io5eXdwHACJEB wBiNfSMaqTCwwMJnKH3S/NKUO/Uz8GUhZ+bjlhWMj/HV5rH82nW5V1St9czjfS5M48vbj3 riRSDgA+zY/ay+LUqPMPEI21FC7c55s= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 22 Mar 2022 13:03:12 +0100 From: Michael Walle To: Andre Przywara Cc: Jim Liu , sr@denx.de, priyanka.jain@nxp.com, sjg@chromium.org, samuel@sholland.org, xypron.glpk@gmx.de, JJLIU0@nuvoton.com, rasmus.villemoes@prevas.dk, judge.packham@gmail.com, pali@kernel.org, kettenis@openbsd.org, KWLIU@nuvoton.com, YSCHU@nuvoton.com, sven@svenpeter.dev, u-boot@lists.denx.de Subject: Re: [PATCH v7] wdt: nuvoton: Add support for Nuvoton In-Reply-To: <20220322105419.57e737d5@slackpad.lan> References: <20220322091953.22701-1-JJLIU0@nuvoton.com> <20220322105419.57e737d5@slackpad.lan> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Am 2022-03-22 11:54, schrieb Andre Przywara: > On Tue, 22 Mar 2022 17:19:53 +0800 > Jim Liu wrote: > > Hi, > >> Add watchdog controller driver for NPCM7xx/npcm8xx > > So this is now the same as v4, with both compatible strings listed. > Which *might* be right, but my question still stands: > > Is the 845 watchdog compatible to the 740 version? Does the current > Linux driver work? > > If yes (and your driver suggests so, because you treat the two > compatible strings the same), then you would not need to list both *in > the driver*, but just do so in the .dts file. > > So the driver just matches "nuvoton,npcm750-wdt" (as does the Linux > driver), the nuvoton-common-npcm7xx.dtsi stays the same, but in the > npcm845.dtsi you write: > watchdog: watchdog@xxx { > compatible = "nuvoton,npcm845-wdt", > "nuvoton,npcm750-wdt"; > interrupts = ... > ... > }; > > This way you don't need to change the (Linux) driver, and get away with > one compatible string, for both devices. Ahh didn't noticed that there are different compatible strings in the linux kernel driver. And even > compatible = "nuvoton,npcm845-wdt", > "nuvoton,npcm750-wdt"; would be undocumented if it is not upstreamed to linux. > So can you please confirm that both are compatible. I couldn't find any > information on that. > > Please just don't send another patch without answering the question ;-) I'd suggest to convert the binding to yaml format so it is unambiguous what is supported and what isn't. -michael