From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A26C7C43460 for ; Thu, 22 Apr 2021 10:46:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BAFC613D8 for ; Thu, 22 Apr 2021 10:46:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235796AbhDVKrW (ORCPT ); Thu, 22 Apr 2021 06:47:22 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59782 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235455AbhDVKrW (ORCPT ); Thu, 22 Apr 2021 06:47:22 -0400 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lZWr9-00068R-3r for linux-crypto@vger.kernel.org; Thu, 22 Apr 2021 10:46:47 +0000 Received: by mail-wr1-f72.google.com with SMTP id t18-20020adfdc120000b02900ffe4432d8bso13662416wri.6 for ; Thu, 22 Apr 2021 03:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ChgsWVHouphJpIEvBcUP4TDV1Lb1Y7MqOzirYiGZuls=; b=DBezJGxR4Alx1Q9z7XDieZk7RWm19q0dSLbbaKvoCh01USJEFboniTsKRe2X9Ew1kA YT/7oyMlcn/+w+64a6aRSB9R7n3k3hfXeTbhWlySepnTijq2WHoaoT/IZK2HXCpqnhLx ZPtcfDnye0Jw0dxsO5RALGyyAbmogkKGn6CqhVCrzg/Vfpfi8g5op0mzLIQ/B44ZIrU4 0QDNcoVXKVkt4ZEqAbLaRXbod7NZ8S07iuqTyN85TRG6/Rg1fHuGqH2oRg514A7LpCgw NguDoN6fiyVLOBQwyefnYzOaXQTFozqI5XFTQ4w12XjLJKwzxP2c5SPS0+rfbPKko5+t AdAw== X-Gm-Message-State: AOAM532Ds2NBBHbunp9q5A3hGrj4jR5W2MRtnGXZXYRnQBuaWEy2ATsd l4v1WI/QnB92obcn0JzAQBz8VhFDw+6A1U5RvL5K5Bj6vZh1E0nF+tXaaRXKGyUDJ884pUbPsLm e982ZMkqxiyo6EWCjpRHFlNZDEyIgqx5MI+W6EK6BCA== X-Received: by 2002:a7b:c454:: with SMTP id l20mr14904423wmi.65.1619088406323; Thu, 22 Apr 2021 03:46:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwriIvSyixOuWHVrmtzdeZk8A0gu9EIEm+2/cX2GME4GssfKx9dIbuacbeZx9u7Rg6czj93yA== X-Received: by 2002:a7b:c454:: with SMTP id l20mr14904416wmi.65.1619088406202; Thu, 22 Apr 2021 03:46:46 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id h17sm2936241wru.67.2021.04.22.03.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 03:46:44 -0700 (PDT) Subject: Re: [PATCH v2] hwrng: exynos - Fix runtime PM imbalance on error To: =?UTF-8?Q?=c5=81ukasz_Stelmach?= , Matt Mackall , Herbert Xu , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?Q?Bart=c5=82omiej_=c5=bbolnierkiewicz?= , Marek Szyprowski References: <20210422104141.17668-1-l.stelmach@samsung.com> From: Krzysztof Kozlowski Message-ID: Date: Thu, 22 Apr 2021 12:46:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210422104141.17668-1-l.stelmach@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 22/04/2021 12:41, Łukasz Stelmach wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. It's exactly the same as Dinghao's patch: https://lore.kernel.org/linux-samsung-soc/20200522011659.26727-1-dinghao.liu@zju.edu.cn/ which you reviewed. It has even the same commit msg (although it's difficult to be creative here). I think it's better to resend his patch instead. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE24C433ED for ; Thu, 22 Apr 2021 10:48:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A25460720 for ; Thu, 22 Apr 2021 10:48:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A25460720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=amoCTYsXx6BNBeEVTzJKn5DRpfO/JUpjH+ngqp2R7Eo=; b=B6DI995KHRgwYZm9MqqcJWh22 jdqWkUQFXFiiDZf5JirwAgkPZf8xKCXkWXDu+MVyNl+YOULpIpAqe8Sro9IUw7PvcRarb9Qru7ntp vdxaQptfFAEYkJn1g5pqW/F24AURilDnA2kS60NFThoIlgsUly0BSJz5l+TLzrBB5jvQSnVThnoxV a9uIsmbD6NA4H5rAzzX2Cp0HUgOQ/LPU4t0s+xcQvIJGYTdfeqgD60SOlB4uCBpgqJ91EAEFHO+Vb WLC50gLN53WdOlAL5Tu8kE/fHqRvG8TC884ciTjmJAINfji118jJFGzSdJ2Ia12Gwy1Zn0rwaEJ7R tKlNKW4RA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZWrI-00GW9h-Ox; Thu, 22 Apr 2021 10:46:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZWrF-00GW9K-UT for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 10:46:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=ChgsWVHouphJpIEvBcUP4TDV1Lb1Y7MqOzirYiGZuls=; b=GUiDE8s23Uw3q6Zg4mlkLGbwGC YsaP/MAV+P09a/dw8Xff/TN82ixFlMcbFanzo0RvuvmCyn3ZoFKfgRrM4jJ041NW4sdGGpI9c2hAe 4XzhCWFNDwjmkAubujl7ZtzgyuBgvQfiBCXyWergXxwcDHvKwYLkNuEfWSkGqOfewsdNIr0ZpK4et MUvT8CKAT73EDKMzIPjlO8xJQiCUZ0wpmD2F7ssjvjCPfFiCJ4KprjuSRsAQzFeQwwYXQ5P6fabNc TNxl92nfHLkV1ODWHQpuK/0efulPRrCW4qibK9Xbh7l6vlTG+ncLq++AQuYPGbeHdPOhBIKOKPtpf bNNnh41g==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZWrD-00DadX-2l for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 10:46:52 +0000 Received: from mail-wr1-f71.google.com ([209.85.221.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lZWr8-00068A-Ig for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 10:46:46 +0000 Received: by mail-wr1-f71.google.com with SMTP id j72-20020adf914e0000b02901073cdd9d65so4089556wrj.0 for ; Thu, 22 Apr 2021 03:46:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ChgsWVHouphJpIEvBcUP4TDV1Lb1Y7MqOzirYiGZuls=; b=ZkMJq300vxZqKBxLKufARgyNEDCxJwfwuF2nCj2x7qYGtZn33x3G9Kk3KgFOeFiwdi 9WhPFnnHsHTQ7K44ygyTc7VZd67fIW7A4aw41C3WwuGm5ZH7JD2vqRdlvCcXhOXmpybe Z26j3uwGrf64TyU+xbZgLAl3uBaWL/zfDxjVBXL2k13x4EW/jZz+tU0b9m2yDCMG8W51 +FSO76AMCnqsjIRYdiXpvddlT2uRhF/cayepNSeRfKYsuKO2WCxW67iNIvSdJHqFWmGO YlWakYQtX0L3ABO5wtg75m4TXZfIsnH5OWIGQLQp0sdkGX21IcHJkHjFpI6MJy7Wn33E ++LQ== X-Gm-Message-State: AOAM530i/PJLjazWQ19XpA6DSEI4MSmJtFOJCWKT+ZX1imCnd6/dFQ+8 v8owdNfhFTXWVK3e0hIwb/7GQanq7qQ0RrZRYApJLu+BeiCSJPTLbCXNysXJx6C3u9/E/4DhMGr Nmb/VLVgnGadhRrNIsRkk7wD8xy17AJOE2HeK9aNcnXQ57ShaBL9f X-Received: by 2002:a7b:c454:: with SMTP id l20mr14904425wmi.65.1619088406323; Thu, 22 Apr 2021 03:46:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwriIvSyixOuWHVrmtzdeZk8A0gu9EIEm+2/cX2GME4GssfKx9dIbuacbeZx9u7Rg6czj93yA== X-Received: by 2002:a7b:c454:: with SMTP id l20mr14904416wmi.65.1619088406202; Thu, 22 Apr 2021 03:46:46 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id h17sm2936241wru.67.2021.04.22.03.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 03:46:44 -0700 (PDT) Subject: Re: [PATCH v2] hwrng: exynos - Fix runtime PM imbalance on error To: =?UTF-8?Q?=c5=81ukasz_Stelmach?= , Matt Mackall , Herbert Xu , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?Q?Bart=c5=82omiej_=c5=bbolnierkiewicz?= , Marek Szyprowski References: <20210422104141.17668-1-l.stelmach@samsung.com> From: Krzysztof Kozlowski Message-ID: Date: Thu, 22 Apr 2021 12:46:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210422104141.17668-1-l.stelmach@samsung.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_034651_277871_BCC981E6 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjIvMDQvMjAyMSAxMjo0MSwgxYF1a2FzeiBTdGVsbWFjaCB3cm90ZToKPiBwbV9ydW50aW1l X2dldF9zeW5jKCkgaW5jcmVtZW50cyB0aGUgcnVudGltZSBQTSB1c2FnZSBjb3VudGVyIGV2ZW4K PiB0aGUgY2FsbCByZXR1cm5zIGFuIGVycm9yIGNvZGUuIFRodXMgYSBwYWlyaW5nIGRlY3JlbWVu dCBpcyBuZWVkZWQKPiBvbiB0aGUgZXJyb3IgaGFuZGxpbmcgcGF0aCB0byBrZWVwIHRoZSBjb3Vu dGVyIGJhbGFuY2VkLgoKSXQncyBleGFjdGx5IHRoZSBzYW1lIGFzIERpbmdoYW8ncyBwYXRjaDoK aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtc2Ftc3VuZy1zb2MvMjAyMDA1MjIwMTE2NTku MjY3MjctMS1kaW5naGFvLmxpdUB6anUuZWR1LmNuLwp3aGljaCB5b3UgcmV2aWV3ZWQuIEl0IGhh cyBldmVuIHRoZSBzYW1lIGNvbW1pdCBtc2cKKGFsdGhvdWdoIGl0J3MgZGlmZmljdWx0IHRvIGJl IGNyZWF0aXZlIGhlcmUpLgoKSSB0aGluayBpdCdzIGJldHRlciB0byByZXNlbmQgaGlzIHBhdGNo IGluc3RlYWQuCgoKCkJlc3QgcmVnYXJkcywKS3J6eXN6dG9mCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==