From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470A0C433E0 for ; Sun, 10 Jan 2021 16:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17FB122B2C for ; Sun, 10 Jan 2021 16:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbhAJQ4f (ORCPT ); Sun, 10 Jan 2021 11:56:35 -0500 Received: from honk.sigxcpu.org ([24.134.29.49]:35348 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbhAJQ4f (ORCPT ); Sun, 10 Jan 2021 11:56:35 -0500 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id DB287FB03; Sun, 10 Jan 2021 17:55:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZM3TsJHU2O_u; Sun, 10 Jan 2021 17:55:51 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 3C0AD40885; Sun, 10 Jan 2021 17:55:51 +0100 (CET) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Dong Aisheng , Anson Huang , Krzysztof Kozlowski , Shengjiu Wang , =?UTF-8?q?Guido=20G=C3=BCnther?= , Philipp Zabel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] arm64: dts: imx8mq: Add clock parents for mipi dphy Date: Sun, 10 Jan 2021 17:55:51 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This makes sure the clock tree setup for the dphy is not dependent on other components. Without this change bringing up the display can fail like kernel: phy phy-30a00300.dphy.2: Invalid CM/CN/CO values: 165/217/1 kernel: phy phy-30a00300.dphy.2: for hs_clk/ref_clk=451656000/593999998 ~ 165/217 if LCDIF doesn't set up that part of the clock tree first. This was noticed when testing the Librem 5 devkit with defconfig. It doesn't happen when modules are built in. Signed-off-by: Guido Günther --- Changes from v1: - as per review comment from Shawn Guo https://lore.kernel.org/linux-arm-kernel/20210110124629.GO28365@dragon/ Set clock rate for IMX8MQ_VIDEO_PLL1 too. Otherwise we end up with a close but not exact clock rate. arch/arm64/boot/dts/freescale/imx8mq.dtsi | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index a841a023e8e0..50ae17f65a51 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -1016,9 +1016,14 @@ dphy: dphy@30a00300 { reg = <0x30a00300 0x100>; clocks = <&clk IMX8MQ_CLK_DSI_PHY_REF>; clock-names = "phy_ref"; - assigned-clocks = <&clk IMX8MQ_CLK_DSI_PHY_REF>; - assigned-clock-parents = <&clk IMX8MQ_VIDEO_PLL1_OUT>; - assigned-clock-rates = <24000000>; + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>, + <&clk IMX8MQ_VIDEO_PLL1_BYPASS>, + <&clk IMX8MQ_CLK_DSI_PHY_REF>, + <&clk IMX8MQ_VIDEO_PLL1>; + assigned-clock-parents = <&clk IMX8MQ_CLK_25M>, + <&clk IMX8MQ_VIDEO_PLL1>, + <&clk IMX8MQ_VIDEO_PLL1_OUT>; + assigned-clock-rates = <0>, <0>, <24000000>, <594000000>; #phy-cells = <0>; power-domains = <&pgc_mipi>; status = "disabled"; -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC6F8C433DB for ; Sun, 10 Jan 2021 16:57:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 639FF22B2C for ; Sun, 10 Jan 2021 16:57:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 639FF22B2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=9a7Wlsu5PSA8ETmxEam1nYMj7MCPtlbXhnToGPPDaz8=; b=cRU4qMbjjwwr5RPKI2YIbPEMUB kSGEry08n4/62hTgzwfHiBsQ7wSCu9zdgpJS7mKYVa9JiNn1/9k3janFdIU1+64Dw0WcxWXRIF+Du YxZapd4KndciAp2HdX7pgAqW2HjZJ3aozqXRYgHERyYlb0b2d2TLLCgvUY8aJxOaeG3EKwOFA0otA vDjh4MWBHXj5iB88pTjjfqSMWh0U8K/kMKQpjFK6X1+ZniE0VXB6JceGpZg4xBZeGUeuZDMR3e9BP yv4d4LdESA0WtkVPYNA+4I5JYVF3460sFB02ZheAnLvfe+zpKV97AiJ0QjeRtAnE9c2CzB0nLeSwx F7bjP8gg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kye0V-00056W-JB; Sun, 10 Jan 2021 16:55:59 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kye0R-000555-18 for linux-arm-kernel@lists.infradead.org; Sun, 10 Jan 2021 16:55:56 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id DB287FB03; Sun, 10 Jan 2021 17:55:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZM3TsJHU2O_u; Sun, 10 Jan 2021 17:55:51 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 3C0AD40885; Sun, 10 Jan 2021 17:55:51 +0100 (CET) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Dong Aisheng , Anson Huang , Krzysztof Kozlowski , Shengjiu Wang , =?UTF-8?q?Guido=20G=C3=BCnther?= , Philipp Zabel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] arm64: dts: imx8mq: Add clock parents for mipi dphy Date: Sun, 10 Jan 2021 17:55:51 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210110_115555_231595_A7F623EB X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhpcyBtYWtlcyBzdXJlIHRoZSBjbG9jayB0cmVlIHNldHVwIGZvciB0aGUgZHBoeSBpcyBub3Qg ZGVwZW5kZW50IG9uCm90aGVyIGNvbXBvbmVudHMuCgpXaXRob3V0IHRoaXMgY2hhbmdlIGJyaW5n aW5nIHVwIHRoZSBkaXNwbGF5IGNhbiBmYWlsIGxpa2UKCiAga2VybmVsOiBwaHkgcGh5LTMwYTAw MzAwLmRwaHkuMjogSW52YWxpZCBDTS9DTi9DTyB2YWx1ZXM6IDE2NS8yMTcvMQogIGtlcm5lbDog cGh5IHBoeS0zMGEwMDMwMC5kcGh5LjI6IGZvciBoc19jbGsvcmVmX2Nsaz00NTE2NTYwMDAvNTkz OTk5OTk4IH4gMTY1LzIxNwoKaWYgTENESUYgZG9lc24ndCBzZXQgdXAgdGhhdCBwYXJ0IG9mIHRo ZSBjbG9jayB0cmVlIGZpcnN0LiBUaGlzIHdhcwpub3RpY2VkIHdoZW4gdGVzdGluZyB0aGUgTGli cmVtIDUgZGV2a2l0IHdpdGggZGVmY29uZmlnLiBJdCBkb2Vzbid0CmhhcHBlbiB3aGVuIG1vZHVs ZXMgYXJlIGJ1aWx0IGluLgoKU2lnbmVkLW9mZi1ieTogR3VpZG8gR8O8bnRoZXIgPGFneEBzaWd4 Y3B1Lm9yZz4KCi0tLQpDaGFuZ2VzIGZyb20gdjE6Ci0gYXMgcGVyIHJldmlldyBjb21tZW50IGZy b20gU2hhd24gR3VvCiAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC8y MDIxMDExMDEyNDYyOS5HTzI4MzY1QGRyYWdvbi8KICBTZXQgY2xvY2sgcmF0ZSBmb3IgSU1YOE1R X1ZJREVPX1BMTDEgdG9vLiBPdGhlcndpc2Ugd2UgZW5kIHVwIHdpdGgKICBhIGNsb3NlIGJ1dCBu b3QgZXhhY3QgY2xvY2sgcmF0ZS4KCiBhcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9pbXg4 bXEuZHRzaSB8IDExICsrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNj YWxlL2lteDhtcS5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvaW14OG1xLmR0 c2kKaW5kZXggYTg0MWEwMjNlOGUwLi41MGFlMTdmNjVhNTEgMTAwNjQ0Ci0tLSBhL2FyY2gvYXJt NjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtcS5kdHNpCisrKyBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvZnJlZXNjYWxlL2lteDhtcS5kdHNpCkBAIC0xMDE2LDkgKzEwMTYsMTQgQEAgZHBoeTogZHBo eUAzMGEwMDMwMCB7CiAJCQkJcmVnID0gPDB4MzBhMDAzMDAgMHgxMDA+OwogCQkJCWNsb2NrcyA9 IDwmY2xrIElNWDhNUV9DTEtfRFNJX1BIWV9SRUY+OwogCQkJCWNsb2NrLW5hbWVzID0gInBoeV9y ZWYiOwotCQkJCWFzc2lnbmVkLWNsb2NrcyA9IDwmY2xrIElNWDhNUV9DTEtfRFNJX1BIWV9SRUY+ OwotCQkJCWFzc2lnbmVkLWNsb2NrLXBhcmVudHMgPSA8JmNsayBJTVg4TVFfVklERU9fUExMMV9P VVQ+OwotCQkJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDI0MDAwMDAwPjsKKwkJCQlhc3NpZ25l ZC1jbG9ja3MgPSA8JmNsayBJTVg4TVFfVklERU9fUExMMV9SRUZfU0VMPiwKKwkJCQkJCSAgPCZj bGsgSU1YOE1RX1ZJREVPX1BMTDFfQllQQVNTPiwKKwkJCQkJCSAgPCZjbGsgSU1YOE1RX0NMS19E U0lfUEhZX1JFRj4sCisJCQkJCQkgIDwmY2xrIElNWDhNUV9WSURFT19QTEwxPjsKKwkJCQlhc3Np Z25lZC1jbG9jay1wYXJlbnRzID0gPCZjbGsgSU1YOE1RX0NMS18yNU0+LAorCQkJCQkJICA8JmNs ayBJTVg4TVFfVklERU9fUExMMT4sCisJCQkJCQkgIDwmY2xrIElNWDhNUV9WSURFT19QTEwxX09V VD47CisJCQkJYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8MD4sIDwwPiwgPDI0MDAwMDAwPiwgPDU5 NDAwMDAwMD47CiAJCQkJI3BoeS1jZWxscyA9IDwwPjsKIAkJCQlwb3dlci1kb21haW5zID0gPCZw Z2NfbWlwaT47CiAJCQkJc3RhdHVzID0gImRpc2FibGVkIjsKLS0gCjIuMjkuMgoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK