Re: [PATCHv3 2/2] ath10k: Allow setting coverage class

From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: Adrian Chadd <adrian@freebsd.org>, Ben Greear <greearb@candelatech.com>
Cc: Simon Wunderlich <sw@simonwunderlich.de>,
	Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>,
	Benjamin Berg <benjamin@sipsolutions.net>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Michal Kazior <michal.kazior@tieto.com>,
	Mathias Kretschmer <mathias.kretschmer@fit.fraunhofer.de>
Subject: Re: [PATCHv3 2/2] ath10k: Allow setting coverage class
Date: Mon, 16 Oct 2017 21:10:10 +0200	[thread overview]
Message-ID: <bc32a99f-ad4a-8892-b827-b49a3a08a200@dd-wrt.com> (raw)
In-Reply-To: <CAJ-VmomSzvwOLfG_D1BCyfxQDWP3wwMZeN4VxXSD826eYc2AYg@mail.gmail.com>

Am 16.10.2017 um 19:59 schrieb Adrian Chadd:
> On 16 October 2017 at 10:57, Ben Greear <greearb@candelatech.com> wrote:
>> On 08/25/2016 06:25 AM, Benjamin Berg wrote:
>>> Unfortunately ath10k does not generally allow modifying the coverage class
>>> with the stock firmware and Qualcomm has so far refused to implement this
>>> feature so that it can be properly supported in ath10k. If we however know
>>> the registers that need to be modified for proper operation with a higher
>>> coverage class, then we can do these modifications from the driver.
>>>
>>> This patch implements this hack for first generation cards which are based
>>> on a core that is similar to ath9k. The registers are modified in place
>>> and
>>> need to be re-written every time the firmware sets them. To achieve this
>>> the register status is verified after certain WMI events from the
>>> firmware.
>>>
>>> The coverage class may not be modified temporarily right after the card
>>> re-initializes the registers. This is for example the case during
>>> scanning.
>>>
>>> Thanks to Sebastian Gottschall <s.gottschall@dd-wrt.com> for initially
>>> working on a userspace support for this. This patch wouldn't have been
>>> possible without this documentation.
>>
>> Hello,
>>
>> Do you happen to know the maximum distance that can work with this
>> patch enabled?  The register value maximum seems to be 0x3FFF, but I
>> am not sure of the units (nor how exactly that applies to distance).
> It's in MAC clocks still, right? So it depends on how fast the MAC
> clock timer runs.
>
>
>
> -adrian

if someone is interested i can provide a patch witch works as well for 
998x and 9984 and usually other newer chipsets too.

but clock parameters need to be adjusted for these newer ones. the only 
problem is that its based on unoffical registers which arent documented 
and the patch for the 99xx chipsets is very different from 988x

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k