[PATCH net-next 0/2] net: phy: improve genphy_read_status

[PATCH net-next 0/2] net: phy: improve genphy_read_status

[Heiner Kallweit]

Series includes two smaller improvements to genphy_read_status.

Heiner Kallweit (2):
  net: phy: remove orphaned register read in genphy_read_status
  net: phy: don't use 10BaseT/half as default in genphy_read_status

 drivers/net/phy/phy_device.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

-- 
2.20.1

[PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status

[Heiner Kallweit]

After recent changes to genphy_read_status() this orphaned register
read remained as leftover. So remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/phy_device.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 7e71124bb..803197fdd 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1785,10 +1785,6 @@ int genphy_read_status(struct phy_device *phydev)
 
 		mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa);
 
-		adv = phy_read(phydev, MII_ADVERTISE);
-		if (adv < 0)
-			return adv;
-
 		phydev->speed = SPEED_10;
 		phydev->duplex = DUPLEX_HALF;
 		phydev->pause = 0;
-- 
2.20.1

[PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default in genphy_read_status

[Heiner Kallweit]

If link partner and we can't agree on any mode, then it doesn't make
sense to pretend we would have agreed on 10/half. Therefore set a
proper default.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/phy_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 803197fdd..4bb3b6c28 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1785,8 +1785,8 @@ int genphy_read_status(struct phy_device *phydev)
 
 		mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa);
 
-		phydev->speed = SPEED_10;
-		phydev->duplex = DUPLEX_HALF;
+		phydev->speed = SPEED_UNKNOWN;
+		phydev->duplex = DUPLEX_UNKNOWN;
 		phydev->pause = 0;
 		phydev->asym_pause = 0;
 
-- 
2.20.1

Re: [PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default in genphy_read_status

[Florian Fainelli]

On 2/18/2019 11:29 AM, Heiner Kallweit wrote:
> If link partner and we can't agree on any mode, then it doesn't make
> sense to pretend we would have agreed on 10/half. Therefore set a
> proper default.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next 0/2] net: phy: improve genphy_read_status

[David Miller]

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 18 Feb 2019 20:28:04 +0100

> Series includes two smaller improvements to genphy_read_status.

Series applied.