From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG2p0-0004Zg-2K for qemu-devel@nongnu.org; Tue, 08 May 2018 09:38:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG2ov-0004KF-Vj for qemu-devel@nongnu.org; Tue, 08 May 2018 09:38:26 -0400 References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-5-git-send-email-mst@redhat.com> <20180508152349.15ad26d0.cohuck@redhat.com> From: Thomas Huth Message-ID: Date: Tue, 8 May 2018 15:38:03 +0200 MIME-Version: 1.0 In-Reply-To: <20180508152349.15ad26d0.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, kwolf@redhat.com, peter.maydell@linaro.org, Alexander Graf , Christian Borntraeger , qemu-s390x@nongnu.org, David Hildenbrand On 08.05.2018 15:23, Cornelia Huck wrote: > On Fri, 4 May 2018 02:24:12 +0200 > Thomas Huth wrote: > >> On 03.05.2018 21:50, Michael S. Tsirkin wrote: >>> we just need a struct name, let's add a forward >>> declaration instead of an include. >>> >>> Signed-off-by: Michael S. Tsirkin >>> --- >>> include/hw/s390x/sclp.h | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h >>> index f9db243..6e65150 100644 >>> --- a/include/hw/s390x/sclp.h >>> +++ b/include/hw/s390x/sclp.h >>> @@ -16,7 +16,8 @@ >>> >>> #include "hw/sysbus.h" >>> #include "hw/qdev.h" >>> -#include "target/s390x/cpu-qom.h" >>> + >>> +typedef struct CPUS390XState CPUS390XState; >> >> IIRC you have to use include/qemu/typedefs.h instead to avoid trouble >> with older versions of GCC. > > Hm, I'm wondering why we do the typedef in cpu-qom.h, while other > architectures do it in their cpu.h. See: commit ef2974cc270d51959ce90df6b4d4d41635d7a603 Author: David Hildenbrand Date: Wed Sep 13 15:24:02 2017 +0200 target/s390x: move some s390x typedefs to cpu-qom.h This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and prepares for using cpu-qom.h as a s390 specific version of typedefs.h Signed-off-by: David Hildenbrand Message-Id: <20170913132417.24384-8-david@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Thomas