All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Ricardo Ribalda <ribalda@chromium.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH 6/9] media: sum4i-csi: Do not zero reserved fields
Date: Tue, 12 Jan 2021 11:10:29 +0000	[thread overview]
Message-ID: <bc3f9c21-26d7-a459-280f-6f5cef180d6a@ideasonboard.com> (raw)
In-Reply-To: <20210111145445.28854-7-ribalda@chromium.org>

Hi Ricardo,

Well I've started, so I may as well finish and do the rest too.

On 11/01/2021 14:54, Ricardo Ribalda wrote:
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").

Indeed, these are the only memsets here ...

With the $TITLE fixed as spotted by Ezequiel,

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> 
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
> index 1a2f65d83a6c..4785faddf630 100644
> --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
> +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
> @@ -113,8 +113,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi,
>  	pix->num_planes = _fmt->num_planes;
>  	pix->pixelformat = _fmt->fourcc;
>  
> -	memset(pix->reserved, 0, sizeof(pix->reserved));
> -
>  	/* Align the width and height on the subsampling */
>  	width = ALIGN(pix->width, _fmt->hsub);
>  	height = ALIGN(pix->height, _fmt->vsub);
> @@ -131,8 +129,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi,
>  		bpl = pix->width / hsub * _fmt->bpp[i] / 8;
>  		pix->plane_fmt[i].bytesperline = bpl;
>  		pix->plane_fmt[i].sizeimage = bpl * pix->height / vsub;
> -		memset(pix->plane_fmt[i].reserved, 0,
> -		       sizeof(pix->plane_fmt[i].reserved));
>  	}
>  }
>  
> 


  parent reply	other threads:[~2021-01-12 11:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 14:54 [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields Ricardo Ribalda
2021-01-11 14:54 ` [PATCH] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:59   ` Kieran Bingham
2021-01-12 12:14     ` Ricardo Ribalda
2021-01-11 14:54 ` [PATCH 2/9] media: mtk-mdp: " Ricardo Ribalda
2021-01-12 12:01   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 3/9] media: mtk-vcodec: " Ricardo Ribalda
2021-01-12 12:09   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 4/9] media: fdp1: " Ricardo Ribalda
2021-01-12 10:58   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 5/9] media: jpu: " Ricardo Ribalda
2021-01-12 11:07   ` Kieran Bingham
2021-01-21  9:53     ` Hans Verkuil
2021-01-11 14:54 ` [PATCH 6/9] media: sum4i-csi: " Ricardo Ribalda
2021-01-11 18:11   ` Ezequiel Garcia
2021-01-12 11:10   ` Kieran Bingham [this message]
2021-01-11 14:54 ` [PATCH 7/9] media: ti-vpe: " Ricardo Ribalda
2021-01-12 11:12   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 8/9] media: vicodec: " Ricardo Ribalda
2021-01-12 11:44   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 9/9] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:55   ` Kieran Bingham
2021-01-12 11:58 ` [PATCH 1/9] media: ipu3-cio2: " Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc3f9c21-26d7-a459-280f-6f5cef180d6a@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=ribalda@chromium.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.