From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233AbdDLIIi (ORCPT ); Wed, 12 Apr 2017 04:08:38 -0400 Received: from foss.arm.com ([217.140.101.70]:41054 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbdDLIIf (ORCPT ); Wed, 12 Apr 2017 04:08:35 -0400 Subject: Re: [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge To: Mason , Thomas Gleixner References: <91db1f47-3024-9712-309a-fb4b21e42028@free.fr> <310db9dd-7db6-2106-2e53-f0083b2d3758@free.fr> <012f7fcb-eaeb-70dd-a1a9-06c213789d30@arm.com> <0502e180-5517-12d6-e3a1-bcea0da7e201@free.fr> <4edd799a-650c-0189-cd5c-e9fc18c5f8bc@arm.com> <30f662a6-5dab-515b-e35a-a312f3c7b509@free.fr> <5f81730d-fbe3-1f4c-de34-09bbfb893ee1@arm.com> <2b5eef4c-32f2-54f1-ca2f-f9426e68fb2c@free.fr> <67014006-a380-9e3b-c9af-a421052cb8e0@arm.com> Cc: Bjorn Helgaas , Robin Murphy , Lorenzo Pieralisi , Liviu Dudau , David Laight , linux-pci , Linux ARM , Thibaud Cornic , Phuong Nguyen , LKML From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Wed, 12 Apr 2017 09:08:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/17 18:52, Mason wrote: > On 11/04/2017 18:43, Marc Zyngier wrote: > >> On 11/04/17 17:26, Mason wrote: >> >>> Is there a function to map virq to the hwirq in any domain? >> >> Be more precise. If you want the hwirq associated with the view of a >> virq in a given domain, that's the hwirq field in the corresponding >> irq_data structure. Or are you after something else? > > I registered an unmask method for my irq_chip. > (IIUC, I'm supposed to unmask a specific MSI in this callback.) > > # cat /proc/interrupts > CPU0 CPU1 > 30: 0 0 MSIfoo 0 Edge aerdrv > 34: 0 0 MSIfoo 524288 Edge xhci_hcd > 35: 0 0 MSIfoo 524289 Edge xhci_hcd > 36: 0 0 MSIfoo 524290 Edge xhci_hcd > > > void foo_unmask(struct irq_data *data) > { > int xx,yy; > struct irq_domain *dom = data->domain; > printk("%s: irq_data=%p irq=%u hwirq=%lu chip=%p dom=%p pdata=%p data=%p\n", > __func__, data, data->irq, data->hwirq, data->chip, data->domain, > data->parent_data, data->chip_data); > printk("%s ops=%p data=%p parent=%p\n\n", > dom->name, dom->ops, dom->host_data, dom->parent); > printk("pcie=%p\n", dom->parent->host_data); > //dump_stack(); > pci_msi_unmask_irq(data); > struct tango_pcie *pcie = data->domain->parent->host_data; > printk("\n%s: pcie=%p irq=%u hwirq=%lu\n\n", > __func__, pcie, data->irq, data->hwirq); > xx = irq_find_mapping(pcie->irq_domain, data->hwirq); > yy = irq_find_mapping(pcie->msi_domain, data->hwirq); Do you realize that hwirq is *per domain*, and only makes sense to *one* irqchip? What you've written here doesn't make any sense. > printk("xx=%d yy=%d\n", xx, yy); > } > > so data->irq is the virq (30, 34, 35, 36) > and data->hwirq is the domain hwirq (0, 524288, 524289, 524290) > > Is there a way to map hwirq 524288 to MSI 0, hwirq 524289 to MSI 1, etc? Why would you need to do such a thing? - In MSI domain: IRQ34 -> hwirq 524288 - In foo domain: IRQ34 -> hwirq [whatever your driver has allocated] The data is already there, at your fingertips. Just deal with with your "foo" irqchip. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Wed, 12 Apr 2017 09:08:31 +0100 Subject: [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge In-Reply-To: References: <91db1f47-3024-9712-309a-fb4b21e42028@free.fr> <310db9dd-7db6-2106-2e53-f0083b2d3758@free.fr> <012f7fcb-eaeb-70dd-a1a9-06c213789d30@arm.com> <0502e180-5517-12d6-e3a1-bcea0da7e201@free.fr> <4edd799a-650c-0189-cd5c-e9fc18c5f8bc@arm.com> <30f662a6-5dab-515b-e35a-a312f3c7b509@free.fr> <5f81730d-fbe3-1f4c-de34-09bbfb893ee1@arm.com> <2b5eef4c-32f2-54f1-ca2f-f9426e68fb2c@free.fr> <67014006-a380-9e3b-c9af-a421052cb8e0@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/04/17 18:52, Mason wrote: > On 11/04/2017 18:43, Marc Zyngier wrote: > >> On 11/04/17 17:26, Mason wrote: >> >>> Is there a function to map virq to the hwirq in any domain? >> >> Be more precise. If you want the hwirq associated with the view of a >> virq in a given domain, that's the hwirq field in the corresponding >> irq_data structure. Or are you after something else? > > I registered an unmask method for my irq_chip. > (IIUC, I'm supposed to unmask a specific MSI in this callback.) > > # cat /proc/interrupts > CPU0 CPU1 > 30: 0 0 MSIfoo 0 Edge aerdrv > 34: 0 0 MSIfoo 524288 Edge xhci_hcd > 35: 0 0 MSIfoo 524289 Edge xhci_hcd > 36: 0 0 MSIfoo 524290 Edge xhci_hcd > > > void foo_unmask(struct irq_data *data) > { > int xx,yy; > struct irq_domain *dom = data->domain; > printk("%s: irq_data=%p irq=%u hwirq=%lu chip=%p dom=%p pdata=%p data=%p\n", > __func__, data, data->irq, data->hwirq, data->chip, data->domain, > data->parent_data, data->chip_data); > printk("%s ops=%p data=%p parent=%p\n\n", > dom->name, dom->ops, dom->host_data, dom->parent); > printk("pcie=%p\n", dom->parent->host_data); > //dump_stack(); > pci_msi_unmask_irq(data); > struct tango_pcie *pcie = data->domain->parent->host_data; > printk("\n%s: pcie=%p irq=%u hwirq=%lu\n\n", > __func__, pcie, data->irq, data->hwirq); > xx = irq_find_mapping(pcie->irq_domain, data->hwirq); > yy = irq_find_mapping(pcie->msi_domain, data->hwirq); Do you realize that hwirq is *per domain*, and only makes sense to *one* irqchip? What you've written here doesn't make any sense. > printk("xx=%d yy=%d\n", xx, yy); > } > > so data->irq is the virq (30, 34, 35, 36) > and data->hwirq is the domain hwirq (0, 524288, 524289, 524290) > > Is there a way to map hwirq 524288 to MSI 0, hwirq 524289 to MSI 1, etc? Why would you need to do such a thing? - In MSI domain: IRQ34 -> hwirq 524288 - In foo domain: IRQ34 -> hwirq [whatever your driver has allocated] The data is already there, at your fingertips. Just deal with with your "foo" irqchip. M. -- Jazz is not dead. It just smells funny...