All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: pxa2xx-pcm and dma_request
Date: Wed, 13 May 2009 08:43:05 +0400	[thread overview]
Message-ID: <bc64b4640905122143o76b5ebccm7b9f40e8b2577f7c@mail.gmail.com> (raw)
In-Reply-To: <87vdo6c9pt.fsf@free.fr>

2009/5/13 Robert Jarzmik <robert.jarzmik@free.fr>:
> Hi Mark and Dimitry,
>
> I've been playing for some time with DMA on the PXA series. I was wondering if
> the behaviour of pxa2xx-pcm is correct.
>
> As far as I understand, in an asoc context, the __pxa2xx_pcm_open() is called,
> while in "arm context", pxa2xx_pcm_open() is called, which calls
> __pxa2xx_pcm_open().
>
> This was introduced by commit a6d77317678148c973bb0131cc5a3a772f756d23 I think.
>
> One main difference is that in "arm context", pxa_dma_request() is called, while
> in "asoc context", it is not.

This was done by intent as before code merge plain ARM driver used DMA while
ASoC didn't. That was done mainly because I didn't have all the hw
variants (only
pxa255 at hand) and didn't want to introduce any points of possible failure.
Now merging DMA code into generic code path would be a nice feature though.

> I'd like one of you to cross-check, as I must admit I'm not following all the
> impacts of the pcm code split-up.

The initial impact of the merge should be void, as it was an
_unification_ of code
presented in ASoC and non-ASoC drivers.

-- 
With best wishes
Dmitry

      parent reply	other threads:[~2009-05-13  4:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12 21:06 pxa2xx-pcm and dma_request Robert Jarzmik
2009-05-12 22:06 ` Mark Brown
2009-05-13  4:43 ` Dmitry Eremin-Solenikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc64b4640905122143o76b5ebccm7b9f40e8b2577f7c@mail.gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.