From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16098C6FA83 for ; Tue, 27 Sep 2022 14:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232564AbiI0O31 (ORCPT ); Tue, 27 Sep 2022 10:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232584AbiI0O3I (ORCPT ); Tue, 27 Sep 2022 10:29:08 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 641DD18B481 for ; Tue, 27 Sep 2022 07:28:59 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id k10so15997201lfm.4 for ; Tue, 27 Sep 2022 07:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=t/zPAMSAQWX7Jp2Kkrznx3pd8BaYj/V4IovrZOP0p7CA9dHLcTpMosv+TEf82eIdQN ZzPiXw9rKlWK7dgrb/2R9JIb8zq9h17dOUBhdV7CLo6ItGSkQYBffOF2Ou5wtqP2NA3T N9rEoP+h50jfo80xq4j1r3mCJzXfyYlWLZNzw2x5BGe+XyxiWRwC+2x4+yiqv6IzriEM fuXrcHsauWPdkNwTqAUt31tFVgYpbwvnD8NThfc3Z4YxzLdIRb1JExpoeuZAlbZVjurb kbFPPAxHbGw01+RTl5nssKqglXejrUk6qW39J2Eas+i02imuJL8VJjhw11y61M81MWAG 3WYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=chCUlEqeiZk58vD7Br2yM6k7gHFZypCNdzfrn75cE1Jh5C3TxBnk9njT4iWrB7H5yZ HwBM7DFLwrXWWpeXUZR2KOwszkkabKb9AN9yIvfFTX3t+GO+2msYkYMSiHprq6aZVZuQ W5vvJKJfCGzJbsQXHXldyTmRaBV8Bv/OQjkBy/HUVP5Bg/DdVpA7hgur9R4EGzbsXRD5 8oC2Wxilks7b8rDLOGnw0FyrnfxHE25DJPQF/gX9lrPSXzdFIgs1NHlVcrqOhK/inbYP hW/4lzNN6dd5Cn4Jn5DYSws7RWJxVNLFUpJq3XrV927akHTHwvMJYsPJh22+RcZxbYeK c8CA== X-Gm-Message-State: ACrzQf06Z+u9L22jF0BQLbSYUEFpqXr5ZDjKEo1HgucUJlYBfuJkTuLQ 9A2uVEcCnMZRi+2DvxhrZnZj3A== X-Google-Smtp-Source: AMsMyM53dC3y7erBKfzBQ+Nze0zZtnLF71JT4J25PfiX1YCvYNVOBA7+2R4vFWpiZCxVk3PBax4BpA== X-Received: by 2002:a05:6512:308f:b0:49a:5a59:aa25 with SMTP id z15-20020a056512308f00b0049a5a59aa25mr10629204lfd.44.1664288937219; Tue, 27 Sep 2022 07:28:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q12-20020ac25a0c000000b00494a1b242dasm182416lfn.14.2022.09.27.07.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:28:55 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 16:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/09/2022 15:04, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dpi support to enable the HDMI path. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> index 72049a530ae1..27f029ca760b 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>> .data = (void *)MTK_DPI }, >>> { .compatible = "mediatek,mt8192-dpi", >>> .data = (void *)MTK_DPI }, >>> + { .compatible = "mediatek,mt8195-dpi", >>> + .data = (void *)MTK_DPI }, >> >> It's compatible with the others. You don't need more compatibles. > > Hi Krzysztof, > > It's a bit confusing, because this compatible is used in both > mtk_drm_drv.c and in mtk_dpi.c > > Albeit it's entirely the same thing regarding the mtk_drm_drv module, > it's pretty different > regarding the mtk_dpi module. Sure, but this does not explain why do you need these entries here in mtk_drm_drv. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECB5AC54EE9 for ; Tue, 27 Sep 2022 14:29:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA87310E370; Tue, 27 Sep 2022 14:29:02 +0000 (UTC) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC7A010E36B for ; Tue, 27 Sep 2022 14:28:58 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id 10so16017355lfy.5 for ; Tue, 27 Sep 2022 07:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=t/zPAMSAQWX7Jp2Kkrznx3pd8BaYj/V4IovrZOP0p7CA9dHLcTpMosv+TEf82eIdQN ZzPiXw9rKlWK7dgrb/2R9JIb8zq9h17dOUBhdV7CLo6ItGSkQYBffOF2Ou5wtqP2NA3T N9rEoP+h50jfo80xq4j1r3mCJzXfyYlWLZNzw2x5BGe+XyxiWRwC+2x4+yiqv6IzriEM fuXrcHsauWPdkNwTqAUt31tFVgYpbwvnD8NThfc3Z4YxzLdIRb1JExpoeuZAlbZVjurb kbFPPAxHbGw01+RTl5nssKqglXejrUk6qW39J2Eas+i02imuJL8VJjhw11y61M81MWAG 3WYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=TltYPzfmW7bhsxFCFMI7OX8xJK3T80GC/Wcdrg0uINRYbQ4iH2iPERWofeaqerdyoH TaKzJZPjPc+hNFDhuYEpKxBuqMxGJlvRBu+d9JL+xl68OgwIHN+RW+tgUN9LwDmL28Bt dYhXvZzWKAsZxwMwuKIIL43asZCXVnc0FHM+wZsXwHIxsbLDqVgjWTBUiSTag2kSvMzg C0IrwP5T6+pEC9/DA57U3O9/PW4j+3iIe2a0pUgnTWBLxCVPF8j6Y34Ej44DLKYcMCyc a4E1+NlcOC+MkXbOrxladY8OGClZ6soOi7LkrwosJ/9jIYxJRChyMP83469obY7N7VUB svxw== X-Gm-Message-State: ACrzQf3ZQcmqlYVWNqcTb0WJISQDs9umvMrnNn3nfZV8IIkByAhrF+ND x/TQ7e18eUJrwVXkqwg6DzKfZw== X-Google-Smtp-Source: AMsMyM53dC3y7erBKfzBQ+Nze0zZtnLF71JT4J25PfiX1YCvYNVOBA7+2R4vFWpiZCxVk3PBax4BpA== X-Received: by 2002:a05:6512:308f:b0:49a:5a59:aa25 with SMTP id z15-20020a056512308f00b0049a5a59aa25mr10629204lfd.44.1664288937219; Tue, 27 Sep 2022 07:28:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q12-20020ac25a0c000000b00494a1b242dasm182416lfn.14.2022.09.27.07.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:28:55 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 16:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 27/09/2022 15:04, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dpi support to enable the HDMI path. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> index 72049a530ae1..27f029ca760b 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>> .data = (void *)MTK_DPI }, >>> { .compatible = "mediatek,mt8192-dpi", >>> .data = (void *)MTK_DPI }, >>> + { .compatible = "mediatek,mt8195-dpi", >>> + .data = (void *)MTK_DPI }, >> >> It's compatible with the others. You don't need more compatibles. > > Hi Krzysztof, > > It's a bit confusing, because this compatible is used in both > mtk_drm_drv.c and in mtk_dpi.c > > Albeit it's entirely the same thing regarding the mtk_drm_drv module, > it's pretty different > regarding the mtk_dpi module. Sure, but this does not explain why do you need these entries here in mtk_drm_drv. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2483AC6FA83 for ; Tue, 27 Sep 2022 14:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g7p+4lcwXzQ9yMsNLL0wtDw7D/GNAYxWAOeXY/diFz8=; b=lsghIAjKQ/qn2k 6Ny5R8YYxsin1Me7OE4mp3dqzEGoJVCtILJH+/8cxwQc6CA7zE/uvREryuS5I301R5nXqPZNVMDzN 5hPeomKcskupedT0FVFwGYuT6jRaEzj/KZeqiel8vctlT+9T2G94tddcWju+xMogS6b8c++hnh27/ UCBCzDwS+35T9wHVOwPTOmzcEmp3xGXAkd/0Urj84kVMhpjmvQNkMRHyRPU96xByilgS9h5TJRen4 U1U8FzXtVlbjXezipCjwImvh4zrcNjaXlmltayG8JGA/wDNfCLNO8B74a1pBku0qqKdOkrGNKB+GA mYkM4w1k5IzturNcCC7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odBa5-00BEvV-Fw; Tue, 27 Sep 2022 14:29:05 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odBa0-00BEsG-66 for linux-phy@lists.infradead.org; Tue, 27 Sep 2022 14:29:02 +0000 Received: by mail-lf1-x12a.google.com with SMTP id a3so15962220lfk.9 for ; Tue, 27 Sep 2022 07:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=t/zPAMSAQWX7Jp2Kkrznx3pd8BaYj/V4IovrZOP0p7CA9dHLcTpMosv+TEf82eIdQN ZzPiXw9rKlWK7dgrb/2R9JIb8zq9h17dOUBhdV7CLo6ItGSkQYBffOF2Ou5wtqP2NA3T N9rEoP+h50jfo80xq4j1r3mCJzXfyYlWLZNzw2x5BGe+XyxiWRwC+2x4+yiqv6IzriEM fuXrcHsauWPdkNwTqAUt31tFVgYpbwvnD8NThfc3Z4YxzLdIRb1JExpoeuZAlbZVjurb kbFPPAxHbGw01+RTl5nssKqglXejrUk6qW39J2Eas+i02imuJL8VJjhw11y61M81MWAG 3WYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=nh4KDGVBWGo7A0FVjBKppZy0ekMRPfRj6Z6roxLEGS9KccdHNAHnpbXOqNbFNMvmP8 gjEnC1VZsuvF1096c0LWuu/6BzKjWZRNXAsTxXiymrI/TyrkU5fyJqDU+DYcn7B6XLJk 8DM42N7EpIazdm5iU+h1uk6DOBj28QLF1beXfpiecGw20vSvqC5BwnPK+IiZjPpr6IDv 2cjHd9sa4FMa7ApUQBQGlJuLnktM3li79iq4TMgzcpZyqcuWwteClioPlaVWWip1r00J y6REMYbr4kRHEN/pkFEwc7wBIfxfwkJZX4/cpw9xhCPTAMtkpCjqPeVi5/T7ph/wUgdO 1OBQ== X-Gm-Message-State: ACrzQf1ZVGE6cO9q1M5yHSgPhG/fElefdLeQ20KV4DZW3VWgWQH/Vq/9 /VP3MxEuFHLT9WFQBIrnyh3Whw== X-Google-Smtp-Source: AMsMyM53dC3y7erBKfzBQ+Nze0zZtnLF71JT4J25PfiX1YCvYNVOBA7+2R4vFWpiZCxVk3PBax4BpA== X-Received: by 2002:a05:6512:308f:b0:49a:5a59:aa25 with SMTP id z15-20020a056512308f00b0049a5a59aa25mr10629204lfd.44.1664288937219; Tue, 27 Sep 2022 07:28:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q12-20020ac25a0c000000b00494a1b242dasm182416lfn.14.2022.09.27.07.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:28:55 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 16:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_072900_293006_028D55ED X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 27/09/2022 15:04, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dpi support to enable the HDMI path. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> index 72049a530ae1..27f029ca760b 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>> .data = (void *)MTK_DPI }, >>> { .compatible = "mediatek,mt8192-dpi", >>> .data = (void *)MTK_DPI }, >>> + { .compatible = "mediatek,mt8195-dpi", >>> + .data = (void *)MTK_DPI }, >> >> It's compatible with the others. You don't need more compatibles. > > Hi Krzysztof, > > It's a bit confusing, because this compatible is used in both > mtk_drm_drv.c and in mtk_dpi.c > > Albeit it's entirely the same thing regarding the mtk_drm_drv module, > it's pretty different > regarding the mtk_dpi module. Sure, but this does not explain why do you need these entries here in mtk_drm_drv. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AB54C6FA82 for ; Tue, 27 Sep 2022 14:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dlbKXrpaIZu7whIe1Qy3Utq5JxcCZ9zjo/VLhdPaLkU=; b=J+iGhYH/xgep2Z o1j8pHJkrDKiB5nTfRR2whh/bRWpWQew1b4Qncq8J0e2X5eZroi/f+kduQ7JmgknIGEcr4l92xNtT HhymgV4mzPgnDjf/1MIT8UqDtSmO1TEHrS7ZWdcdT3HuEpPNami1QkRgrsl1PoeHiIhU5+SAQIBty YEFHV34x7s6DtudmQhYlSDpxWyXVrGCdnl27sobPHUjr70yqsBDqF/YIAiIfDnxgk7SmQSStZTcgx +cnKujLQ7vFFbWQlmRzBI5M7mLLOo8ZLmslhbiB6Z3oJsxcQaRBsTrsailLC1scjJxmhofYLPoDu9 IHxw+X5JhNk0cXV+yB/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odBa6-00BEvf-W7; Tue, 27 Sep 2022 14:29:08 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odBa1-00BEs6-Rd for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 14:29:03 +0000 Received: by mail-lf1-x129.google.com with SMTP id u18so15961277lfo.8 for ; Tue, 27 Sep 2022 07:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=t/zPAMSAQWX7Jp2Kkrznx3pd8BaYj/V4IovrZOP0p7CA9dHLcTpMosv+TEf82eIdQN ZzPiXw9rKlWK7dgrb/2R9JIb8zq9h17dOUBhdV7CLo6ItGSkQYBffOF2Ou5wtqP2NA3T N9rEoP+h50jfo80xq4j1r3mCJzXfyYlWLZNzw2x5BGe+XyxiWRwC+2x4+yiqv6IzriEM fuXrcHsauWPdkNwTqAUt31tFVgYpbwvnD8NThfc3Z4YxzLdIRb1JExpoeuZAlbZVjurb kbFPPAxHbGw01+RTl5nssKqglXejrUk6qW39J2Eas+i02imuJL8VJjhw11y61M81MWAG 3WYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=fCp5mwTiANwGmot0TQi7EfiI/ttPxDQxV6M13fP2PrlHsbwepEMSPu9Mql3SorjOy0 Xn7H1AQJSZ4xnJtkKgsK/vGkjUnPtMzDJdQCjxjVva6iCPFtHcoUXiZBVVkjkBle3XVp GokUOMF/Fqo+96CmOyKBAqzT1w+GI9E0Apn5DTmhFWUTMcSv+zW8t3+0aIrAbn3dLhQX YmOuFLMTTTrHIxND4fg1Jj3qBF0MVS4ErhBeRYQhVLUCewktAepmBboElOP9AcC9Hzn0 CcxA7YFtTa5vFOQfWl80i6sb2hbm1PxiIF+iKBghzCuDdyFg6Zc8/biPiSIZ4sarc6T9 fvlw== X-Gm-Message-State: ACrzQf0atnGk7j9sfeynQOfcAhPWyx7+lVDZiXHt4sx65+wHdn+IB359 WHzkhJPYNHI90wZ/ysnAZ/3FTg== X-Google-Smtp-Source: AMsMyM53dC3y7erBKfzBQ+Nze0zZtnLF71JT4J25PfiX1YCvYNVOBA7+2R4vFWpiZCxVk3PBax4BpA== X-Received: by 2002:a05:6512:308f:b0:49a:5a59:aa25 with SMTP id z15-20020a056512308f00b0049a5a59aa25mr10629204lfd.44.1664288937219; Tue, 27 Sep 2022 07:28:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q12-20020ac25a0c000000b00494a1b242dasm182416lfn.14.2022.09.27.07.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:28:55 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 16:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_072901_921950_0740A5E3 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/09/2022 15:04, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dpi support to enable the HDMI path. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> index 72049a530ae1..27f029ca760b 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>> .data = (void *)MTK_DPI }, >>> { .compatible = "mediatek,mt8192-dpi", >>> .data = (void *)MTK_DPI }, >>> + { .compatible = "mediatek,mt8195-dpi", >>> + .data = (void *)MTK_DPI }, >> >> It's compatible with the others. You don't need more compatibles. > > Hi Krzysztof, > > It's a bit confusing, because this compatible is used in both > mtk_drm_drv.c and in mtk_dpi.c > > Albeit it's entirely the same thing regarding the mtk_drm_drv module, > it's pretty different > regarding the mtk_dpi module. Sure, but this does not explain why do you need these entries here in mtk_drm_drv. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel