From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17B37C46467 for ; Sat, 7 Jan 2023 23:03:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B39A385369; Sun, 8 Jan 2023 00:03:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=@gmx.de header.b="jH6pZk39"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 94AC78545F; Sun, 8 Jan 2023 00:03:06 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ACCCB85355 for ; Sun, 8 Jan 2023 00:03:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673132580; bh=n7MZo4MywMuhh/cy6/c0edHndnu9mAWCr46HhUcSSJs=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=jH6pZk39UwChV8/uMwGhoDWQhpHMQ4qw5E+djGuBgfG9D4VUxtV7wI46GmxFKNPue yMIrqjSOMnLMFlU7ijam3Fyxf+IJ1IIBwTiCN9FX0VJPknWW9hHSMoN6W4OedrGgmx uS5j4fCHjF/cut+rLMmxioTLu+GJj8s2hSEhVt/6PfyHAmDOf6+jkQcN4vEZDX7IG3 8B7U/LCT9gUaqlGOBfN/Mlswqbt6dHzxQNdkBh7pNeVdf/DzhnP/MP+O3SlukOhQR1 UZnuYpvnIKF3dHNKIfn2XUgWNvA6s3IvhsaCwAkbbVOmYECNIICqWDjgtqnGvkfv96 JyMTuWZaj56hA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.123.94] ([88.152.145.137]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYvY8-1pIZYC2hSC-00UpMl; Sun, 08 Jan 2023 00:03:00 +0100 Message-ID: Date: Sun, 8 Jan 2023 00:02:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] board: sifive: unmatched: enable booting on a second NVME device Content-Language: en-US To: Aurelien Jarno Cc: open list , Paul Walmsley , Pragnesh Patel , Green Wan References: <20230107223239.2387940-1-aurelien@aurel32.net> From: Heinrich Schuchardt In-Reply-To: <20230107223239.2387940-1-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zs1SyUclaxJVfD+QDdS2z2BaqVOlICRrIvDi/ICrbmacZw7O6w5 F6/yh3MdfX/E2CGLLZtYzCDlPealjVtX/oE4AaRLdpiqN3zFybEH3iIV7+KeOLcvP9RguWr UkhCDKBGaTrG5mLH8cU+wSOP1+ceeS9JougM1txqTDK7KZ3/EDcSGHtDdg8x7YOPfKK4mjo qd5CaYRI1DXxnQgdeyQrQ== UI-OutboundReport: notjunk:1;M01:P0:RrOYT4DSVcE=;WuUoV7+eOmpk9rnjrwEHSILqZqu x8+8DhmpDfsynFWQGCIwu9k3km88VN9rdo3wmdYC2Nf607ahbxhRgYN6avbd8oEDBCtRyX8O4 f+SUHGzR4RZNmzaps8QXqs2/XyX2+JT/BLr9qZYX6h+RO2fd3oxrpow8tyB7fzxQWpZK8kl1K WKe7av1pl+DXT6wN/bHdQAdgMT8b/t69/ZR94q2ZCCebQMwDoAH4zCKE6kXn5Eg2T88kWPLmS /y8Q4qWHX9+ZzHdFtlUrksu4F3QOqFwvp28GTAf0znas/gxKAGwuBynu04aNKA+P348rvfwtH L9j0nqLkOdsUkBABo4b6ZUwJ7vMOcpub0yaaOnLi6L9LR3MUaDiFTQO6trYsoPXHh7EDzgdJK Nn9kjGE6+Y4DLEgxa9cWXfGggbjq1twyRNyNt7hewLefe2xaR8hmSWE+bd3kxoUTMgaGGjl95 6OWM+cfgYKgKWEtPY4HlZP/q9XYppqsyg5/Z7y4u5Yuk8PkEuL/LV3lYY3M8t7QFZgFvUDlx9 HQWhVQhXyrhlcBLj/wXANtt756/V6kF17mt43lBFjT3ywlx44x/wwC0VwYCiIKZL1ITfQxF8j tLH8mxsuWfr4GqC07RzI54fEKY31RVS5NMy61bG7V601lL4KW9EA6ykntdhPxcODwNmF2azK7 NzDwC3GQ0g+07Q1eWVii+Z9NUImgsM+qWI9EAIr8O+BBIHUqi7naTG6j+f6AZgczGk1yBFb28 ldZnjsN/x2rRiYlv4zSzf+s33Oz4ZbNQ/5NuZvDscOsS5hlcVp4nuG6zEKW0Eo/+r1FQFkJKd DHCIJwlkf1w0Bvc8lPh8mnsXnstJtk9nAOKmsJESiD++oG784o4xc9xLly45qEHT/+kW06q+X xY+fVdLe0c1x2mmxgeQrJp1Zza4niOLElC1s5gPanryMMj6Oqq6m/W24Pd+31Mjuv04X3uN4a fjgj28nD4iASUFuiR/qGu/gxbyM= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/7/23 23:32, Aurelien Jarno wrote: > The HiFive Unmatched board has a M2 slot for NVME and a PCIe slot that > can also be used for NVME. Enable support for a second NVME device, so > that software RAID-1 configurations can be supported at the u-boot > level. > > Signed-off-by: Aurelien Jarno > --- > include/configs/sifive-unmatched.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/sifive-unmatched.h b/include/configs/sifive= -unmatched.h > index 85fab92719..9261932af9 100644 > --- a/include/configs/sifive-unmatched.h > +++ b/include/configs/sifive-unmatched.h > @@ -19,6 +19,7 @@ > > #define BOOT_TARGET_DEVICES(func) \ > func(NVME, nvme, 0) \ > + func(NVME, nvme, 1) \ We can have up to three NVMe drives directly connected. Just put an adapter into the 2230 m.2 slot (e.g. https://www.aliexpress.com/item/32968036136.html, NGFF M.2 Key M to Key A+E Extension Cable NGFF Key M to A+E Adapter Card Board). > func(USB, usb, 0) \ > func(MMC, mmc, 0) \ > func(SCSI, scsi, 0) \ It is a generic problem that include/config_distro_bootcmd.h requires explicitly enumerating the device numbers instead of scanning all devices. With a SATA adapter you can have more than one instance of SCSI too (cf. IOCREST M.2 NGFF to Sata3 Adapter Card A-Key + E-Key to 2 Ports SATA 6Gb/S https://www.walmart.ca/en/ip/IOCREST-M-2-NGFF-to-Sata3-Adapter-Card-A-Key-= E-Key-to-2-Ports-SATA-6Gb-S-Free-Driver-PCIe-3-0-Bus-for-Wifi-SSD-HDD-PC-B= lack/PRD67D114EQV1VO). Reviewed-by: Heinrich Schuchardt