From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9A54C433EF for ; Mon, 2 May 2022 17:15:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C82B310F194; Mon, 2 May 2022 17:15:21 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D551A10F194 for ; Mon, 2 May 2022 17:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651511719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TNhZbt5WmLs9YdL2p377OAwSFXloJynsUEcZgN+34jM=; b=EAiKspRfImrtcdZ4wf21vE6xt7sOY+yxJ3xGIV+upESPXrZzXDskjMOjTuKmei09lnIb7P +3En3/EQeIiZjR4pRcUzqhto8e6FjjGSAqs8N+CLpr9PU2jpeG2EiB75h4iNP7Igm4jbdE rJ4DCmroYMklNlhC/MOcN1c+40i/lVM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-7hifPmKXM-C1pRWYUnqPPw-1; Mon, 02 May 2022 13:15:18 -0400 X-MC-Unique: 7hifPmKXM-C1pRWYUnqPPw-1 Received: by mail-wm1-f70.google.com with SMTP id i131-20020a1c3b89000000b00393fbb0718bso9085799wma.0 for ; Mon, 02 May 2022 10:15:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=TNhZbt5WmLs9YdL2p377OAwSFXloJynsUEcZgN+34jM=; b=sLuPQgC7DS/ODUYh4ixsj6JBlzEtC28b1c66g0z0YR3LIqweyl2CgZ0AzCoV4z1h1g RqZrj47wA3AzdNQuTBcuCxJR5gH7HG0EIDtXY8S/mdMoXs7gu1ATRcHFtPIdl3g3BsCq h7cOwmnlFOC7ighlM8f8shCAI8vgKGAW5ODWDBfCUFWAK188H9m0PA0p2GYUlHwbr62C Laogu6ETg4ArrwnuD5kEvi0p9XLkb1pE1IO8rYOHV2ID7V962+sBTlkoeE4mV17tfPy+ kPR6/N9kVMIQ8b8QiLA2dKE/yCX5O03ku1rLUMIjAFX9p0gGP79GEh3tC4/EbhuB53ld GyBg== X-Gm-Message-State: AOAM532zTkxlVIZYgap9TRv4Ybsn8tz5sPEHazsqLJ8r/+I3FVlF4D8t hJATM1qK5J/jt8OmcEUbvXAIDqwcC7VaKliT337SdqB8LqXzbVvV0dXeMKDqe+iTf7iihJHllV3 D7WkSOUcthD+RjqRickdOFFGJxvKI X-Received: by 2002:adf:d1c9:0:b0:203:c4f8:dd17 with SMTP id b9-20020adfd1c9000000b00203c4f8dd17mr10068563wrd.633.1651511717578; Mon, 02 May 2022 10:15:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsIQ70V0swN3ajpzcihZtgWd7Y7xEQmDVKoinoDZrZIjQMH2cqaPWdg9iqJElhYFpe1gjTzA== X-Received: by 2002:adf:d1c9:0:b0:203:c4f8:dd17 with SMTP id b9-20020adfd1c9000000b00203c4f8dd17mr10068550wrd.633.1651511717373; Mon, 02 May 2022 10:15:17 -0700 (PDT) Received: from [192.168.1.129] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id u21-20020adfa195000000b0020c5253d8c4sm7520081wru.16.2022.05.02.10.15.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 10:15:17 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 19:15:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() From: Javier Martinez Canillas To: Laurent Pinchart References: <20220502153900.408522-1-javierm@redhat.com> <20220502153900.408522-2-javierm@redhat.com> <5dd80287-1b09-d02c-9f67-5a0bb0a4566c@redhat.com> In-Reply-To: <5dd80287-1b09-d02c-9f67-5a0bb0a4566c@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , virtualization@lists.linux-foundation.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/2/22 18:55, Javier Martinez Canillas wrote: [snip] > >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME >> comment in drm_fbdev_generic_setup() that could be related. >> > > A FIXME makes sense, I'll add that to when posting a v3. There's actually a FIXME already in drm_fbdev_generic_setup(), so it's a documented issue [0]: void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) { ... /* * FIXME: This mixes up depth with bpp, which results in a glorious * mess, resulting in some drivers picking wrong fbdev defaults and * others wrong preferred_depth defaults. */ if (!preferred_bpp) preferred_bpp = dev->mode_config.preferred_depth; if (!preferred_bpp) preferred_bpp = 32; fb_helper->preferred_bpp = preferred_bpp; ... } [0]: https://elixir.bootlin.com/linux/v5.18-rc5/source/drivers/gpu/drm/drm_fb_helper.c#L2553 -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99292C433EF for ; Mon, 2 May 2022 17:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386538AbiEBRTY (ORCPT ); Mon, 2 May 2022 13:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386632AbiEBRSw (ORCPT ); Mon, 2 May 2022 13:18:52 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A5012631 for ; Mon, 2 May 2022 10:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651511719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TNhZbt5WmLs9YdL2p377OAwSFXloJynsUEcZgN+34jM=; b=EAiKspRfImrtcdZ4wf21vE6xt7sOY+yxJ3xGIV+upESPXrZzXDskjMOjTuKmei09lnIb7P +3En3/EQeIiZjR4pRcUzqhto8e6FjjGSAqs8N+CLpr9PU2jpeG2EiB75h4iNP7Igm4jbdE rJ4DCmroYMklNlhC/MOcN1c+40i/lVM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-9_GDwuzAN8KLHBputbILYw-1; Mon, 02 May 2022 13:15:19 -0400 X-MC-Unique: 9_GDwuzAN8KLHBputbILYw-1 Received: by mail-wr1-f72.google.com with SMTP id g7-20020adfbc87000000b0020ac76d254bso5514803wrh.6 for ; Mon, 02 May 2022 10:15:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=TNhZbt5WmLs9YdL2p377OAwSFXloJynsUEcZgN+34jM=; b=Yi3VAYc5nlvd4ILZZavDi0w1xIGTX7CwyItlMtYQNa/cw4YHvuSSXiVg5j0XTg1KTU tOFlk+PSoxFVzFEqaaxWF53HIGZ1jjYZDHvE8DNVR/jM9B4ZqiCfCK5IeaSwKBCH8w8U q9r+onu2cZHeyoWe2khTlDp01ShBwqLu21CJhte8oN0yUpeaVYojrr/pJcHBTTkToqw5 l+DRoSSgN1Q60SDHGvPPGV3bxF4PS8H/ZsdKflXvnhOR99T2EwGZYI6qPbOYILDM/FJh W2SssuEschF4D9n5jBSpRQ1Nfckd2jd83lvxmgPN3ISVZDiXulrz35mbn1noRvXQPFh3 r1Mw== X-Gm-Message-State: AOAM531n/NEMNZ4ZXp1jJlUU/gniR2JxW83vtdAPDwTLZy5+W9NXBBCv +TtBhNVPfmBDbpNGJLMBEiUL/BFiyBMgW3OYdBFQWqMhg2bL+xBB/RIE1d+0WodJCpRuqDb1pye 89B9W5VoFvT54XAjQd9hIllZq X-Received: by 2002:adf:d1c9:0:b0:203:c4f8:dd17 with SMTP id b9-20020adfd1c9000000b00203c4f8dd17mr10068562wrd.633.1651511717578; Mon, 02 May 2022 10:15:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsIQ70V0swN3ajpzcihZtgWd7Y7xEQmDVKoinoDZrZIjQMH2cqaPWdg9iqJElhYFpe1gjTzA== X-Received: by 2002:adf:d1c9:0:b0:203:c4f8:dd17 with SMTP id b9-20020adfd1c9000000b00203c4f8dd17mr10068550wrd.633.1651511717373; Mon, 02 May 2022 10:15:17 -0700 (PDT) Received: from [192.168.1.129] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id u21-20020adfa195000000b0020c5253d8c4sm7520081wru.16.2022.05.02.10.15.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 10:15:17 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 19:15:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() Content-Language: en-US From: Javier Martinez Canillas To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Daniel Vetter , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <20220502153900.408522-1-javierm@redhat.com> <20220502153900.408522-2-javierm@redhat.com> <5dd80287-1b09-d02c-9f67-5a0bb0a4566c@redhat.com> In-Reply-To: <5dd80287-1b09-d02c-9f67-5a0bb0a4566c@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/2/22 18:55, Javier Martinez Canillas wrote: [snip] > >> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME >> comment in drm_fbdev_generic_setup() that could be related. >> > > A FIXME makes sense, I'll add that to when posting a v3. There's actually a FIXME already in drm_fbdev_generic_setup(), so it's a documented issue [0]: void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) { ... /* * FIXME: This mixes up depth with bpp, which results in a glorious * mess, resulting in some drivers picking wrong fbdev defaults and * others wrong preferred_depth defaults. */ if (!preferred_bpp) preferred_bpp = dev->mode_config.preferred_depth; if (!preferred_bpp) preferred_bpp = 32; fb_helper->preferred_bpp = preferred_bpp; ... } [0]: https://elixir.bootlin.com/linux/v5.18-rc5/source/drivers/gpu/drm/drm_fb_helper.c#L2553 -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat