From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 6/8] pc: memhp: do not export nvdimm's memory via _CRS Date: Mon, 10 Oct 2016 21:10:38 +0800 Message-ID: References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-7-git-send-email-guangrong.xiao@linux.intel.com> <20161003152154.03766fc1@nial.brq.redhat.com> <20161010144710.5be84cfb@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Igor Mammedov Return-path: Received: from mga01.intel.com ([192.55.52.88]:47521 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbcJJNR1 (ORCPT ); Mon, 10 Oct 2016 09:17:27 -0400 In-Reply-To: <20161010144710.5be84cfb@nial.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/10/2016 08:47 PM, Igor Mammedov wrote: >> Based on ACPI Spec, the memory device (PNP0C80) and nvdimm device >> is notified by the same interruption: >> >> Scope (\_GPE) >> { >> Method (_L00) { >> Notify (\_SB.NVDR, 0x80) // Notify to NVDIMM root device >> Notify (\_SB.MEM0, 1) // Device Check to Memory Module >> } >> } >> >> So, it is better to reuse _E03 and only notify NVDIMM device if the >> hotplug event is triggered on a slot with nvdimm device attached? > It's only an example in spec but there isn't requirement to do it that way. > So I'd use a separate handler for now (we can always chain calls in future > is need arises or merge them together) No objection. Will do it. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btaSE-0001U3-HT for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btaSA-0003ND-Ad for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:17:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:1955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btaSA-0003MB-4M for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:17:14 -0400 References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-7-git-send-email-guangrong.xiao@linux.intel.com> <20161003152154.03766fc1@nial.brq.redhat.com> <20161010144710.5be84cfb@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: Date: Mon, 10 Oct 2016 21:10:38 +0800 MIME-Version: 1.0 In-Reply-To: <20161010144710.5be84cfb@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 6/8] pc: memhp: do not export nvdimm's memory via _CRS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On 10/10/2016 08:47 PM, Igor Mammedov wrote: >> Based on ACPI Spec, the memory device (PNP0C80) and nvdimm device >> is notified by the same interruption: >> >> Scope (\_GPE) >> { >> Method (_L00) { >> Notify (\_SB.NVDR, 0x80) // Notify to NVDIMM root device >> Notify (\_SB.MEM0, 1) // Device Check to Memory Module >> } >> } >> >> So, it is better to reuse _E03 and only notify NVDIMM device if the >> hotplug event is triggered on a slot with nvdimm device attached? > It's only an example in spec but there isn't requirement to do it that way. > So I'd use a separate handler for now (we can always chain calls in future > is need arises or merge them together) No objection. Will do it.