From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2550FC282DA for ; Fri, 19 Apr 2019 18:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E121A20449 for ; Fri, 19 Apr 2019 18:35:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j0rFiSpU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbfDSSfV (ORCPT ); Fri, 19 Apr 2019 14:35:21 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39816 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbfDSSfR (ORCPT ); Fri, 19 Apr 2019 14:35:17 -0400 Received: by mail-pf1-f194.google.com with SMTP id i17so2891807pfo.6 for ; Fri, 19 Apr 2019 11:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Sr+kNFMIkcwo//CDmxmC9uLH93cPMr+XU7onqGG1q8I=; b=j0rFiSpUBRI1BWAf+GpYAfMhZNcpl8wU1s6wiBXl1Bou6LchCneZ04ok/7dQtPm7fL Pocc3Z8YDzHByMoCxzLbFN03uNaRb7i4QB9IciA1NejrD5Z+aizOcMBZtHkiPVzDjiQc JLQbIPsGkGEDKIhBsrHzbY3/4gFXxxl/6rpQlcJXA3GPVFbLvwqkpTNEzthVE5XYlSoa rXP2HlLBcocNbcSPWW+jwW0i0uxBIgLR5L52morRotKUCmJ3I1tef4uT06Q2qB9zIpYM XzAP77xyDvI1WLNjIsk+FezK7dJr3djBQ5qbibgZHMVEmbce3n/6tXXvKPZ7WeLzPUtY rgig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sr+kNFMIkcwo//CDmxmC9uLH93cPMr+XU7onqGG1q8I=; b=bTomiOKqP3/VWzDWr5HCWwxyB+ENvs4rOlb5U6oTSQFfanmE3U4x/gGWIzhnx5QC0k 4WMXTv9+YMbiCwUkcmd5v5XuVnGGFuG1ThUZxxKjW7S5zIph+YFvY09SPYE8tkZFugAA tPxfbeMu1CoqPiNYGPQraaFjAC3svhSKly+aUtU6pyFd8QiDX4zjQq91tRfubaFOYg7M eXtbwVUzKwLLrrrahvtdp7KpyEvuwoTmlPydmFC432PiY1bjrjqA+y3fIuaDA/qzcWN4 ZCc46b1QbS1YKeodhN+bxhQNMzSFXGDxe3JorSKf690bAxDr+Nj/CHwDMdhye0AG+M2+ NA4Q== X-Gm-Message-State: APjAAAXx3in893j9Kr3pHn7NpGaK76c+C8OQyA/FGEX/sO7CjDRwQFlc SxEkTIe7V9DKKyBrnTAdUf2wpbYA X-Google-Smtp-Source: APXvYqwcIGUG2ZXeTxHCzqmVWJkFFOXNKBcA0Qq++qXGXF2xzG42UsxqAhCarF5XhyELa06r6ibiAA== X-Received: by 2002:a63:7d0a:: with SMTP id y10mr4398004pgc.292.1555687790688; Fri, 19 Apr 2019 08:29:50 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id l1sm5746614pgp.9.2019.04.19.08.29.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 08:29:49 -0700 (PDT) Subject: Re: [PATCH net-next 07/15] dsa: Add boilerplate helper to register DSA tag driver modules To: Andrew Lunn , David Miller Cc: netdev , Vivien Didelot References: <20190418023120.17067-1-andrew@lunn.ch> <20190418023120.17067-8-andrew@lunn.ch> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: Date: Fri, 19 Apr 2019 08:29:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418023120.17067-8-andrew@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/17/2019 7:31 PM, Andrew Lunn wrote: > A DSA tag driver module will need to register the tag protocols it > implements with the DSA core. Add a macro containing this boiler plate. > > The registration/unregistration code is currently just a stub. A Later > patch will add the real implementation. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c > index 756bade54fee..bff9b03a7752 100644 > --- a/net/dsa/tag_brcm.c > +++ b/net/dsa/tag_brcm.c > @@ -205,3 +205,14 @@ struct dsa_device_ops brcm_prepend_netdev_ops = { > > MODULE_LICENSE("GPL"); > MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_BRCM_PREPEND); > + > +static struct dsa_device_ops *ops_array[] = { > +#ifdef CONFIG_NET_DSA_TAG_BRCM > + &brcm_netdev_ops, > + #endif > +#ifdef CONFIG_NET_DSA_TAG_BRCM_PREPEND > + &brcm_prepend_netdev_ops, > + #endif > +}; The indentation for the two #endif is off by one tab here. Other than that: Reviewed-by: Florian Fainelli -- Florian