All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Mike Christie <michael.christie@oracle.com>,
	john.g.garry@oracle.com, mwilck@suse.com, hch@lst.de,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com
Subject: Re: [PATCH v2 01/15] scsi: Add struct for args to execution functions
Date: Mon, 12 Dec 2022 11:45:13 -0800	[thread overview]
Message-ID: <bc73ce08-5294-bebe-4bad-b123b226bcb8@acm.org> (raw)
In-Reply-To: <20221209061325.705999-2-michael.christie@oracle.com>

On 12/8/22 22:13, Mike Christie wrote:
> This begins to move the SCSI execution functions to use a struct for
> passing in optional args. This patch adds the new struct, temporarily
> converts scsi_execute and scsi_execute_req and add two helpers:
> 1. scsi_execute_args which takes the scsi_exec_args struct.
> 2. scsi_execute_cmd does not support the scsi_exec_args struct.
                     ^^^
                     which?

> @@ -232,8 +222,7 @@ int __scsi_execute(struct scsi_device *sdev, const unsigned char *cmd,
>   	memcpy(scmd->cmnd, cmd, scmd->cmd_len);
>   	scmd->allowed = retries;
>   	req->timeout = timeout;
> -	req->cmd_flags |= flags;
> -	req->rq_flags |= rq_flags | RQF_QUIET;
> +	req->rq_flags |= RQF_QUIET;

My understanding is that neither scsi_alloc_request() nor any of the
functions it calls copies its 'flags' argument into req->rq_flags. I
think this is a behavior change that has not been described in the
patch description. I'm not saying that this change is wrong but that
careful review is required if this change is retained.

Thanks,

Bart.


  parent reply	other threads:[~2022-12-12 19:45 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  6:13 [PATCH v2 00/15] scsi: Add struct for args to execution functions Mike Christie
2022-12-09  6:13 ` [PATCH v2 01/15] " Mike Christie
2022-12-09 10:40   ` John Garry
2022-12-09 17:15     ` Mike Christie
2022-12-09 18:37       ` Mike Christie
2022-12-09 18:47         ` Bart Van Assche
2022-12-12 16:17           ` John Garry
2022-12-12 17:03             ` Mike Christie
2022-12-12 19:45   ` Bart Van Assche [this message]
2022-12-12 21:17     ` Mike Christie
2022-12-09  6:13 ` [PATCH v2 02/15] scsi: libata: Convert to scsi_execute_args Mike Christie
2022-12-09  9:55   ` John Garry
2022-12-12  5:11   ` Damien Le Moal
2022-12-09  6:13 ` [PATCH v2 03/15] hwmon: drivetemp: Convert to scsi_execute_cmd Mike Christie
2022-12-09  9:56   ` John Garry
2022-12-12 20:58   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 04/15] scsi: ch: Convert to scsi_execute_args Mike Christie
2022-12-09  9:57   ` John Garry
2022-12-09 17:20   ` kernel test robot
2022-12-12 19:46   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 05/15] scsi: scsi_dh: " Mike Christie
2022-12-09 10:03   ` John Garry
2022-12-09 18:21   ` kernel test robot
2022-12-09 19:11   ` kernel test robot
2022-12-12 21:00   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 06/15] scsi: core: Convert to scsi_execute_args/cmd Mike Christie
2022-12-09 10:05   ` John Garry
2022-12-12 21:04   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 07/15] scsi: spi: Convert to scsi_execute_args Mike Christie
2022-12-09 10:10   ` John Garry
2022-12-12 21:16     ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 08/15] scsi: sd: " Mike Christie
2022-12-09 10:12   ` John Garry
2022-12-12 21:16     ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 09/15] scsi: zbc: " Mike Christie
2022-12-09 10:13   ` John Garry
2022-12-12 21:17   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 10/15] scsi: ses: " Mike Christie
2022-12-09 10:14   ` John Garry
2022-12-12 21:17   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 11/15] scsi: sr: Convert to scsi_execute_args/cmd Mike Christie
2022-12-09 10:20   ` John Garry
2022-12-12 21:18   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 12/15] scsi: virtio_scsi: Convert to scsi_execute_cmd Mike Christie
2022-12-09 10:21   ` John Garry
2022-12-12 21:29   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 13/15] scsi: target_core_pscsi: " Mike Christie
2022-12-09 10:22   ` John Garry
2022-12-12 21:30   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 14/15] scsi: cxlflash: Convert to scsi_execute_args/cmd Mike Christie
2022-12-09 10:23   ` John Garry
2022-12-12 21:30   ` Bart Van Assche
2022-12-09  6:13 ` [PATCH v2 15/15] scsi: Remove scsi_execute_req/scsi_execute functions Mike Christie
2022-12-09 10:23   ` John Garry
2022-12-12 21:31   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc73ce08-5294-bebe-4bad-b123b226bcb8@acm.org \
    --to=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.